Bug 23767 - Hardcoded %buildhost in hsh-initroot
Summary: Hardcoded %buildhost in hsh-initroot
Status: CLOSED NOTABUG
Alias: None
Product: Sisyphus
Classification: Development
Component: hasher (show other bugs)
Version: unstable
Hardware: all Linux
: P3 minor
Assignee: Dmitry V. Levin
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 00:34 MSD by Fr. Br. George
Modified: 2010-09-21 00:26 MSD (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fr. Br. George 2010-07-14 00:34:11 MSD 
$ grep buildhost /usr/bin/hsh-initroot
%buildhost ${USER:-`id -nu`}.hasher.altlinux.org

This misleads people that use hasher outside altlinux.org, making %buildhost rpm section close to non-informative.

I suggest ${USER:-`id -nu`}.hasher.$(hostname)
or ${USER:-`id -nu`}.hasher.$(hostname -d) instead.
Comment 1 Dmitry V. Levin 2010-07-14 00:58:34 MSD 
Please have a look at /etc/sisyphus_check/check.d/020-check-buildhost
The change you propose would render this test useless for locally built packages.
Comment 2 Fr. Br. George 2010-09-21 00:26:02 MSD 
Aw. So buildhost field isn't any "host" at all, it denotes build engine version instead. Swell.