Bug 34560 - gtkprintbackendcups.c: fix \n at end of a debugging note
Summary: gtkprintbackendcups.c: fix \n at end of a debugging note
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: libgtk+3 (show other bugs)
Version: unstable
Hardware: all Linux
: P3 minor
Assignee: Yuri N. Sedunov
QA Contact: qa-sisyphus
URL: https://gitlab.gnome.org/GNOME/gtk/me...
Keywords:
Depends on:
Blocks: 34559
  Show dependency tree
 
Reported: 2018-02-17 21:53 MSK by Ivan Zakharyaschev
Modified: 2019-02-24 08:51 MSK (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Zakharyaschev 2018-02-17 21:53:52 MSK
3.22.28-alt2

Without the newline in the debugging message, there is a mess because two
messages get into the same line.

https://gitlab.gnome.org/GNOME/gtk/merge_requests/24/diffs?commit_id=d2a4febfa75182d36ffd48eb05e9054e8bf9cf53 :

diff --git a/modules/printbackends/cups/gtkprintbackendcups.c b/modules/printbackends/cups/gtkprintbackendcups.c
index f391c69..7d061c5 100644
--- a/modules/printbackends/cups/gtkprintbackendcups.c
+++ b/modules/printbackends/cups/gtkprintbackendcups.c
@@ -2386,7 +2386,7 @@ cups_printer_handle_attribute (GtkPrintBackendCups *cups_backend,
   else
     {
       GTK_NOTE (PRINTING,
-		g_print ("CUPS Backend: Attribute %s ignored", ippGetName (attr)));
+		g_print ("CUPS Backend: Attribute %s ignored\n", ippGetName (attr)));
     }
 }
Comment 1 Ivan A. Melnikov 2019-02-24 08:51:31 MSK
This change made it into 3.22.29-alt1 build in March 2018.