10407 2006-12-12 18:18:30 +0300 ugly initscript 2006-12-19 20:35:22 +0300 1 1 4 Development Sisyphus unfs3 unstable all Linux CLOSED FIXED P2 critical --- 1 gns rider vvk qa-sisyphus oldest_to_newest 42981 0 gns 2006-12-12 18:18:30 +0300 вложенный в пакет инитскрипт сказочно крив. в аттаче нормальный скрипт и патч unfsd для создания pidfile 42982 1 1702 gns 2006-12-12 18:19:26 +0300 Created attachment 1702 pidfile creation patch 42983 2 1703 gns 2006-12-12 18:20:08 +0300 Created attachment 1703 init.d/nfs 42984 3 gns 2006-12-12 18:21:56 +0300 можно обойтись без патча, запускать как start_daemon --make-pidfile --pidfile "$PIDFILE" --lockfile "$LOCKFILE" --expect-user root -- $NFSD -b $UNFS_OPTS но лучше зопатчить 42993 4 mike 2006-12-12 22:25:17 +0300 2 rider: сделай pls unfs3 rem gvy unfs3 add mike а то промазал, и так оно и застряло 2 gns: спасибо, всё руки не доходили до сказочно кривого... 43032 5 gns 2006-12-13 20:13:11 +0300 2 mike: пожалуйста, приходите еще :) 43251 6 mike 2006-12-17 16:15:50 +0300 fixed in 0.9.16-alt1 43253 7 gns 2006-12-17 16:22:24 +0300 за неделю активного использования обнаружил проблему: через некоторое время service nfs status начинает отвечать nfs is dead, but stale pidfile found. хот глазами видно, что это не так: содержимое /var/run/nfs.pid соответствует pid unfsd. проблема кажется решилась заменой в скрипте $NFSD на unfsd во всех вызовах start-stop-daemon 43434 8 mike 2006-12-18 15:07:43 +0300 Видишь, пришёл ещё :) Сделал чуть иначе в 0.9.16-alt2: NFSD=unfsd BINARY=/usr/sbin/$NFSD 43507 9 gns 2006-12-19 20:20:47 +0300 вроде BINARY там только для [ -f $BINARY. а зачем проверять наличие каждого бинарника, у нас же вроде как пакетная система ? 43508 10 mike 2006-12-19 20:31:54 +0300 (смутившись) Ну мало ли. :) По-ъорошему, надо бы [ -x ... 43509 11 gns 2006-12-19 20:35:21 +0300 ну, имхо -x нужен только для поддержки legacy admins, делающих chmod -x /usr/bin/service вместо chkconfig service off ;)) 1702 2006-12-12 18:19:26 +0300 2006-12-12 18:19:26 +0300 pidfile creation patch unfs3-0.9.16-alt.pidfile.patch text/plain 2219 gns SW5kZXg6IGRhZW1vbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRhZW1vbi5jCShyZXZpc2lvbiAxKQorKysg ZGFlbW9uLmMJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAKICNpbmNsdWRlIDxzeXNs b2cuaD4KICNpbmNsdWRlIDx0aW1lLmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+Ci0KKyNpbmNsdWRl IDxlcnJuby5oPgogI2lmIEhBVkVfUlBDX1NWQ19TT0NfSCA9PSAxCiAjIGluY2x1ZGUgPHJwYy9z dmNfc29jLmg+CiAjZW5kaWYKQEAgLTU0LDYgKzU0LDcgQEAKIGludCBvcHRfZXhwaXJlX3dyaXRl cnMgPSBGQUxTRTsKIGludCBvcHRfZGV0YWNoID0gVFJVRTsKIGNoYXIgKm9wdF9leHBvcnRzID0g Ii9ldGMvZXhwb3J0cyI7CitjaGFyICpvcHRfcGlkZmlsZSA9ICIvdmFyL3J1bi91bmZzZC5waWQi OwogaW50IG9wdF9jbHVzdGVyID0gRkFMU0U7CiBjaGFyICpvcHRfY2x1c3Rlcl9wYXRoID0gIi8i OwogaW50IG9wdF90Y3Bvbmx5ID0gRkFMU0U7CkBAIC0xMTQsNyArMTE1LDcgQEAKIHN0YXRpYyB2 b2lkIHBhcnNlX29wdGlvbnMoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogewogICAgIGludCBvcHQg PSAwOwotICAgIGNoYXIgKm9wdHN0cmluZyA9ICJiY0M6ZGU6aGw6bTpuOnBzdHV3IjsKKyAgICBj aGFyICpvcHRzdHJpbmcgPSAiYmNDOmRlOmhsOm06bjpwc3R1d2k6IjsKIAogICAgIHdoaWxlIChv cHQgIT0gLTEpIHsKIAlvcHQgPSBnZXRvcHQoYXJnYywgYXJndiwgb3B0c3RyaW5nKTsKQEAgLTIx MCw2ICsyMTEsOSBAQAogCSAgICBjYXNlICc/JzoKIAkJZXhpdCgxKTsKIAkJYnJlYWs7CisJICAg IGNhc2UgJ2knOgorCQlvcHRfcGlkZmlsZSA9IG9wdGFyZzsKKwkJYnJlYWs7CiAJfQogICAgIH0K IH0KQEAgLTI1Niw2ICsyNjAsMTIgQEAKIAogICAgIGJhY2tlbmRfc2h1dGRvd24oKTsKIAorICAg IC8vIGtpbGxwaWQKKyAgICBmcHJpbnRmKHN0ZGVyciwgIkRlbGV0aW5nIHBpZGZpbGUgJXNcbiIs IG9wdF9waWRmaWxlKTsgLy8gb2ssIGlmIGZvcmsgZG9uZSB0aGlzIG1lc2FnZSBnb2VzIHRvIC9k ZXYvbnVsbAorICAgIGlmICh1bmxpbmsob3B0X3BpZGZpbGUpID09IC0xKSB7CisJbG9nbXNnKExP R19FTUVSRywiRmFpbGVkIHRvIGRlbGV0ZSBwaWRmaWxlIik7CisgICAgfQorCiAgICAgZXhpdCgx KTsKIH0KIApAQCAtNzcwLDYgKzc4MCwyMSBAQAogCS8qIG5vIHVtYXNrIHRvIG5vdCBzY3JldyB1 cCBjcmVhdGUgbW9kZXMgKi8KIAl1bWFzaygwKTsKIAorCS8vIHBpZGZpbGUgYWx3YXlzIGNyZWF0 ZWQgaGVyZSAtIGJ5IHBhcmVudCBpZiAhb3B0X2RldGFjaCBvciBieSBjaGlsZAorCWludCBwaWRf ZmQgPSBvcGVuKG9wdF9waWRmaWxlLCBPX1JEV1IgfCBPX0NSRUFULCAwNjQwKTsKKwlpZiAocGlk X2ZkIDwgMCkgeworCSAgICBmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0byBvcGVuIHBpZGZpbGUg JXM6ICVzIVxuIiwgb3B0X3BpZGZpbGUsIHN0cmVycm9yKGVycm5vKSk7CisJICAgIGV4aXQoMCk7 CisJfQorCWlmIChsb2NrZihwaWRfZmQsIEZfVExPQ0ssIDApIDwgMCkgeworCSAgICBmcHJpbnRm KHN0ZGVyciwgIkZhaWxlZCB0byBnZXQgYSBsb2NrIG9uIHBpZGZpbGUgJXM6ICVzIVxuIiwgb3B0 X3BpZGZpbGUsIHN0cmVycm9yKGVycm5vKSk7CisJICAgIGV4aXQoMCk7CisJfQorCWNoYXIgc3Ry WzE2XTsKKworCXNucHJpbnRmKHN0ciwgc2l6ZW9mKHN0ciksICIlZFxuIiwgZ2V0cGlkKCkpOwor CXdyaXRlKHBpZF9mZCwgc3RyLCBzdHJsZW4oc3RyKSk7CisKIAkvKiBkZXRhY2ggZnJvbSB0ZXJt aW5hbCAqLwogCWlmIChvcHRfZGV0YWNoKSB7CiAJICAgIHNldHNpZCgpOwpJbmRleDogZGFlbW9u LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gZGFlbW9uLmgJKHJldmlzaW9uIDEpCisrKyBkYWVtb24uaAkod29y a2luZyBjb3B5KQpAQCAtMzMsNiArMzMsNyBAQAogZXh0ZXJuIGludAlvcHRfZXhwaXJlX3dyaXRl cnM7CiBleHRlcm4gaW50CW9wdF9kZXRhY2g7CiBleHRlcm4gY2hhcgkqb3B0X2V4cG9ydHM7Citl eHRlcm4gY2hhcgkqb3B0X3BpZGZpbGU7CiBleHRlcm4gaW50CW9wdF9jbHVzdGVyOwogZXh0ZXJu IGNoYXIJKm9wdF9jbHVzdGVyX3BhdGg7CiBleHRlcm4gaW50CW9wdF9zaW5nbGV1c2VyOwo= 1703 2006-12-12 18:20:08 +0300 2006-12-12 18:20:08 +0300 init.d/nfs nfs.init text/plain 1885 gns IyEvYmluL3NoCiMKIyBuZnMgICAgICAgICAgIFRoaXMgc2hlbGwgc2NyaXB0IHRha2VzIGNhcmUg b2Ygc3RhcnRpbmcgYW5kIHN0b3BwaW5nCiMgICAgICAgICAgICAgICB0aGUgTkZTIHNlcnZpY2Vz LgojCiMgY2hrY29uZmlnOiAyMzQgNjAgMjAKIyBkZXNjcmlwdGlvbjogTkZTIGlzIGEgcG9wdWxh ciBwcm90b2NvbCBmb3IgZmlsZSBzaGFyaW5nIGFjcm9zcyBUQ1AvSVAgXAojICAgICAgICAgICAg ICBuZXR3b3Jrcy4gVGhpcyBzZXJ2aWNlIHByb3ZpZGVzIE5GUyBzZXJ2ZXIgZnVuY3Rpb25hbGl0 eSwgXAojICAgICAgICAgICAgICB3aGljaCBpcyBjb25maWd1cmVkIHZpYSB0aGUgL2V0Yy9leHBv cnRzIGZpbGUuCiMgcHJvYmU6IHRydWUKCldJVEhPVVRfUkNfQ09NUEFUPTEKCiMgU291cmNlIGZ1 bmN0aW9uIGxpYnJhcnkuCi4gL2V0Yy9pbml0LmQvZnVuY3Rpb25zCgojIFNvdXJjZSBuZXR3b3Jr aW5nIGNvbmZpZ3VyYXRpb24uCiMgQ2hlY2sgdGhhdCBuZXR3b3JraW5nIGlzIHVwLgpTb3VyY2VJ Zk5vdEVtcHR5IC9ldGMvc3lzY29uZmlnL25ldHdvcmsgJiYgWyAiJE5FVFdPUktJTkciICE9IG5v IF0gfHwgZXhpdAoKU291cmNlSWZOb3RFbXB0eSAvZXRjL3N5c2NvbmZpZy92c2VydmVyCgpORlNE PS91c3Ivc2Jpbi91bmZzZApFWFBPUlRGUz0vdXNyL3NiaW4vZXhwb3J0ZnMKRVhQT1JUUz0vZXRj L2V4cG9ydHMKClsgLXggIiRORlNEIiAgXSB8fCBleGl0CgpTb3VyY2VJZk5vdEVtcHR5IC9ldGMv c3lzY29uZmlnL25mcwpTb3VyY2VJZk5vdEVtcHR5IC9ldGMvc3lzY29uZ2lnL3VuZnMzCgpMT0NL RklMRT0vdmFyL2xvY2svc3Vic3lzL25mcwpQSURGSUxFPS92YXIvcnVuL25mcy5waWQKClJFVFZB TD0wCgpzdGFydCgpCnsKCSMgRG9uJ3Qgc3RhcnQgYW55dGhpbmcgd2hlbiBleHBvcnRzIGlzIGVt cHR5CglbIC1zICIkRVhQT1JUUyIgXSB8fCByZXR1cm4KCgkjIG5mc2QKCXN0YXJ0X2RhZW1vbiAt LXBpZGZpbGUgIiRQSURGSUxFIiAtLWxvY2tmaWxlICIkTE9DS0ZJTEUiIC0tZXhwZWN0LXVzZXIg cm9vdCAtLSAkTkZTRCAtaSAkUElERklMRSAkVU5GU19PUFRTCglSRVRWQUw9JD8KCXJldHVybiAk UkVUVkFMCn0KCnN0b3AoKQp7CglzdG9wX2RhZW1vbiAtLXBpZGZpbGUgIiRQSURGSUxFIiAtLWxv Y2tmaWxlICIkTE9DS0ZJTEUiIC0tZXhwZWN0LXVzZXIgcm9vdCAtLSAkTkZTRAoJUkVUVkFMPSQ/ CglyZXR1cm4gJFJFVFZBTAp9CgpyZXN0YXJ0KCkKewoJc3RvcAoJc3RhcnQKfQoKcmVsb2FkKCkK ewoJZWNobyAtbiAiUmVleHBvcnRpbmcgTkZTIGZpbGUgc3lzdGVtczogIgoJc3RvcF9kYWVtb24g LS1waWRmaWxlICIkUElERklMRSIgLS1leHBlY3QtdXNlciByb290IC1IVVAgJE5GU0QKCVJFVFZB TD0kPwoJcmV0dXJuICRSRVRWQUwKfQoKc3RhdHVzZXMoKQp7CglzdGF0dXMgLS1sb2NrZmlsZSAi JExPQ0tGSUxFIiAtLXBpZGZpbGUgIiRQSURGSUxFIiAtLWV4cGVjdC11c2VyIHJvb3QgJE5GU0QK CVJFVFZBTD0kPwp9CgojIFNlZSBob3cgd2Ugd2VyZSBjYWxsZWQuCmNhc2UgIiQxIiBpbgoJc3Rh cnQpCgkJc3RhcnQKCQk7OwoJc3RvcCkKCQlzdG9wCgkJOzsKCXJlc3RhcnQpCgkJcmVzdGFydAoJ CTs7CglyZWxvYWQpCgkJcmVsb2FkCgkJOzsKCWNvbmRzdG9wKQoJCWlmIFsgLWUgIiRMT0NLRklM RSIgXTsgdGhlbgoJCQlzdG9wCgkJZmkKCQk7OwoJY29uZHJlc3RhcnQpCgkJaWYgWyAtZSAiJExP Q0tGSUxFIiBdOyB0aGVuCgkJCXJlc3RhcnQKCQlmaQoJCTs7CglzdGF0dXMpCgkJc3RhdHVzZXMK CQk7OwoJKikKCQltc2dfdXNhZ2UgIiR7MCMjKi99IHtzdGFydHxzdG9wfHJlbG9hZHxyZXN0YXJ0 fGNvbmRzdG9wfGNvbmRyZXN0YXJ0fHN0YXR1c30iCgkJUkVUVkFMPTEKZXNhYwoKZXhpdCAkUkVU VkFMCg==