10434 2006-12-15 21:35:30 +0300 mount-2.12r-alt3 does not pass the "quiet" option to vfat properly 2007-02-23 20:15:42 +0300 1 1 4 Development Sisyphus mount unstable all Linux CLOSED FIXED P3 major --- 1 vsu ldv boyarsh evg glebfm lav ldv legion mike placeholder vt qa-sisyphus oldest_to_newest 43116 0 vsu 2006-12-15 21:35:30 +0300 Between mount-2.12r-alt1 and mount-2.12r-alt3 handling of the "quiet" mount option for vfat filesystem has been broken (/etc/mtab shows the "quiet" option, but actually it is not enabled). Steps to Reproduce: With mount-2.12r-alt1: # strace -q -e mount -s 1024 mount -t vfat -o quiet /dev/sdb1 /mnt/disk mount("/dev/sdb1", "/mnt/disk", "vfat", MS_MGC_VAL, "quiet") = 0 With mount-2.12r-alt3: # strace -q -e mount -s 1024 mount -t vfat -o quiet /dev/sdb1 /mnt/disk mount("/dev/sdb1", "/mnt/disk", "vfat", MS_MGC_VAL|MS_VERBOSE, "") = 0 43118 1 ldv 2006-12-15 22:26:27 +0300 Between alt1 and alt2 (very likely) or between alt2 and alt3? 43121 2 vsu 2006-12-15 22:33:45 +0300 Seems that the problem is caused by the addition of MS_SILENT to kernel headers: http://lkml.org/lkml/2006/3/14/112 Rebuilding mount-2.12r-alt1 package fails for me due to broken chstk on x86_64, but the mount binary which gets built is broken in the same way (eats the "quiet" option). 43124 3 ldv 2006-12-15 22:43:54 +0300 Yes, regression is due to rebuild. 43125 4 ldv 2006-12-16 00:03:10 +0300 Looks like MS_SILENT handling in mount is wrong: #ifdef MS_SILENT if (om->mask == MS_SILENT && om->inv) { mount_quiet = 1; verbose = 0; } i.e. MS_SILENT meaning is reverted. 43126 5 ldv 2006-12-16 00:22:45 +0300 Cited hunk (while buggy) is not relevant to the problem. I wonder how mount should work when "quiet" option is given. Should it set MS_SILENT (== MS_VERBOSE) flag in mount(2) call? Should it pass "quiet" option to mount(2) call? 44864 6 lav 2007-01-29 02:18:45 +0300 Возможно ли решить данную неприятную проблему в ближайшие сроки? 44869 7 evg 2007-01-29 05:14:00 +0300 +1 к предыдущему комментатору. 44896 8 ldv 2007-01-29 17:45:07 +0300 Я бы хотел услышать предложения возможных решений. 44987 9 ldv 2007-02-02 03:31:34 +0300 Disabled MS_SILENT support in 2.12r-alt5.