12117 2007-06-23 17:07:55 +0400 Gpart fails to open large files (e.g. disk images) 2007-12-20 16:32:31 +0300 1 1 4 Development Sisyphus gpart unstable all Linux CLOSED FIXED P2 minor --- 1 khedin mike mike vsu qa-sisyphus oldest_to_newest 51834 0 khedin 2007-06-23 17:07:55 +0400 When trying to open very large files (but not devices), gpart stops with "File too large" error messages. replacing O_RDONLY with O_RDONLY|O_LARGEFILE and adding -D_LARGEFILE64_SOURCE to the compile options seems to help. So I'm attaching a patch, hoping it's useful. Steps to Reproduce: 1. # dd if=/dev/sda of=somefile /dev/sda size >= several gig 2. # gpart -g somefile Actual Results: fails to open Expected Results: gpart should work as if it was operating on a drive 51835 1 2031 khedin 2007-06-23 17:08:53 +0400 Created attachment 2031 The patch that adds O_LARGEFILE 51843 2 mike 2007-06-23 20:46:59 +0400 let's assign it to myself 59776 3 mike 2007-12-20 16:32:28 +0300 Патч приложен к сборке 0.1h-alt4, спасибо! (не прошло и полгода :) 2031 2007-06-23 17:08:53 +0400 2007-06-23 17:08:53 +0400 The patch that adds O_LARGEFILE gpart-lodin.patch text/plain 1401 khedin ZGlmZiAtdXIgZ3BhcnQtMC4xaC9tYWtlLmRlZnMgZ3BhcnQtMC4xaC1sb2Rpbi9tYWtlLmRlZnMK LS0tIGdwYXJ0LTAuMWgvbWFrZS5kZWZzCTIwMDctMDYtMjMgMTY6MzY6MjYgKzA0MDAKKysrIGdw YXJ0LTAuMWgtbG9kaW4vbWFrZS5kZWZzCTIwMDctMDYtMjMgMTY6MzM6MjMgKzA0MDAKQEAgLTIs NyArMiw3IEBACiAjCiAjCiBDQyAgICAgID0gZ2NjCi1DRkxBR1MgID0gJChSUE1fT1BUX0ZMQUdT KSAtc3RkPWdudTk5IC1wZWRhbnRpYworQ0ZMQUdTICA9ICQoUlBNX09QVF9GTEFHUykgLXN0ZD1n bnU5OSAtcGVkYW50aWMgLURfTEFSR0VGSUxFNjRfU09VUkNFCiBMREZMQUdTID0KIE1BS0VERVAg PSBnY2MgLU0KIElOU1RBTEwgPSBpbnN0YWxsCmRpZmYgLXVyIGdwYXJ0LTAuMWgvc3JjL2dwYXJ0 LmMgZ3BhcnQtMC4xaC1sb2Rpbi9zcmMvZ3BhcnQuYwotLS0gZ3BhcnQtMC4xaC9zcmMvZ3BhcnQu YwkyMDAxLTAyLTA3IDIxOjA4OjA4ICswMzAwCisrKyBncGFydC0wLjFoLWxvZGluL3NyYy9ncGFy dC5jCTIwMDctMDYtMjMgMTY6MzU6MjcgKzA0MDAKQEAgLTQ5LDEzICs0OSwyMSBAQAogI2luY2x1 ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RkYXJnLmg+CisK ICNpbmNsdWRlIDxmY250bC5oPgorI2lmbmRlZiBPX0xBUkdFRklMRQorI3dhcm5pbmcgbm8gbGFy Z2UgZmlsZSBzdXBwb3J0LCBidXQgT0sgZm9yIGRldmljZXMKKyNkZWZpbmUgT19MQVJHRUZJTEUg MAorLypzbyBub3cgeHxPX0xBUkdFRklMRSA9PSB4Ki8KKyNlbmRpZgorCiAjaW5jbHVkZSA8dW5p c3RkLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSA8Y3R5cGUuaD4KICNpbmNsdWRl IDxlcnJuby5oPgogI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+ CisKICNpbmNsdWRlICJncGFydC5oIgogCiAKQEAgLTc5NCw3ICs4MDIsNyBAQAogCSAqIHNwZWNp YWwgZmlsZSBvciBqdXN0IGEgcmVndWxhciBmaWxlLgogCSAqLwogCi0JaWYgKChkLT5kX2ZkID0g b3BlbihkZXYsT19SRE9OTFkpKSA9PSAtMSkKKwlpZiAoKGQtPmRfZmQgPSBvcGVuKGRldixPX1JE T05MWXxPX0xBUkdFRklMRSkpID09IC0xKQogCQlwcihGQVRBTCxFTV9PUEVORkFJTCxkZXYsc3Ry ZXJyb3IoZXJybm8pKTsKIAogCS8qCkBAIC05NDMsNyArOTUzLDcgQEAKIAlzNjRfdAkJYmluY3Is IG5vZmZzZXQsIHN0YXJ0OwogCWJ5dGVfdAkJKnVidWY7CiAKLQlpZiAoKGQtPmRfZmQgPSBvcGVu KGQtPmRfZGV2LE9fUkRPTkxZKSkgPT0gLTEpCisJaWYgKChkLT5kX2ZkID0gb3BlbihkLT5kX2Rl dixPX1JET05MWXxPX0xBUkdFRklMRSkpID09IC0xKQogCQlwcihGQVRBTCxFTV9PUEVORkFJTCxk LT5kX2RldixzdHJlcnJvcihlcnJubykpOwogCiAJLyoK