12119 2007-06-23 21:45:49 +0400 [IceWM] [dock] Unneeded xxkb icon shown over the taskbar 2009-01-01 18:31:10 +0300 1 1 4 Development Sisyphus xxkb unstable all Linux CLOSED FIXED P2 minor --- 1 khedin placeholder glebfm ldv mike placeholder vsu vt cas oldest_to_newest 51847 0 khedin 2007-06-23 21:45:49 +0400 When I start a docking-capable application (e.g. Opera, SIM, linuxdc++), xxkb will attach it's flag icon to the dock (partly covering the clock in my xxkb and IceWM config) as well as to the app's window. However, if the app is already started, only the main window is processed, which is the right behaviour. After several hours of debugging, I was able to locate the root of the problem and to create a "fix". When xxkbstarts, it calls the XQueryTree (3) function which returns a list of all windows. The docklets never get into this list. However, when processing a ReparentNotify event, xxkb does not know whether the window is a docklet or a real app. My solution was to iterate the XQueryTree's return and only call AddWindow if the window is there. Honestly, I find it a bit ugly, but I haven't found a better way. The patch is attached. Is there a more elegant solution? 51848 1 2032 khedin 2007-06-23 21:48:04 +0400 Created attachment 2032 The patch that fixes this bug See also the project's BZ ticket: http://sourceforge.net/tracker/index.php?func=detail&aid=1734282&group_id=84234&atid=572200 I've seen no reaction there yet. 52206 2 khedin 2007-06-29 17:31:47 +0400 xxkb team has accepted the patch. 56855 3 khedin 2007-10-23 14:13:07 +0400 Адаптировал патч к xxkb-1.10-alt3. Описание данного бага (коротко): Если xxkb настроен так, чтобы показывать флажок на каждом окне, и запущен IceWM, то при запуске приложения, которое отображает себя в доке (opera, sim, linuxdcpp etc) появляется паразитный флажок поверх часов IceWM, который никакого смысла не несет, только вид портит. Если приложение запущено до xxkb, эффекта не наблюдается. Описание патча: Перебираем все окна, и только если это реальное окно настоящего приложения вешаем на него флажок. Примечание: Наверняка можно сделать намного лучше. 56856 4 2233 khedin 2007-10-23 14:14:40 +0400 Created attachment 2233 Patch for xxkb-1.10-alt3 57050 5 mike 2007-10-28 20:54:51 +0300 Константин, мож возьмётесь поддерживать xxkb? У меня ещё #1712 наболело, хотя сейчас ловится реже... 57560 6 khedin 2007-11-07 09:33:08 +0300 Ну, страшно конечно =) Но попробовать можно, надо ж с чего-то начинать. 71671 7 dottedmag 2008-06-13 12:59:26 +0400 83781 8 ldv 2009-01-01 18:31:10 +0300 Applied in xxkb-1.11-alt1 2032 2007-06-23 21:48:04 +0400 2007-10-23 14:14:40 +0400 The patch that fixes this bug xxkb-evadedock.patch text/plain 1006 khedin ZGlmZiAtdXIgeHhrYi0xLjExL3h4a2IuYyB4eGtiLTEuMTEtbG9kaW4veHhrYi5jCi0tLSB4eGti LTEuMTEveHhrYi5jCTIwMDctMDMtMTUgMDA6NTQ6NTMgKzAzMDAKKysrIHh4a2ItMS4xMS1sb2Rp bi94eGtiLmMJMjAwNy0wNi0xMCAwODo0Mjo1MyArMDQwMApAQCAtNjA2LDcgKzYwNiwzMiBAQAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVwYXJfZXZ0LT5wYXJlbnQgIT0g cm9vdF93aW4gJiYKIAkJCQkgICAgQkFTRShyZXBhcl9ldnQtPnBhcmVudCkgIT0gQkFTRSh0ZW1w X3dpbikgJiYKIAkJCQkgICAgcmVwYXJfZXZ0LT5vdmVycmlkZV9yZWRpcmVjdCAhPSBUcnVlKSB7 Ci0JCQkJCUFkZFdpbmRvdyh0ZW1wX3dpbiwgcmVwYXJfZXZ0LT5wYXJlbnQpOworCisJCQkJCVdp bmRvdyByd2luLCBwYXJlbnQsICpjaGlsZHJlbiwgKmNoaWxkLCBhcHA7CisJCQkJCWludCBudW07 CisJCQkKKwkJCQkJLyogSXRlcmF0ZSB0aHJvdWdoIHRoZSB3aW5kb3cgbGlzdCB1bnRpbCB3ZSBm aW5kCisJCQkJCSogdGhlIHdpbmRvdyB0aGUgZXZlbnQgd2FzIGFib3V0LgorCQkJCQkqIAorCQkJ CQkqIFRoZSBjb2RlIHdhcyBtb3N0bHkgY29waWVkIAorCQkJCQkqICovCisJCQkKKwkJCQkJWFF1 ZXJ5VHJlZShkcHksIHJvb3Rfd2luLCAmcndpbiwgJnBhcmVudCwgJmNoaWxkcmVuLCAmbnVtKTsK KwkJCQkJY2hpbGQgPSBjaGlsZHJlbjsKKwkJCQkJCisJCQkJCXdoaWxlIChudW0gLS0+IDApIHsK KwkJCQkJCWFwcCA9IE5vbmU7CisJCQkJCQlHZXRBcHBXaW5kb3coKmNoaWxkLCAmYXBwKTsKKwkJ CQorCQkJCQkJaWYgKGFwcCA9PSB0ZW1wX3dpbikgeworCQkJCQkJCUFkZFdpbmRvdyh0ZW1wX3dp biwgcmVwYXJfZXZ0LT5wYXJlbnQpOworCQkJCQkJCWJyZWFrOworCQkJCQkJfQorCQkJCQkJY2hp bGQrKzsKKwkJCQkJfTsKKwkJCQkKKwkJCQkJaWYgKGNoaWxkcmVuICE9IE5vbmUpCisJCQkJCQlY RnJlZShjaGlsZHJlbik7CiAJCQkJfQogCQkJCWJyZWFrOwogCg== 2233 2007-10-23 14:14:40 +0400 2007-10-23 14:14:40 +0400 Patch for xxkb-1.10-alt3 xxkb-lodin.patch text/plain 1095 khedin ZGlmZiAtdXIgeHhrYi0xLjEwL3h4a2IuYyB4eGtiLTEuMTAtbG9kaW4veHhrYi5jCi0tLSB4eGti LTEuMTAveHhrYi5jCTIwMDctMTAtMDUgMDM6MzA6NDQgKzA0MDAKKysrIHh4a2ItMS4xMC1sb2Rp bi94eGtiLmMJMjAwNy0xMC0wNSAwMzoyOTozMyArMDQwMApAQCAtMzUyLDcgKzM1MiwzNCBAQAog ICAgICAgICAgICAgIEJBU0UoZXYuY29yZS54cmVwYXJlbnQucGFyZW50KSA9PSBCQVNFKHdpbikg fHwKICAgICAgICAgICAgICBldi5jb3JlLnhyZXBhcmVudC5vdmVycmlkZV9yZWRpcmVjdCA9PSBU UlVFICkgYnJlYWs7CiAKLSAgICAgICAgICBBZGRXaW5kb3cod2luLCBldi5jb3JlLnhyZXBhcmVu dC5wYXJlbnQpOworCQkvKiAgVGhpcyBpcyBhbiB1Z2x5IGhhY2sgcGVyZm9ybWVkIGJ5IGFuIElj ZVdNIHVzZXIuIAorCQkgKiAgSW4gb3JkZXIgdG8gc2tpcCB0aGUgSWNlV00ncyBkb2NrLAorCQkg KiAgd2UgaXRlcmF0ZSB0aHJvdWdoIGFsbCAncmVhbCcgd2luZG93cyAKKwkJICogIGFuZCBvbmx5 IHByb2NlZWQgaWYgd2luIGlzIG9uIHRoZSBsaXN0LgorCQkgKi8KKworCQlXaW5kb3cgcndpbiwg cGFyZW50LCAqY2hpbGRyZW4sICpjaGlsZCwgYXBwOworCQlpbnQgbnVtOworCisJCVhRdWVyeVRy ZWUoZHB5LCByb290LCAmcndpbiwgJnBhcmVudCwgJmNoaWxkcmVuLCAmbnVtKTsKKwkJY2hpbGQg PSBjaGlsZHJlbjsKKwkJCisJCXdoaWxlIChudW0gLS0+IDApIHsKKwkJCWFwcCA9IE5vbmU7CisJ CQlHZXRBcHBXaW5kb3coKmNoaWxkLCAmYXBwKTsKKworCQkJaWYgKGFwcCA9PSB3aW4pIHsKKwkJ CQlBZGRXaW5kb3cod2luLCBldi5jb3JlLnhyZXBhcmVudC5wYXJlbnQpOworCQkJCWJyZWFrOwor CQkJfQorCQkJY2hpbGQrKzsKKwkJfTsKKwkKKwkJaWYgKGNoaWxkcmVuICE9IE5vbmUpCisJCQlY RnJlZShjaGlsZHJlbik7CisKKyAgICAgICAgICAvLyBBZGRXaW5kb3cod2luLCBldi5jb3JlLnhy ZXBhcmVudC5wYXJlbnQpOworCiAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgRGVzdHJv eU5vdGlmeToKICAgICAgICAgICBpZiAoZXYuY29yZS54ZGVzdHJveXdpbmRvdy5ldmVudCA9PSBy b290KSBicmVhazsK