1400 2002-10-12 18:22:37 +0400 mailbox locking does not work on reiserfs 2004-06-03 16:56:31 +0400 1 1 4 Development Sisyphus uw-imap unstable all Linux CLOSED FIXED P3 blocker --- 1 vsu imz lakostis oldest_to_newest 1320 0 vsu 2002-10-12 18:22:37 +0400 In uw-imap-2001a-alt6 (and probably in other versions) mailbox locking with fcntl() does not work if the mailbox file is on reiserfs - strace does not show any attempts to lock using fcntl(). However, fcntl() locking works on ext2 and ext3; I have not tried other filesystems - there may be more such problems. The problem was observed with kernel24-up-2.4.18-alt8, reiserfs 3.6. Seems that src/osdep/unix/nfstnew.c:test_nfs() considers that the mailbox is on a NFS filesystem, therefore fcntl() locking is turned off. This function tries to perform ustat() on the filesystem and checks usbuf.f_tinode; it happens that reiserfs returns -1 in this field. --- --- 4267 1 vanyaz 2002-10-15 21:50:47 +0400 According to my tests, locking works in uw-imap-2001a-alt6 on ext2, ext3, xfs, jfs and even vfat. Doesn\'t work on reiserfs-3.6. (reiserfs-3.5 test creshed, so no information yet.) 7632 2 vanyaz 2002-10-15 21:50:47 +0400 According to my tests, locking works in uw-imap-2001a-alt6 on ext2, ext3, xfs, jfs and even vfat. Doesn\'t work on reiserfs-3.6. (reiserfs-3.5 test creshed, so no information yet.) 4268 3 vanyaz 2002-10-15 21:52:10 +0400 The tests have been done on 2.4.19-alt0.2-up. 7633 4 vanyaz 2002-10-15 21:52:10 +0400 The tests have been done on 2.4.19-alt0.2-up. 4269 5 vanyaz 2002-10-15 22:23:16 +0400 I test the locking with help of the simple program (attached; it is very close to how imapd works): I set different kinds of locks and intermix this with accessing the box through imapd (trying to modify it). 7634 6 vanyaz 2002-10-15 22:23:16 +0400 I test the locking with help of the simple program (attached; it is very close to how imapd works): I set different kinds of locks and intermix this with accessing the box through imapd (trying to modify it). 4270 7 vanyaz 2002-10-15 23:55:08 +0400 no locking on reiserfs-3.5 as well (the crash I mentioned was probably caused by jfs). 7635 8 vanyaz 2002-10-15 23:55:08 +0400 no locking on reiserfs-3.5 as well (the crash I mentioned was probably caused by jfs). 4271 9 vanyaz 2002-11-02 01:28:48 +0300 waiting for the updates for released distros, then will mark it resolved. Already resolved in uw-imap-2001a-alt8 and pine-4.44L-alt4 in Sisyphus. 7636 10 vanyaz 2002-11-02 01:28:48 +0300 waiting for the updates for released distros, then will mark it resolved. Already resolved in uw-imap-2001a-alt8 and pine-4.44L-alt4 in Sisyphus. 5727 11 vsu 2003-08-25 14:25:44 +0400 Should this bug be closed? Master 2.2 contains the fixed version; update for Master 2.0 was not prepared... 14610 12 inger 2004-06-03 16:41:22 +0400 как я понял сейчас эта бага уже неактуальна. Нечего плодить в bugzilla закрытые блоки. Закрываю. 14617 13 vsu 2004-06-03 16:56:30 +0400 Да, это исправлено уже очень давно. 124 2002-10-15 22:20:48 +0400 2002-10-15 22:20:48 +0400 0001400-lock1-sim.c 0001400-lock1-sim.c application/octet-stream 5615 vsu I2luY2x1ZGUgPHN5cy9maWxlLmg+CiNpbmNsdWRlIDxlcnJuby5oPgojaW5jbHVkZSA8c3RkbGli Lmg+CiNpbmNsdWRlIDxzdGRpby5oPgojaW5jbHVkZSA8c3RyaW5nLmg+CiNpbmNsdWRlIDx1bmlz dGQuaD4KI2luY2x1ZGUgPHN5cy90eXBlcy5oPgoKLyoKICogUHJvZ3JhbToJZmxvY2sgZW11bGF0 aW9uIHZpYSBmY250bCgpIGxvY2tpbmcKICoKICogQXV0aG9yOglNYXJrIENyaXNwaW4KICoJCU5l dHdvcmtzIGFuZCBEaXN0cmlidXRlZCBDb21wdXRpbmcKICoJCUNvbXB1dGluZyAmIENvbW11bmlj YXRpb25zCiAqCQlVbml2ZXJzaXR5IG9mIFdhc2hpbmd0b24KICoJCUFkbWluaXN0cmF0aW9uIEJ1 aWxkaW5nLCBBRy00NAogKgkJU2VhdHRsZSwgV0EgIDk4MTk1CiAqCQlJbnRlcm5ldDogTVJDQENB Qy5XYXNoaW5ndG9uLkVEVQogKgogKiBEYXRlOgkxMCBBcHJpbCAyMDAxCiAqIExhc3QgRWRpdGVk Ogk2IE5vdmVtYmVyIDIwMDEKICogCiAqIFRoZSBJTUFQIHRvb2xraXQgcHJvdmlkZWQgaW4gdGhp cyBEaXN0cmlidXRpb24gaXMKICogQ29weXJpZ2h0IDIwMDEgVW5pdmVyc2l0eSBvZiBXYXNoaW5n dG9uLgogKiBUaGUgZnVsbCB0ZXh0IG9mIG91ciBsZWdhbCBub3RpY2VzIGlzIGNvbnRhaW5lZCBp biB0aGUgZmlsZSBjYWxsZWQKICogQ1BZUklHSFQsIGluY2x1ZGVkIHdpdGggdGhpcyBEaXN0cmli dXRpb24uCiAqLwogCiN1bmRlZiBmbG9jawkJCS8qIG5hbWUgaXMgdXNlZCBhcyBhIHN0cnVjdCBm b3IgZmNudGwgKi8KI3VuZGVmIGZvcmsJCQkvKiBtYWtlIGRhbW4gc3VyZSB0aGF0IHdlIGRvbid0 IHVzZSB2Zm9yayEhICovCgojaWZuZGVmIE5TSUcJCQkvKiBkb24ndCBrbm93IGlmIHRoaXMgY2Fu IGhhcHBlbiAqLwojZGVmaW5lIE5TSUcgMzIJCQkvKiBhIGNvbW1vbiBtYXhpbXVtICovCiNlbmRp ZgoMCi8qIEVtdWxhdG9yIGZvciBmbG9jaygpIGNhbGwKICogQWNjZXB0czogZmlsZSBkZXNjcmlw dG9yCiAqCSAgICBvcGVyYXRpb24gYml0bWFzawogKiBSZXR1cm5zOiAwIGlmIHN1Y2Nlc3NmdWws IC0xIGlmIGZhaWx1cmUgdW5kZXIgQlNEIGNvbmRpdGlvbnMKICovCgoKaW50IGZsb2Nrc2ltIChp bnQgZmQsaW50IG9wKQp7CiAgc3RydWN0IGZsb2NrIGZsOwoJCQkJLyogbG9jayBhcHBsaWVzIHRv IGVudGlyZSBmaWxlICovCiAgZmwubF93aGVuY2UgPSBmbC5sX3N0YXJ0ID0gZmwubF9sZW4gPSAw OwogIC8vZmwubF9waWQgPSBnZXRwaWQgKCk7CQkvKiBzaG91bGRuJ3QgYmUgbmVjZXNzYXJ5ICov CiAgc3dpdGNoIChvcCAmIH5MT0NLX05CKSB7CS8qIHRyYW5zbGF0ZSB0byBmY250bCgpIG9wZXJh dGlvbiAqLwogIGNhc2UgTE9DS19FWDoJCQkvKiBleGNsdXNpdmUgKi8KICAgIGZsLmxfdHlwZSA9 IEZfV1JMQ0s7CiAgICBicmVhazsKICBjYXNlIExPQ0tfU0g6CQkJLyogc2hhcmVkICovCiAgICBm bC5sX3R5cGUgPSBGX1JETENLOwogICAgYnJlYWs7CiAgY2FzZSBMT0NLX1VOOgkJCS8qIHVubG9j ayAqLwogICAgZmwubF90eXBlID0gRl9VTkxDSzsKICAgIGJyZWFrOwogIGRlZmF1bHQ6CQkJLyog ZGVmYXVsdCAqLwogICAgZXJybm8gPSBFSU5WQUw7CiAgICByZXR1cm4gLTE7CiAgfQoKCQkJCS8q IGRvIHRoZSBsb2NrICovCiAgd2hpbGUgKGZjbnRsIChmZCwob3AgJiBMT0NLX05CKSA/IEZfU0VU TEsgOiBGX1NFVExLVywmZmwpKQogICAgaWYgKGVycm5vICE9IEVJTlRSKSB7CiAgICAgIC8qIENh bid0IHVzZSBzd2l0Y2ggaGVyZSBiZWNhdXNlIHRoZXNlIGVycm9yIGNvZGVzIG1heSByZXNvbHZl IHRvIHRoZQogICAgICAgKiBzYW1lIHZhbHVlIG9uIHNvbWUgc3lzdGVtcy4KICAgICAgICovCiAg ICAgIGlmICgoZXJybm8gIT0gRVdPVUxEQkxPQ0spICYmIChlcnJubyAhPSBFQUdBSU4pICYmIChl cnJubyAhPSBFQUNDRVMpKSB7CglmcHJpbnRmIChzdGRlcnIsIlVuZXhwZWN0ZWQgZmlsZSBsb2Nr aW5nIGZhaWx1cmU6ICVzIixzdHJlcnJvciAoZXJybm8pKTsKCQkJCS8qIGdpdmUgdGhlIHVzZXIg YSB3YXJuaW5nIG9mIHdoYXQgaGFwcGVuZWQgKi8KCWlmIChvcCAmIExPQ0tfTkIpIHJldHVybiAt MTsKCXNsZWVwICg1KTsJCS8qIHNsb3cgdGhpbmdzIGRvd24gZm9yIGxvb3BzICovCiAgICAgIH0K CQkJCS8qIHJldHVybiBmYWlsdXJlIGZvciBub24tYmxvY2tpbmcgbG9jayAqLwogICAgICBlbHNl IGlmIChvcCAmIExPQ0tfTkIpIHJldHVybiAtMTsKICAgIH0KICByZXR1cm4gMDsJCQkvKiBzdWNj ZXNzICovCn0KCiNkZWZpbmUgZmxvY2sgZmxvY2tzaW0KCi8qICAgICAgTWljaGFlbCBKYW5zZW4s IE9jdC4sMTk5MC4KICoKICoJSGVyZSBpcyBhIGxpdHRsZSBpbnRlcmx1ZGUgZm9yIHRlc3Rpbmcg b2YgdGhlIEJTRCBmaWxlCiAqCWxvY2tpbmcgc3lzdGVtIGNhbGwgZmxvY2soKS4KICoKICoJRmls ZSBsb2NrcyB1c2luZyBmbG9jaygpIGxvY2sgdGhlIHdob2xlIGZpbGUgaW4gc2hhcmVkCiAqCWV4 Y2x1c2l2ZSBtb2RlLiAgU2hhcmVkIGxvY2tzIHNob3VsZCBiZSB1c2VmdWwgd2hlbgogKgl0aGVy ZSBhcmUgbWFueSByZWFkZXJzLiAgRXhjbHVzaXZlIGxvY2tzIGhhbmRsZSB0aGUKICoJd3JpdGVy cy4KICoJCiAqCU1hbGNvbG0gQ29vaywgT2N0LiwgMTk5MC4KICoKICoJTW9kaWZpY2F0aW9uczoK ICoJCS0gdW5sb2NrIHByaW9yIHRvIGNhbGxpbmcgZm9yIGEgbG9jayB0byBnZXQgYXJvdW5kIGRv ZGd5CiAqCQkgIGltcGxlbWVudGF0aW9uIG9mIGZsb2NrKCkgd2hpY2ggY2F1c2VzIGEgZnJlZXpl IGlmICdleCcKICoJCSAgYW5kICdzaCcgY2FsbGVkIGluIHN1Y2Nlc3Npb24KICoJCS0gcmVtb3Zl IExPQ0tfTkIgZmxhZyB0byBzdXNwZW5kIHByb2Nlc3NlcyB3YWl0aW5nIGZvciBhIGxvY2sKICoJ CS0gYXBwZW5kIGxvY2sgcmVxdWVzdCBhbmQgcGlkIHRvIGZpbGUgdG8gY3JlYXRlIGEgaGlzdG9y eSBvZgogKgkJICByZXF1ZXN0cy4gTm90ZSB0aGF0IGdhaW5pbmcgYSBsb2NrIGRvZXMgbm90IHBy ZXZlbnQgb3RoZXIKICoJCSAgcHJvY2Vzc2VzIGZyb20gcmVhZGluZy93cml0aW5nIHRvIHRoZSBm aWxlLCBqdXN0IGZyb20gZ2FpbmluZwogKgkJICB0aGUgbG9jay4KICoKICoJQXByLiwgMTk5NC4K ICoKICoJCS0gYWJvdmUgcHJvYmxlbSB3aXRoIGZyZWV6aW5nIGRvZXNuJ3QgYXBwbHkgdG8gVUxU UklYLCBoZW5jZQogKgkJICBpbml0aWFsIHVubG9ja2luZyBjb21tZW50ZWQgb3V0LiBUaGlzIHdh c24ndCBhbiBlbnRpcmVseQogKgkJICBzYXRpc2ZhY3Rvcnkgd29ya2Fyb3VuZCBhbnl3YXksIHNp bmNlIGEgcHJvY2VzcyBjb3VsZCBsb3NlCiAqCQkgIGl0cyBsb2NrIHdoaWxzdCB0cnlpbmcgdG8g ZG93bmdyYWRlIGZyb20gJ2V4JyB0byAnc2gnLgogKi8KCiNpbmNsdWRlIDxzeXMvZmlsZS5oPgoj aW5jbHVkZSA8c3RkaW8uaD4KCiNkZWZpbmUJVFJVRQkxCiNkZWZpbmUJRkFMU0UJMAoKaW50IG1h aW4gKCkKewoJY2hhcgkJY29tbWFuZCBbODBdOwoJY2hhcgkJdG9rZW4xIFs4MF0sIHRva2VuMiBb ODBdOwoJY2hhcgkJZmlsZU5hbWUgWzgwXTsKCWludAkJc2hvd0luc3RydWN0aW9ucwk9IFRSVUU7 CglpbnQJCWZkID0gLTE7CglpbnQJCXBpZDsKCglwaWQgPSBnZXRwaWQoKTsKCglmb3IgKDs7KQoJ ewoJCWlmIChzaG93SW5zdHJ1Y3Rpb25zKQoJCXsKCQkJcHJpbnRmICgiVXNlICduYW1lIGZpbGVO YW1lJyB0byBzcGVjaWZ5IHRoZSBmaWxlIHRvIG9wZXJhdGUgb24sXG5cCgknZXgnIGZvciBhbiBl eGNsdXNpdmUgbG9jayxcblwKCSdzaCcgZm9yIGEgc2hhcmVkIGxvY2suXG5cCgkndW4nIHRvIHVu bG9ja1xuXAoJJ3EnICB0byBxdWl0XG4iCgkJCSk7CgoJCQlzaG93SW5zdHJ1Y3Rpb25zID0gRkFM U0U7CgkJfQoKCQlwcmludGYgKCJDb21tYW5kPyAiKTsKCgkJaWYgKGZnZXRzIChjb21tYW5kLCBz aXplb2YgKGNvbW1hbmQpLCBzdGRpbikgPT0gMCkgYnJlYWs7CgkJc3NjYW5mIChjb21tYW5kLCAi JXMlcyIsIHRva2VuMSwgdG9rZW4yKTsKCgkJaWYgKHN0cmNtcCAodG9rZW4xLCAibmFtZSIpID09 IDApCgkJewoJCQlpZiAoZmQgIT0gLTEpCgkJCQljbG9zZSAoZmQpOwoJCQlzdHJjcHkgKGZpbGVO YW1lLCB0b2tlbjIpOwoJCQlpZiAoKGZkID0gb3BlbiAoZmlsZU5hbWUsIE9fUkRXUiB8IE9fQ1JF QVQgfCBPX0FQUEVORCwgMDc3NykpID09IC0xKQoJCQl7CgkJCQlwcmludGYgKCIlczogY2Fubm90 IG9wZW4gb3IgY3JlYXRlXG4iLCBmaWxlTmFtZSk7CgkJCQlwZXJyb3IoInN5cyIpOwoJCQkJZmls ZU5hbWUgWzBdID0gMDsKCQkJfQoJCX0KCQllbHNlIGlmIChzdHJjbXAgKHRva2VuMSwgImV4Iikg PT0gMCkKCQl7CgkJCWlmIChmZCA9PSAtMSkKCQkJewoJCQkJcHJpbnRmICgieW91IGhhdmUgbm8g ZmlsZSBvcGVuXG4iKTsKCQkJCXNob3dJbnN0cnVjdGlvbnMgPSBUUlVFOwoJCQl9CgkJCWVsc2UK CQkJewoJCQkJLypmbG9jayhmZCwgTE9DS19VTik7Ki8KCQkJCWlmIChmbG9jayAoZmQsIExPQ0tf RVggLyp8IExPQ0tfTkIqLykgIT0gMCkKCQkJCQlwZXJyb3IgKCJmbG9jayBleCIpOwoJCQkJZWxz ZQoJCQkJewovKiAJCQkJCWZwcmludGYoc3RyLCIlZCBleFxuIixwaWQpOyAqLwovKiAJCQkJCWZm bHVzaChzdHIpOyAqLwoJCQkJfQoJCQl9CgkJfQoJCWVsc2UgaWYgKHN0cmNtcCAodG9rZW4xLCAi c2giKSA9PSAwKQoJCXsKCQkJaWYgKGZkID09IC0xKQoJCQl7CgkJCQlwcmludGYgKCJ5b3UgaGF2 ZSBubyBmaWxlIG9wZW5cbiIpOwoJCQkJc2hvd0luc3RydWN0aW9ucyA9IFRSVUU7CgkJCX0KCQkJ ZWxzZQoJCQl7CgkJCQkvKmZsb2NrKGZkLCBMT0NLX1VOKTsqLwoJCQkJaWYgKGZsb2NrIChmZCwg TE9DS19TSCAvKnwgTE9DS19OQiovKSAhPSAwKQoJCQkJCXBlcnJvciAoImZsb2NrIHNoIik7CgkJ CQllbHNlCgkJCQl7Ci8qIAkJCQkJZnByaW50ZihzdHIsIiVkIHNoXG4iLHBpZCk7ICovCi8qIAkJ CQkJZmZsdXNoKHN0cik7ICovCgkJCQl9CgkJCX0KCQl9CgkJZWxzZSBpZiAoc3RyY21wICh0b2tl bjEsICJ1biIpID09IDApCgkJewoJCQlpZiAoZmQgPT0gLTEpCgkJCXsKCQkJCXByaW50ZiAoInlv dSBoYXZlIG5vIGZpbGUgb3BlblxuIik7CgkJCQlzaG93SW5zdHJ1Y3Rpb25zID0gVFJVRTsKCQkJ fQoJCQllbHNlCgkJCXsKCQkJCS8qIHdyaXRlICd1bicgYmVmb3JlIHVubG9ja2luZyB0byByZWZs ZWN0IHRydWUgCgkJCQkgICBzZXF1ZW5jZSBvZiBldmVudHMgaW4gdW5sb2NrLWxvY2sgc2VxdWVu Y2UKCQkJCSovCi8qIAkJCQlmcHJpbnRmKHN0ciwiJWQgdW5cbiIscGlkKTsgKi8KLyogCQkJCWZm bHVzaChzdHIpOyAqLwoJCQkJaWYgKGZsb2NrIChmZCwgTE9DS19VTikgIT0gMCkKCQkJCQlwZXJy b3IgKCJmbG9jayB1biIpOwoJCQl9CgkJfQoJCWVsc2UgaWYgKHN0cmNtcCAodG9rZW4xLCAicSIp ID09IDApCgkJewoJCQlicmVhazsKCQl9CgkJZWxzZQoJCXsKCQkJcHJpbnRmICgiJXM6IGNhbm5v dCB1bmRlcnN0YW5kIGNvbW1hbmRcbiIsIHRva2VuMSk7CgkJCXByaW50ZiAoIlBsZWFzZSByZWNv bnNpZGVyLlxuXG4iKTsKCQkJc2hvd0luc3RydWN0aW9ucyA9IFRSVUU7CgkJfQoJfQoKCXJldHVy biAwOwp9CgovKgogKiBMb2NhbCBWYXJpYWJsZXM6CiAqIGNvbXBpbGUtY29tbWFuZDogImNjIC1X YWxsIGxvY2sxLXNpbS5jIgogKiBFbmQ6CiAqLwo=