24841 2010-12-29 23:47:28 +0300 "split" sets wrong restrictions for suffix length 2010-12-31 02:05:56 +0300 1 1 4 Development Sisyphus coreutils unstable all Linux CLOSED FIXED http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7759 P3 major --- 1 vsu placeholder glebfm ldv mike placeholder vt qa-sisyphus oldest_to_newest 116779 0 vsu 2010-12-29 23:47:28 +0300 coreutils-8.8-alt1 $ split -b 1024 -a 2 split: the suffix length needs to be at least 3 $ split -b 1G -a 2 split: the suffix length needs to be at least 7 Without the explicit "-a 2" option the suffix length is set to some value depending on the "-b" option value. This behavior is obviously wrong (the suffix length should not depend on the block size) and violates POSIX (which specifies that the default suffix length is 2). Looks like the block size is handled as the number of blocks somewhere. 116781 1 ldv 2010-12-30 00:12:33 +0300 Regression due to commit v8.7-25-gbe10739. 116785 2 ldv 2010-12-30 03:20:29 +0300 $ yes y | head -n340 | split -b 1 split: output file suffixes exhausted $ split -a 2 -b 1E < /dev/null split: the suffix length needs to be at least 13 Very nice bug indeed. 116792 3 4727 P 2010-12-30 13:40:37 +0300 Created attachment 4727 proposed fix 116796 4 ldv 2010-12-30 20:19:21 +0300 (In reply to comment #3) > Created an attachment (id=4727) [details] > proposed fix v8.8-7-g44dbcae works correct, thanks. 116797 5 repository-robot 2010-12-30 20:33:04 +0300 coreutils-8.8-alt2 -> sisyphus: * Thu Dec 30 2010 Dmitry V. Levin <ldv@altlinux> 8.8-alt2 - Updated coreutils to v8.8-7-g44dbcae (closes: #24841). 4727 2010-12-30 13:40:37 +0300 2010-12-30 13:40:37 +0300 proposed fix split-suffix.diff text/plain 3526 P RnJvbSBlYzE5ZTJhNjQ3Y2I2NGQ0YTU2MjA3ODdkNGVjZjU5NjRkODVmY2Y2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/PSA8UEBk cmFpZ0JyYWR5LmNvbT4KRGF0ZTogVGh1LCAzMCBEZWMgMjAxMCAwMTozNjo1OSArMDAwMApTdWJq ZWN0OiBbUEFUQ0hdIHNwbGl0OiBmaXggdGhlIHN1ZmZpeCBsZW5ndGggY2FsY3VsYXRpb24KCiog c3JjL3NwbGl0LmMgKHNldF9zdWZmaXhfbGVuZ3RoKTogT25seSBhdXRvIGNhbGN1bGF0ZQp0aGUg c3VmZml4IGxlbmd0aCB3aGVuIHRoZSBudW1iZXIgb2YgZmlsZXMgaXMgc3BlY2lmaWVkLgoqIHRl c3RzL21pc2Mvc3BsaXQtYTogQWRkIGEgY2FzZSB0byB0cmlnZ2VyIHRoZSBidWcuCiogTkVXUzog TWVudGlvbiB0aGUgZml4LgotLS0KIE5FV1MgICAgICAgICAgICAgICB8ICAgIDYgKysrKysrCiBz cmMvc3BsaXQuYyAgICAgICAgfCAgIDMyICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t CiB0ZXN0cy9taXNjL3NwbGl0LWEgfCAgICA1ICsrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDMxIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL05FV1MgYi9ORVdTCmlu ZGV4IDQwMWIyZjUuLjg4NTk2YjUgMTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIvTkVXUwpAQCAtMiw2 ICsyLDEyIEBAIEdOVSBjb3JldXRpbHMgTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIC0qLSBvdXRsaW5lIC0qLQogCiAqIE5vdGV3b3J0aHkgY2hhbmdlcyBpbiByZWxlYXNl ID8uPyAoPz8/Py0/Py0/PykgWz9dCiAKKyoqIEJ1ZyBmaXhlcworCisgIHNwbGl0IG5vIGxvbmdl ciBjcmVhdGVzIGZpbGVzIHdpdGggYSBzdWZmaXggbGVuZ3RoIHRoYXQKKyAgaXMgZGVwZW5kZW50 IG9uIHRoZSBudW1iZXIgb2YgYnl0ZXMgb3IgbGluZXMgcGVyIGZpbGUuCisgIFtidWcgaW50cm9k dWNlZCBpbiBjb3JldXRpbHMtOC44XQorCiAKICogTm90ZXdvcnRoeSBjaGFuZ2VzIGluIHJlbGVh c2UgOC44ICgyMDEwLTEyLTIyKSBbc3RhYmxlXQogCmRpZmYgLS1naXQgYS9zcmMvc3BsaXQuYyBi L3NyYy9zcGxpdC5jCmluZGV4IGFlOThiYzcuLjllOWVmYmYgMTAwNjQ0Ci0tLSBhL3NyYy9zcGxp dC5jCisrKyBiL3NyYy9zcGxpdC5jCkBAIC03OCw2ICs3OCwxMyBAQCBzdGF0aWMgYm9vbCBlbGlk ZV9lbXB0eV9maWxlczsKICAgIGlucHV0IHRvIG91dHB1dCwgd2hpY2ggaXMgbXVjaCBzbG93ZXIs IHNvIGRpc2FibGVkIGJ5IGRlZmF1bHQuICAqLwogc3RhdGljIGJvb2wgdW5idWZmZXJlZDsKIAor LyogVGhlIHNwbGl0IG1vZGUgdG8gdXNlLiAgKi8KK2VudW0gU3BsaXRfdHlwZQoreworICB0eXBl X3VuZGVmLCB0eXBlX2J5dGVzLCB0eXBlX2J5dGVzbGluZXMsIHR5cGVfbGluZXMsIHR5cGVfZGln aXRzLAorICB0eXBlX2NodW5rX2J5dGVzLCB0eXBlX2NodW5rX2xpbmVzLCB0eXBlX3JyCit9Owor CiAvKiBGb3IgbG9uZyBvcHRpb25zIHRoYXQgaGF2ZSBubyBlcXVpdmFsZW50IHNob3J0IG9wdGlv biwgdXNlIGEKICAgIG5vbi1jaGFyYWN0ZXIgYXMgYSBwc2V1ZG8gc2hvcnQgb3B0aW9uLCBzdGFy dGluZyB3aXRoIENIQVJfTUFYICsgMS4gICovCiBlbnVtCkBAIC0xMDUsMTYgKzExMiwyMSBAQCBz dGF0aWMgc3RydWN0IG9wdGlvbiBjb25zdCBsb25nb3B0c1tdID0KIH07CiAKIHN0YXRpYyB2b2lk Ci1zZXRfc3VmZml4X2xlbmd0aCAodWludG1heF90IG5fdW5pdHMpCitzZXRfc3VmZml4X2xlbmd0 aCAodWludG1heF90IG5fdW5pdHMsIGVudW0gU3BsaXRfdHlwZSBzcGxpdF90eXBlKQogewogI2Rl ZmluZSBERUZBVUxUX1NVRkZJWF9MRU5HVEggMgogCiAgIHNpemVfdCBzdWZmaXhfbmVlZGVkID0g MDsKLSAgc2l6ZV90IGFscGhhYmV0X2xlbiA9IHN0cmxlbiAoc3VmZml4X2FscGhhYmV0KTsKLSAg Ym9vbCBhbHBoYWJldF9zbG9wID0gKG5fdW5pdHMgJSBhbHBoYWJldF9sZW4pICE9IDA7Ci0gIHdo aWxlIChuX3VuaXRzIC89IGFscGhhYmV0X2xlbikKLSAgICBzdWZmaXhfbmVlZGVkKys7Ci0gIHN1 ZmZpeF9uZWVkZWQgKz0gYWxwaGFiZXRfc2xvcDsKKworICBpZiAoc3BsaXRfdHlwZSA9PSB0eXBl X2NodW5rX2J5dGVzIHx8IHNwbGl0X3R5cGUgPT0gdHlwZV9jaHVua19saW5lcworICAgICAgfHwg c3BsaXRfdHlwZSA9PSB0eXBlX3JyKQorICAgIHsKKyAgICAgIHNpemVfdCBhbHBoYWJldF9sZW4g PSBzdHJsZW4gKHN1ZmZpeF9hbHBoYWJldCk7CisgICAgICBib29sIGFscGhhYmV0X3Nsb3AgPSAo bl91bml0cyAlIGFscGhhYmV0X2xlbikgIT0gMDsKKyAgICAgIHdoaWxlIChuX3VuaXRzIC89IGFs cGhhYmV0X2xlbikKKyAgICAgICAgc3VmZml4X25lZWRlZCsrOworICAgICAgc3VmZml4X25lZWRl ZCArPSBhbHBoYWJldF9zbG9wOworICAgIH0KIAogICBpZiAoc3VmZml4X2xlbmd0aCkgICAgICAg ICAgICAvKiBzZXQgYnkgdXNlciAqLwogICAgIHsKQEAgLTc4MCwxMSArNzkyLDcgQEAgaW50CiBt YWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiB7CiAgIHN0cnVjdCBzdGF0IHN0YXRfYnVmOwot ICBlbnVtCi0gICAgewotICAgICAgdHlwZV91bmRlZiwgdHlwZV9ieXRlcywgdHlwZV9ieXRlc2xp bmVzLCB0eXBlX2xpbmVzLCB0eXBlX2RpZ2l0cywKLSAgICAgIHR5cGVfY2h1bmtfYnl0ZXMsIHR5 cGVfY2h1bmtfbGluZXMsIHR5cGVfcnIKLSAgICB9IHNwbGl0X3R5cGUgPSB0eXBlX3VuZGVmOwor ICBlbnVtIFNwbGl0X3R5cGUgc3BsaXRfdHlwZSA9IHR5cGVfdW5kZWY7CiAgIHNpemVfdCBpbl9i bGtfc2l6ZSA9IDA7CS8qIG9wdGltYWwgYmxvY2sgc2l6ZSBvZiBpbnB1dCBmaWxlIGRldmljZSAq LwogICBjaGFyICpidWY7CQkJLyogZmlsZSBpL28gYnVmZmVyICovCiAgIHNpemVfdCBwYWdlX3Np emUgPSBnZXRwYWdlc2l6ZSAoKTsKQEAgLTk4NCw3ICs5OTIsNyBAQCBtYWluIChpbnQgYXJnYywg Y2hhciAqKmFyZ3YpCiAgICAgICB1c2FnZSAoRVhJVF9GQUlMVVJFKTsKICAgICB9CiAKLSAgc2V0 X3N1ZmZpeF9sZW5ndGggKG5fdW5pdHMpOworICBzZXRfc3VmZml4X2xlbmd0aCAobl91bml0cywg c3BsaXRfdHlwZSk7CiAKICAgLyogR2V0IG91dCB0aGUgZmlsZW5hbWUgYXJndW1lbnRzLiAgKi8K IApkaWZmIC0tZ2l0IGEvdGVzdHMvbWlzYy9zcGxpdC1hIGIvdGVzdHMvbWlzYy9zcGxpdC1hCmlu ZGV4IGQ4NjFiOTIuLmIwNTI2YmMgMTAwNzU1Ci0tLSBhL3Rlc3RzL21pc2Mvc3BsaXQtYQorKysg Yi90ZXN0cy9taXNjL3NwbGl0LWEKQEAgLTYzLDQgKzYzLDkgQEAgZm9yIGYgaW4gJGZpbGVzOyBk bwogICBuPSQoZXhwciAkbiArIDEpCiBkb25lCiAKKyMgRW5zdXJlIHRoYXQgLWEgaXMgaW5kZXBl bmRlbnQgb2YgLVtiQ2xdCitzcGxpdCAtYTIgLWIxMDAwIDwgL2Rldi9udWxsIHx8IGZhaWw9MQor c3BsaXQgLWEyIC1sMTAwMCA8IC9kZXYvbnVsbCB8fCBmYWlsPTEKK3NwbGl0IC1hMiAtQzEwMDAg PCAvZGV2L251bGwgfHwgZmFpbD0xCisKIEV4aXQgJGZhaWwKLS0gCjEuNy4zLjQKCg==