28136 2012-11-27 19:04:43 +0400 [PATCH] add EVMS specific devmapper name mangling to whitelist 2012-12-06 14:58:30 +0400 1 1 4 Development Sisyphus libdevmapper unstable all Linux CLOSED NOTABUG P3 normal --- 28020 1 mike mike aen rider shaba timonbl4 vitty qa-sisyphus oldest_to_newest 135502 0 5656 mike 2012-11-27 19:04:43 +0400 Created attachment 5656 a quick&dirty patch to allow '|' in devmapper device node names This patch extends _is_whitelisted_char() with an EVMS specific "|" since e.g. lvm2 plugin would result in node names like "/dev/mapper/lvm2|$vg|$lv" and libdevmapper wouldn't let these through complaining that, e.g., > The name "lvm2|main|root" should be mangled but it contains blacklisted characters. It was proposed upstream on the official #device-mapper freenode channel, so far found debatable due to the potential security implications of the pipe character in faulty scripts given the possibility of coercing an unsuspecting [EVMS] user to insert a rogue usbflash but otherwise not turned down unequivocally; will submit to an upstream ML as suggested by asalor. I can prepare a proper NMU with this patch in alt/ if you don't mind; in the mean time will work with upstream to get it there as a legacy compatibility option. 135545 1 mike 2012-11-28 16:09:41 +0400 https://www.redhat.com/archives/dm-devel/2012-November/msg00044.html 135660 2 aen 2012-12-02 10:30:31 +0400 А у нас-то чего его не приложить, если нужен? 135667 3 mike 2012-12-02 22:27:54 +0400 Потому и повесил на себя, но не закрываю, что ещё в процессе выяснения. Если с деактивацией EVMS получится, так и не нужен. 135765 4 mike 2012-12-04 22:05:21 +0400 См. bug #28181. 5656 2012-11-27 19:04:43 +0400 2012-11-27 19:04:43 +0400 a quick&dirty patch to allow '|' in devmapper device node names 0001-libdm-add-to-_is_whitelisted_char.patch text/plain 1398 mike RnJvbSA2YzM2NzY3YWNmYmM2ZjcyYWQ3ZmZlZDI5ODIwMDA4OGI5YmIxMjNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWdvcmluIDxtaWtlQGFsdGxpbnV4Lm9yZz4K RGF0ZTogRnJpLCAyMyBOb3YgMjAxMiAxNzoyMTozMyArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8y XSBsaWJkbTogYWRkICJ8IiB0byBfaXNfd2hpdGVsaXN0ZWRfY2hhcigpCgpUaGUgaXNzdWUgaXMg dGhhdCBFVk1TJyBsdm0yIHBsdWdpbiB3b3VsZCB5aWVsZCBuYW1lcyBsaWtlCiIvZGV2L21hcHBl ci9sdm0yfHZnfGx2IiBhbmQgdGhlIGN1cnJlbnQgbGliZGV2bWFwcGVyIHdpbGwKdHVybiB0aGVz ZSBkb3duOyB0aGlzIG1ha2VzIG1pZ3JhdGluZyBsZWdhY3kgZW52aXJvbm1lbnRzCmludm9sdmlu ZyBkZXZtYXBwZXItYXdhcmUgdG9vbHMgaW4gdGhlIHRhcmdldCBjb25maWd1cmF0aW9uCmEgc29t ZXdoYXQgaGFyZGVyIHRhc2sgdGhhbiBpdCBtaWdodCBiZS4KClRoZXJlJ3MgYSBwb3RlbnRpYWwg c2VjdXJpdHkgY29uc2lkZXJhdGlvbiB3aXRoIGFueSBmYXVsdHkKc2NyaXB0cyB3aGljaCB3b3Vs ZG4ndCBnZXQgZGV2aWNlIG5hbWVzIHF1b3RlZCBhcyBub3RlZCBieQphc2Fsb3Igb24gI2Rldmlj ZS1tYXBwZXI7IHRoaXMgaXMgcmF0aGVyIG1pdGlnYXRlZCBieSB0aGUKZmFjdCB0aGF0IG9uZSBu ZWVkcyB0byBoYXZlIEVWTVMgYWN0aXZhdGVkIGZvciB0aGUgZGV2aWNlcwppbiBxdWVzdGlvbiwg ZXZlbiBpZiB0aGVzZSBhcmUgVVNCIGZsYXNoIG9uZXMuICBTcGVha2luZyBvZgpzdWNoIHNjcmlw dHMsIHRoZXNlIGFyZSBwcm9uZSB0byBtaXNiZWhhdmUgdXBvbiAiPSIgZWl0aGVyLgotLS0KIGxp YmRtL2xpYmRtLWNvbW1vbi5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGliZG0vbGliZG0tY29tbW9uLmMgYi9saWJk bS9saWJkbS1jb21tb24uYwppbmRleCBhZmRhYzg5Li5lNzE1NjI5IDEwMDY0NAotLS0gYS9saWJk bS9saWJkbS1jb21tb24uYworKysgYi9saWJkbS9saWJkbS1jb21tb24uYwpAQCAtMzIwLDcgKzMy MCw3IEBAIHN0YXRpYyBpbnQgX2lzX3doaXRlbGlzdGVkX2NoYXIoY2hhciBjKQogICAgICAgICBp ZiAoKGMgPj0gJzAnICYmIGMgPD0gJzknKSB8fAogICAgICAgICAgICAgKGMgPj0gJ0EnICYmIGMg PD0gJ1onKSB8fAogICAgICAgICAgICAgKGMgPj0gJ2EnICYmIGMgPD0gJ3onKSB8fAotICAgICAg ICAgICAgc3RyY2hyKCIjKy0uOj1AXyIsIGMpICE9IE5VTEwpCisgICAgICAgICAgICBzdHJjaHIo IiMrLS46PUBffCIsIGMpICE9IE5VTEwpCiAgICAgICAgICAgICAgICAgcmV0dXJuIDE7CiAKICAg ICAgICAgcmV0dXJuIDA7Ci0tIAoxLjcuMTIuNAoK