<?xml version="1.0" encoding="UTF-8" ?>

<bugzilla version="5.2"
          urlbase="https://bugzilla.altlinux.org/"
          
          maintainer="jenya@basealt.ru"
>

    <bug>
          <bug_id>29511</bug_id>
          
          <creation_ts>2013-10-22 23:58:08 +0400</creation_ts>
          <short_desc>crash in ffmpeg metadata handler</short_desc>
          <delta_ts>2013-10-24 14:46:23 +0400</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Development</classification>
          <product>Sisyphus</product>
          <component>mediatomb</component>
          <version>unstable</version>
          <rep_platform>all</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://bugs.gentoo.org/attachment.cgi?id=333734&amp;action=diff</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>relnote</keywords>
          <priority>P3</priority>
          <bug_severity>critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Konstantin A Lepikhov (L.A. Kostis)">lakostis</reporter>
          <assigned_to name="Sergey Bolshakov">sbolshakov</assigned_to>
          
          
          <qa_contact>qa-sisyphus</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>143391</commentid>
    <comment_count>0</comment_count>
      <attachid>5977</attachid>
    <who name="Konstantin A Lepikhov (L.A. Kostis)">lakostis</who>
    <bug_when>2013-10-22 23:58:08 +0400</bug_when>
    <thetext>Created attachment 5977
Fix from upstream

Reproducible: Always

Steps to Reproduce:
1.Update to latest version from Sisyphus
2.Start the daemon
3.wait a couple of seconds for segfault (or if no DB, go to the web interface and add some files, then wait for segfault)
Actual Results:  
Segfault with the following in syslog:

kernel: mediatomb[10301]: segfault at 25 ip b724bab7 sp b12d0af0 error 4 in libavformat.so.53.32.100[b71a1000+d3000]

It seems that initializing the pointer does the trick:

--- a/src/metadata/ffmpeg_handler.cc
+++ b/src/metadata/ffmpeg_handler.cc
@@ -259,7 +259,7 @@ void FfmpegHandler::fillMetadata(Ref&lt;CdsItem&gt; item)
     int x = 0;
     int y = 0;
 
-       AVFormatContext *pFormatCtx;
+       AVFormatContext *pFormatCtx = NULL;
 
        // Suppress all log messages
        av_log_set_callback(FfmpegNoOutputStub);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>143416</commentid>
    <comment_count>1</comment_count>
    <who name="Repository Robot">repository-robot</who>
    <bug_when>2013-10-24 14:46:23 +0400</bug_when>
    <thetext>mediatomb-0.12.1-alt11 -&gt; sisyphus:

* Thu Oct 24 2013 Sergey Bolshakov &lt;sbolshakov@altlinux&gt; 0.12.1-alt11
- fixed segfault in metadata scanner (closes: #29511)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>5977</attachid>
            <date>2013-10-22 23:58:08 +0400</date>
            <delta_ts>2013-10-22 23:58:08 +0400</delta_ts>
            <desc>Fix from upstream</desc>
            <filename>Fix-crash-in-ffmpeg-metadata-handler.patch</filename>
            <type>text/plain</type>
            <size>876</size>
            <attacher name="Konstantin A Lepikhov (L.A. Kostis)">lakostis</attacher>
            
              <data encoding="base64">RnJvbSA3ODVkZTVlOGU4OTUwY2E3ZjcxMTcxNDRlNWI4ODU2ZWY3ODA4ZjQ1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnZXkgJ0ppbicgQm9zdGFuZHpoeWFuIDxqaW4gYXQgbWVk
aWF0b21iIGRvdCBjYz4KRGF0ZTogU3VuLCAyNyBKYW4gMjAxMyAwNDoyMzoxNCArMDEwMApTdWJq
ZWN0OiBbUEFUQ0hdIEZpeCBjcmFzaCBpbiBmZm1wZWcgbWV0YWRhdGEgaGFuZGxlcgoKaHR0cHM6
Ly9idWdzLmdlbnRvby5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9MzMzNzM0JmFjdGlvbj1kaWZmCgpJ
dCBzZWVtcyB0aGF0IGluaXRpYWxpemluZyB0aGUgcG9pbnRlciBkb2VzIHRoZSB0cmljay4KLS0t
CiBzcmMvbWV0YWRhdGEvZmZtcGVnX2hhbmRsZXIuY2MgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwg
MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvbWV0YWRhdGEv
ZmZtcGVnX2hhbmRsZXIuY2MgYi9zcmMvbWV0YWRhdGEvZmZtcGVnX2hhbmRsZXIuY2MKaW5kZXgg
ODIyOWQzNS4uZjU4MzRjZCAxMDA2NDQKLS0tIGEvc3JjL21ldGFkYXRhL2ZmbXBlZ19oYW5kbGVy
LmNjCisrKyBiL3NyYy9tZXRhZGF0YS9mZm1wZWdfaGFuZGxlci5jYwpAQCAtMjU5LDcgKzI1OSw3
IEBAIHZvaWQgRmZtcGVnSGFuZGxlcjo6ZmlsbE1ldGFkYXRhKFJlZjxDZHNJdGVtPiBpdGVtKQog
ICAgIGludCB4ID0gMDsKICAgICBpbnQgeSA9IDA7CiAKLQlBVkZvcm1hdENvbnRleHQgKnBGb3Jt
YXRDdHg7CisJQVZGb3JtYXRDb250ZXh0ICpwRm9ybWF0Q3R4ID0gTlVMTDsKIAkKIAkvLyBTdXBw
cmVzcyBhbGwgbG9nIG1lc3NhZ2VzCiAJYXZfbG9nX3NldF9jYWxsYmFjayhGZm1wZWdOb091dHB1
dFN0dWIpOwotLSAKMS44LjMuNAoK
</data>

          </attachment>
      

    </bug>

</bugzilla>