31473 2015-11-11 18:49:12 +0300 unneeded extra argument in gear-clone 2015-11-12 16:49:11 +0300 1 1 4 Development Sisyphus mithraen-build-utils unstable all Linux CLOSED FIXED P3 minor --- 1 imz nobody qa-sisyphus oldest_to_newest 153648 0 imz 2015-11-11 18:49:12 +0300 mithraen-build-utils-0.1.27-alt1 http://git.altlinux.org/people/imz/packages/?p=mithraen-build-utils.git;a=commitdiff;h=3d6f5cd38e2feb97babcb37c23c67b7c7d1c043b --- a/mithraen-build-utils/bin/gear-clone +++ b/mithraen-build-utils/bin/gear-clone @@ -16,7 +16,7 @@ type=`girar-get-upload-method "$name" ||:` if [ "$type" = "srpm" ]; then git clone git://git.altlinux.org/srpms/${name:0:1}/${name}.git else - girar-clone-build-commit -o girar "$name" "$name" "$name" + girar-clone-build-commit -o girar "$name" "$name" fi pushd "$name" &> /dev/null || exit -1 153649 1 imz 2015-11-11 19:58:15 +0300 Explained why in the updated commit message in http://git.altlinux.org/people/imz/packages/?p=mithraen-build-utils.git;a=commitdiff;h=2e77cfd3d17f5808c1f0ac1bacf0f504dac5c514 : Cf. -- no 3rd argument is used: $ girar-clone-build-commit -h Usage: girar-clone-build-commit [-h] [-f] [-b *repository*] [-d *local destination branch*] [-n *local repository name*] [-o *name*] *name* [*local repository name*] Options: -b *repository branch* Name of the repository branch. Values: sisyphus|5.1|p5|.. Default is sisyphus. -d *local destination branch name* Name of the checked out branch. Default is master. -f Forcefully remove previous <name>.git and clone over even if <name>.git already exists. -h Display this help and exit. -n *local repository name* Name of the local repository. Default is *name.git*. Can also be specified as the second argument. -o *remote name* Option passed to git-clone. Instead of using the remote name origin to keep track of the upstream repository, use *remote name*. $ 153651 2 imz 2015-11-11 21:14:47 +0300 Just in case, not to loose and forget this minor clean-up tweak in the code: task #153043 Please approve if that's OK with you when it is ready. 153659 3 mithraen 2015-11-12 12:21:47 +0300 Task #153043 approved 153660 4 repository-robot 2015-11-12 12:49:54 +0300 mithraen-build-utils-0.1.27-alt2 -> sisyphus: * Wed Nov 11 2015 Ivan Zakharyaschev <imz@altlinux> 0.1.27-alt2 - gear-clone: minor tweak (unneeded extra argument in the code removed) (ALT#31473).