33383 2017-04-17 15:50:32 +0300 [PATCH] task approve might result in non-zero exit code for no good reason 2017-04-17 18:50:14 +0300 1 1 2 Infrastructure Infrastructure git.altlinux.org unspecified all Linux CLOSED FIXED http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=bc9730be5bd6d3e50d5c4d3102f388bf88b623d5 regression P3 normal --- 1 mike ldv glebfm cas oldest_to_newest 163272 0 mike 2017-04-17 15:50:32 +0300 Looks like this commit involuntarily broke exit semantics by stuffing another command before the call: http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=74440ef665bf5f39c7cb69186d87f4c7ffc111f4 Hit that by attempting this: ssh git.alt task approve 181832 400 && ssh git.alt task approve 181832 500 The first command returned errorlevel 1 despite the {,sub}task existing with no other reasonable obstacles in sight. The attached patch should fix that by restoring the previous semantics. 163275 1 7060 mike 2017-04-17 16:00:06 +0300 Created attachment 7060 fix exit code semantics Duplicating patch reference from URL just in case: http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=bc9730be5bd6d3e50d5c4d3102f388bf88b623d5 163277 2 ldv 2017-04-17 16:16:43 +0300 Applied a simplified edition of your patch, thanks! 163295 3 mike 2017-04-17 18:50:14 +0300 VERIFIED THANKS :) 7060 2017-04-17 16:00:06 +0300 2017-04-17 16:00:06 +0300 fix exit code semantics 0001-girar-task-approve-fixed-errorlevel-returned.patch text/plain 927 mike RnJvbSBiYzk3MzBiZTViZDZkM2U1MGQ1YzRkMzEwMmYzODhiZjg4YjYyM2Q1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWdvcmluIDxtaWtlQGFsdGxpbnV4Lm9yZz4K RGF0ZTogTW9uLCAxNyBBcHIgMjAxNyAxNTozNToyMCArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIGdp cmFyLXRhc2stYXBwcm92ZTogZml4ZWQgZXJyb3JsZXZlbCByZXR1cm5lZAoKQSAndGFzayBhcHBy b3ZlJyBjb21tYW5kIHdvdWxkIHJldHVybiBub24temVybyBlcnJvcmxldmVsLApzdXJwcmlzaW5n bHksIGR1ZSB0byBjaGFuZ2VkIGV4aXQgc2VtYW50aWNzOyByZXN0b3JlIHRob3NlCmJyb2tlbiBi eSBjb21taXQgZzc0NDQwZWYuCgpGaXhlczogNzQ0NDBlZjY2NWJmNWYzOWM3Y2I2OTE4NmQ4N2Y0 YzdmZmMxMTFmNAotLS0KIGJpbi9naXJhci10YXNrLWFwcHJvdmUgfCAzICsrLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2Jpbi9n aXJhci10YXNrLWFwcHJvdmUgYi9iaW4vZ2lyYXItdGFzay1hcHByb3ZlCmluZGV4IDc1Y2Q0N2Mu LjA5MjQyMjIgMTAwNzU1Ci0tLSBhL2Jpbi9naXJhci10YXNrLWFwcHJvdmUKKysrIGIvYmluL2dp cmFyLXRhc2stYXBwcm92ZQpAQCAtMzEsOCArMzEsOSBAQCBmb3IgaSBpbiAkKGdlYXJfbnVtcyk7 IGRvCiAJWyAtZCAiYWNsLyRpIiBdICYmIFsgJ2FsbCcgPSAiJG51bSIgLW8gIiRpIiA9ICIkbnVt IiBdIHx8CiAJCWNvbnRpbnVlCiAJdG91Y2ggImFjbC8kaS8kR0lSQVJfVVNFUiIKKwlyYz0kPwog CVsgJ2FsbCcgPSAiJG51bSIgXSB8fAotCQlleGl0CisJCWV4aXQgJHJjCiBkb25lCiBbICdhbGwn ID0gIiRudW0iIF0gfHwKIAlmYXRhbCAidGFzayAjJGlkOiBzdWJ0YXNrICMkbnVtIG5vdCBmb3Vu ZCIKLS0gCjIuMTAuMgoK