<?xml version="1.0" encoding="UTF-8" ?>

<bugzilla version="5.2"
          urlbase="https://bugzilla.altlinux.org/"
          
          maintainer="jenya@basealt.ru"
>

    <bug>
          <bug_id>34322</bug_id>
          
          <creation_ts>2017-12-12 01:20:38 +0300</creation_ts>
          <short_desc>dhcp.c: Fix potentially destructive typo in perform_dhcp()</short_desc>
          <delta_ts>2018-05-08 23:27:49 +0300</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Development</classification>
          <product>Sisyphus</product>
          <component>propagator</component>
          <version>unstable</version>
          <rep_platform>all</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Arseny Maslennikov">arseny</reporter>
          <assigned_to name="Anton Farygin">rider</assigned_to>
          <cc>klark</cc>
    
    <cc>mike</cc>
    
    <cc>rider</cc>
    
    <cc>sem</cc>
          
          <qa_contact>qa-sisyphus</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>167849</commentid>
    <comment_count>0</comment_count>
      <attachid>7308</attachid>
    <who name="Arseny Maslennikov">arseny</who>
    <bug_when>2017-12-12 01:20:38 +0300</bug_when>
    <thetext>Created attachment 7308
патч

При сборке пропагатора gcc говорит:

dhcp.c: In function &apos;perform_dhcp&apos;:
dhcp.c:588:41: warning: argument to &apos;sizeof&apos; in &apos;memset&apos; call is the same expression as the destination; did you mean to remove the addressof? [-Wsizeof-pointer-memaccess]
  memset(&amp;client_addr.sin_addr, 0, sizeof(&amp;client_addr.sin_addr));

Вроде бы ничему оно там не мешает, но всё же.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>170981</commentid>
    <comment_count>1</comment_count>
    <who name="Repository Robot">repository-robot</who>
    <bug_when>2018-05-08 23:27:49 +0300</bug_when>
    <thetext>propagator-20180423-alt1 -&gt; sisyphus:

Mon Apr 23 2018 Leonid Krivoshein &lt;klark@altlinux&gt; 20180423-alt1
- New udev control logic imported from make-initrd scripts.
- Udev-trigger replaced to udev-settle() in hardware wait loops.
- All udev control code moved from init.c to new udev.c module.
- Lazy initialization mode support added for work in cooperate
  with make-initrd: this is experimental future, turned off by
  default, and also required patched make-initrd-propagator.
- disk.c, cdrom.c: 15 attempts with udev-settle() calls.
- network.c: bridge up algorithm reviewed, fixed memory leaks.
- network.c: 15 attempts to select and wait network interface;
- probing.c, probing.h, dhcp.c: small fixes, now black list used.
- modules_descr.h, stage1.c: deprecated header, unused code removed.
- dhcp.c: fix potentially destructive typo (closes: #34322),
  thanks to Arseny Maslennikov &lt;arseny@altlinux&gt;.
- Workaround race conditions during disks detection (closes: #30315).
- Workaround race conditions during bridging up network interfaces,
  see: https://bugzilla.altlinux.org/show_bug.cgi?id=34347 and
  https://lists.altlinux.org/pipermail/sysadmins/2018-April/date.html
  (about &quot;No network Devices found&quot; error message).
- Multiple small code improvements, fixes for avoid memory leaks
  and suppress compiler warnings.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>7308</attachid>
            <date>2017-12-12 01:20:38 +0300</date>
            <delta_ts>2017-12-12 01:20:38 +0300</delta_ts>
            <desc>патч</desc>
            <filename>0001-dhcp.c-Fix-potentially-destructive-typo-in-perform_d.patch</filename>
            <type>text/plain</type>
            <size>817</size>
            <attacher name="Arseny Maslennikov">arseny</attacher>
            
              <data encoding="base64">RnJvbSAyMDBmODk1MTM0ODg3OGZiMTM4ZWViOTExNjQ3NWE5MDdhOWJhOGViIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBcnNlbnkgTWFzbGVubmlrb3YgPGFyc2VueUBhbHRsaW51eC5v
cmc+CkRhdGU6IE1vbiwgMTEgRGVjIDIwMTcgMTk6MDk6MDcgKzAzMDAKU3ViamVjdDogW1BBVENI
XSBkaGNwLmM6IEZpeCBwb3RlbnRpYWxseSBkZXN0cnVjdGl2ZSB0eXBvIGluIHBlcmZvcm1fZGhj
cCgpCgotLS0KIGRoY3AuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg
MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RoY3AuYyBiL2RoY3AuYwppbmRleCAzNWM4ZmU3
Li5iZTY4MDVmIDEwMDY0NAotLS0gYS9kaGNwLmMKKysrIGIvZGhjcC5jCkBAIC01NTIsNyArNTUy
LDcgQEAgZW51bSByZXR1cm5fdHlwZSBwZXJmb3JtX2RoY3Aoc3RydWN0IGludGVyZmFjZV9pbmZv
ICogaW50ZikKIAltZXNzYWdlVHlwZSA9IERIQ1BfVFlQRV9ESVNDT1ZFUjsKIAlhZGRfdmVuZG9y
X2NvZGUoJmJyZXEsIERIQ1BfT1BUSU9OX1RZUEUsIDEsICZtZXNzYWdlVHlwZSk7CiAKLQltZW1z
ZXQoJmNsaWVudF9hZGRyLnNpbl9hZGRyLCAwLCBzaXplb2YoJmNsaWVudF9hZGRyLnNpbl9hZGRy
KSk7CisJbWVtc2V0KCZjbGllbnRfYWRkci5zaW5fYWRkciwgMCwgc2l6ZW9mKGNsaWVudF9hZGRy
LnNpbl9hZGRyKSk7CiAJY2xpZW50X2FkZHIuc2luX2ZhbWlseSA9IEFGX0lORVQ7CiAJY2xpZW50
X2FkZHIuc2luX3BvcnQgPSBodG9ucyhCT09UUF9DTElFTlRfUE9SVCk7CS8qIGJvb3RwIGNsaWVu
dCAqLwogCi0tIAoyLjEwLjQKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>