<?xml version="1.0" encoding="UTF-8" ?>

<bugzilla version="5.2"
          urlbase="https://bugzilla.altlinux.org/"
          
          maintainer="jenya@basealt.ru"
>

    <bug>
          <bug_id>35891</bug_id>
          
          <creation_ts>2019-01-12 17:27:18 +0300</creation_ts>
          <short_desc>Миграция на /run и /run/lock</short_desc>
          <delta_ts>2021-05-05 23:40:24 +0300</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Development</classification>
          <product>Sisyphus</product>
          <component>samba</component>
          <version>unstable</version>
          <rep_platform>all</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35881</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Антон Мидюков">antohami</reporter>
          <assigned_to name="Evgeny Sinelnikov">sin</assigned_to>
          <cc>m</cc>
    
    <cc>sin</cc>
          
          <qa_contact>qa-sisyphus</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>177293</commentid>
    <comment_count>0</comment_count>
    <who name="Антон Мидюков">antohami</who>
    <bug_when>2019-01-12 17:27:18 +0300</bug_when>
    <thetext>Исправьте конфиг f: 
&apos;s|/var/run|/run|&apos;

Также надо заменить везде:
&apos;s|/var/run|/run|g&apos;
&apos;s|/var/lock|/run/lock|g&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>180754</commentid>
    <comment_count>1</comment_count>
    <who name="Evgeny Sinelnikov">sin</who>
    <bug_when>2019-04-11 10:15:43 +0300</bug_when>
    <thetext>Там достаточно много мест, где это прибито. Первый шаг я уже сделал. Отваливалось на соответствии FHS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>180755</commentid>
    <comment_count>2</comment_count>
    <who name="Антон Мидюков">antohami</who>
    <bug_when>2019-04-11 11:04:51 +0300</bug_when>
    <thetext>Теперь можно в /run директории паковать:
http://git.altlinux.org/tasks/archive/done/_221/226655/

И как примеры:
http://git.altlinux.org/tasks/archive/done/_221/226647/
http://git.altlinux.org/tasks/archive/done/_220/225801/

Но я уже не уверен в необходимости такого перехода прямо сейчас.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198162</commentid>
    <comment_count>3</comment_count>
    <who name="Антон Мидюков">antohami</who>
    <bug_when>2021-04-27 06:15:03 +0300</bug_when>
    <thetext>Для того, чтобы мусор не сыпался при загрузке, достаточно исправить только packaging/systemd/samba.conf.tmp
Больше ничего исправлять не надо, так как /var/run является симлинком на /run, а /var/lock симлинком на /run/lock.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198336</commentid>
    <comment_count>4</comment_count>
    <who name="Evgeny Sinelnikov">sin</who>
    <bug_when>2021-05-04 06:21:33 +0300</bug_when>
    <thetext>Пробуем исправить в ближайшей сборке.

Пока непонятно что с этим всем делать:

$ git grep /var/lock

ctdb/config/ctdb.init:      [ $RETVAL -eq 0 ] &amp;&amp; touch /var/lock/subsys/ctdb || RETVAL=1
ctdb/config/ctdb.init:      [ $RETVAL -eq 0 ] &amp;&amp; rm -f /var/lock/subsys/ctdb
docs-xml/manpages/nmbd.8.xml:   &lt;/filename&gt; in the &lt;filename&gt;/usr/local/samba/var/locks&lt;/filename&gt;
docs-xml/manpages/winbindd.8.xml:               This directory is by default &lt;filename&gt;/usr/local/samba/var/locks
docs-xml/smbdotconf/generate-file-list.sh:&lt;!ENTITY pathconfig.LOCKDIR              &apos;\${prefix}/var/lock&apos;&gt;
docs-xml/smbdotconf/generate-file-list.sh:&lt;!ENTITY pathconfig.STATEDIR             &apos;\${prefix}/var/locks&apos;&gt;
extra/ctdb.init:LOCKFILE=/var/lock/subsys/ctdbd
extra/nmb.init:LOCKFILE=/var/lock/subsys/nmb
extra/samba.init:lockfile=/var/lock/subsys/$prog
extra/smb.init:LOCKFILE=/var/lock/subsys/smb
extra/winbind.init:LOCKFILE=/var/lock/subsys/winbindd
Binary file packaging/Example/skeleton.tar matches
python/samba/tests/gpo.py:        path = &apos;/usr/local/samba/var/locks/sysvol/../../../../../../root/&apos;
source3/script/tests/test_groupmap.sh:rm -f $PREFIX_ABS/var/locks/group_mapping.?db
source4/scripting/devel/config_base:    &quot;lock dir&quot; : &quot;${PREFIX}/var/locks&quot;,
source4/selftest/provisions/multi-dc-samba-master-c596ac6/etc/smb.conf: path = /usr/local/samba/var/locks/sysvol/samdom.example.com/scripts
source4/selftest/provisions/multi-dc-samba-master-c596ac6/etc/smb.conf: path = /usr/local/samba/var/locks/sysvol</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198337</commentid>
    <comment_count>5</comment_count>
    <who name="Evgeny Sinelnikov">sin</who>
    <bug_when>2021-05-04 06:22:30 +0300</bug_when>
    <thetext>Да и с этим тоже непонятно:

$ git grep /var/run

ctdb/config/ctdb.init:# pidfile: /var/run/ctdb/ctdbd.pid
ctdb/config/ctdb.init:pidfile=&quot;/var/run/ctdb/ctdbd.pid&quot;
ctdb/doc/examples/config_migrate.test_input:CTDB_SOCKET=&quot;/var/run/ctdb.sock&quot;
ctdb/doc/examples/nfs-ganesha-callout:  _pidfile=&quot;/var/run/ganesha.pid&quot;
ctdb/tests/UNIT/eventscripts/31.clamd.monitor.002.sh:CTDB_CLAMD_SOCKET=&quot;/var/run/clamd.sock&quot;
ctdb/tests/UNIT/eventscripts/31.clamd.monitor.003.sh:CTDB_CLAMD_SOCKET=&quot;/var/run/clamd.sock&quot;
ctdb/tests/UNIT/eventscripts/scripts/31.clamd.sh:CTDB_CLAMD_SOCKET=&quot;/var/run/clamd.sock&quot;
ctdb/wscript:    sed_expr4 = &apos;s|/usr/local/var/run/ctdb|%s|g&apos;  % (bld.env.CTDB_RUNDIR)
docs-xml/manpages/vfs_virusfilter.8.xml:                &lt;emphasis&gt;/var/run/savdi/sssp.sock&lt;/emphasis&gt;.&lt;/para&gt;
docs-xml/manpages/vfs_virusfilter.8.xml:                &lt;emphasis&gt;/var/run/clamav/clamd.ctl&lt;/emphasis&gt;.&lt;/para&gt;
docs-xml/smbdotconf/generate-file-list.sh:&lt;!ENTITY pathconfig.NCALRPCDIR           &apos;\${prefix}/var/run/ncalrpc&apos;&gt;
docs-xml/smbdotconf/generate-file-list.sh:&lt;!ENTITY pathconfig.PIDDIR               &apos;\${prefix}/var/run&apos;&gt;
docs-xml/smbdotconf/generate-file-list.sh:&lt;!ENTITY pathconfig.WINBINDD_SOCKET_DIR  &apos;\${prefix}/var/run/winbindd&apos;&gt;
docs-xml/smbdotconf/misc/cachedirectory.xml:&lt;value type=&quot;example&quot;&gt;/var/run/samba/locks/cache&lt;/value&gt;
docs-xml/smbdotconf/misc/lockdirectory.xml:&lt;value type=&quot;example&quot;&gt;/var/run/samba/locks&lt;/value&gt;
docs-xml/smbdotconf/misc/ncalrpcdir.xml:&lt;value type=&quot;example&quot;&gt;/var/run/samba/ncalrpc&lt;/value&gt;
docs-xml/smbdotconf/misc/piddirectory.xml:&lt;value type=&quot;example&quot;&gt;/var/run/&lt;/value&gt;
docs-xml/smbdotconf/misc/statedirectory.xml:&lt;value type=&quot;example&quot;&gt;/var/run/samba/locks/state&lt;/value&gt;
docs-xml/smbdotconf/misc/utmpdirectory.xml:     &lt;filename moreinfo=&quot;none&quot;&gt;/var/run/utmp&lt;/filename&gt; on Linux).&lt;/para&gt;
docs-xml/smbdotconf/misc/utmpdirectory.xml:&lt;value type=&quot;example&quot;&gt;/var/run/utmp&lt;/value&gt;
docs-xml/smbdotconf/misc/wtmpdirectory.xml:     &lt;filename moreinfo=&quot;none&quot;&gt;/var/run/wtmp&lt;/filename&gt; on Linux).
extra/ctdb.init:# pidfile: /var/run/ctdb/ctdbd.pid
extra/ctdb.init:PIDFILE=/var/run/ctdbd/ctdbd.pid
extra/nmb.init:# pidfile: /var/run/samba/nmbd.pid
extra/nmb.init:PIDFILE=/var/run/nmbd.pid
extra/samba.init:pidfile=/var/run/$prog.pid
extra/smb.init:# pidfile: /var/run/samba/smbd.pid
extra/smb.init:PIDFILE=/var/run/smbd.pid
extra/winbind.init:# pidfile: /var/run/winbindd.pid
extra/winbind.init:PIDFILE=/var/run/winbindd.pid
libgpo/admx/en-US/samba.adml:Example: /var/run/samba/locks/cache&lt;/string&gt;
libgpo/admx/en-US/samba.adml:Example: /var/run/samba/locks&lt;/string&gt;
libgpo/admx/en-US/samba.adml:Example: /var/run/samba/ncalrpc&lt;/string&gt;
libgpo/admx/en-US/samba.adml:Example: /var/run/&lt;/string&gt;
libgpo/admx/en-US/samba.adml:Example: /var/run/samba/locks/state&lt;/string&gt;
libgpo/admx/en-US/samba.adml:      &lt;string id=&quot;POL_21565354_4253_5482_97D2_9C2558461C47_Help&quot;&gt;This parameter is only available if Samba has been configured and compiled with the option --with-utmp. It specifies a directory pathname tha&gt;
libgpo/admx/en-US/samba.adml:Example: /var/run/utmp&lt;/string&gt;
libgpo/admx/en-US/samba.adml:      &lt;string id=&quot;POL_4F8E9BC0_CFAB_52F8_9C49_B8BB7400E60A_Help&quot;&gt;This parameter is only available if Samba has been configured and compiled with the option --with-utmp. It specifies a directory pathname tha&gt;
packaging/systemd/README:With systemd the /run or /var/run are tmpfs filesystems. This means
python/samba/tests/domain_backup.py:        settings = {&apos;state directory&apos;: &apos;/var/run&apos;,
samba4.spec:  with oldstyle /var/run due it symlink in modern linux installations
samba4.spec:- Prepare to replace runtime files from /var/run to /run directory
source3/modules/vfs_virusfilter_clamav.c:#  define VIRUSFILTER_DEFAULT_SOCKET_PATH      &quot;/var/run/clamav/clamd.ctl&quot;
source3/modules/vfs_virusfilter_sophos.c:#  define VIRUSFILTER_DEFAULT_SOCKET_PATH      &quot;/var/run/savdi/sssp.sock&quot;
source4/heimdal/lib/hcrypto/rand-egd.c:static const char *egd_path = &quot;/var/run/egd-pool&quot;;
source4/heimdal/lib/krb5/replay.c:    return &quot;FILE:/var/run/default_rcache&quot;;
source4/heimdal/lib/roken/roken-common.h:#define _PATH_VARRUN &quot;/var/run/&quot;
source4/scripting/devel/config_base:    &quot;pid directory&quot; : &quot;${PREFIX}/var/run&quot;,
source4/scripting/devel/config_base:    &quot;winbindd socket directory&quot; : &quot;${PREFIX}/var/run/winbindd&quot;,
source4/scripting/devel/config_base:    &quot;ntp signd socket directory&quot; : &quot;${PREFIX}/var/run/ntp_signd&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198363</commentid>
    <comment_count>6</comment_count>
    <who name="Repository Robot">repository-robot</who>
    <bug_when>2021-05-05 23:40:24 +0300</bug_when>
    <thetext>samba-4.14.4-alt1 -&gt; sisyphus:

 Fri Apr 30 2021 Evgeny Sinelnikov &lt;sin@altlinux&gt; 4.14.4-alt1
 - Fix buffer overrun in sids_to_unixids() (Fixes: CVE-2021-20254)
 - Final migration to /run directory (Closes: 35891, 36652, 39992)
 - Avoid build problems on e2k</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>