37077 2019-08-02 14:09:29 +0300 Регрегрессия при назначении групп 2019-08-06 22:18:47 +0300 1 1 4 Development Sisyphus libnss-role unstable all Linux CLOSED FIXED P3 blocker --- 1 sin lav iv lav piastry sin qa-sisyphus oldest_to_newest 183421 0 sin 2019-08-02 14:09:29 +0300 При развёртывании стеков с доменом выявлена регрессия. На старой инсталяции такие пакеты и настройки: [test@clw2x samba.git.test]$ rpm -q libnss-role libnss-role-0.3.1-alt1.x86_64 [test@clw2x samba.git.test]$ rpm -qf /usr/sbin/system-auth alterator-auth-0.40-alt1.x86_64 [test@clw2x samba.git.test]$ cat /etc/role 100:80,22,81,470,19,83,460,71,498,499,14,489,465 455:10 Domain Users:users Domain Admins:localadmins А на новой - такие: [root@clw2 ~]# rpm -q libnss-role libnss-role-0.4.0-alt1.x86_64 [root@clw2 ~]# rpm -qf /usr/sbin/system-auth alterator-auth-0.40-alt1.x86_64 [root@clw2 ~]# cat /etc/role localadmins:root Domain Users:users Domain Admins:localadmins ___________________________________ Суть регрессии: Проблема 1. [root@clw2 ~]# roleadd users uucp proc cdrom floppy cdwriter audio radio users scanner xgrp vboxusers sambashare camera Error 156: No such group [root@clw2 ~]# roleadd users uucp proc cdrom floppy cdwriter audio radio users scanner xgrp vboxusers sambashare [root@clw2 ~]# getent group camera camera:x:460:test [root@clw2 ~]# roleadd users camera [root@clw2 ~]# rolelst localadmins:root domain users:users domain admins:localadmins users:uucp,proc,cdrom,floppy,cdwriter,audio,radio,users,scanner,xgrp,vboxusers,sambashare,camera Проблема 2. [root@clw2 ~]# roleadd localadmins wheel [root@clw2 ~]# rolelst localadmins:root,wheel domain users:users domain admins:localadmins users:uucp,proc,cdrom,floppy,cdwriter,audio,radio,users,scanner,xgrp,vboxusers,sambashare,camera [root@clw2 ~]# roledel -r localadmins [root@clw2 ~]# rolelst domain users:users domain admins:localadmins users:uucp,proc,cdrom,floppy,cdwriter,audio,radio,users,scanner,xgrp,vboxusers,sambashare,camera [root@clw2 ~]# roleadd localadmins wheel [root@clw2 ~]# rolelst domain users:users domain admins:localadmins users:uucp,proc,cdrom,floppy,cdwriter,audio,radio,users,scanner,xgrp,vboxusers,sambashare,camera localadmins:root 183422 1 iv 2019-08-02 15:58:02 +0300 [root@titan ~]# roleadd users uucp free(): double free detected in tcache 2 Aborted (core dumped) вчерашний Сизиф. 183423 2 iv 2019-08-02 16:03:15 +0300 (In reply to comment #1) > [root@titan ~]# roleadd users uucp > free(): double free detected in tcache 2 > Aborted (core dumped) > > > вчерашний Сизиф. Возможно конечно это другой баг (я этот пытался воспроизвести). Вот вам backtrace: (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x00007ffff7df2515 in __GI_abort () at abort.c:79 #2 0x00007ffff7e49668 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff7f521fe "%s\n") at ../sysdeps/posix/libc_fatal.c:181 #3 0x00007ffff7e4fa7a in malloc_printerr (str=str@entry=0x7ffff7f53e60 "free(): double free detected in tcache 2") at malloc.c:5342 #4 0x00007ffff7e514dd in _int_free (av=0x7ffff7f88c40 <main_arena>, p=0x405680, have_lock=<optimized out>) at malloc.c:4195 #5 0x00007ffff7f9124d in librole_ver_free (v=0x405260) at parser.c:100 #6 0x00007ffff7f9128d in librole_graph_free (G=G@entry=0x7fffffffe240) at parser.c:110 #7 0x00000000004011fe in main (argc=3, argv=0x7fffffffe388) at roleadd.c:96 183425 3 8215 sin 2019-08-02 19:33:45 +0300 Created attachment 8215 Memory leaks analyze 001 Ну, это же решето. Это только первые 10 минут анализа кода на предмет утечек. Плюс имеется ошибка, которая тоже из-за копирования инициалированного указателя дважды удаляется. 183426 4 lav 2019-08-02 22:29:36 +0300 Я в курсе, код в переписывании, не успел доделать, вот ещё немного и допишу. 183486 5 repository-robot 2019-08-06 22:18:47 +0300 libnss-role-0.4.1-alt1 -> sisyphus: Tue Aug 06 2019 Evgeny Sinelnikov <sin@altlinux> 0.4.1-alt1 - Fix double memory free with crash before writing (Closes: 37077) 8215 2019-08-02 19:33:45 +0300 2019-08-02 19:33:45 +0300 Memory leaks analyze 001 leaks001.diff text/plain 1490 sin ZGlmZiAtLWdpdCBhL25zc19yb2xlLmMgYi9uc3Nfcm9sZS5jCmluZGV4IDlkZTlhYjkuLmFjZWVl MDUgMTAwNjQ0Ci0tLSBhL25zc19yb2xlLmMKKysrIGIvbnNzX3JvbGUuYwpAQCAtMTcsOSArMTcs OSBAQCBlbnVtIG5zc19zdGF0dXMgX25zc19yb2xlX2luaXRncm91cHNfZHluKGNoYXIgKnVzZXIs IGdpZF90IG1haW5fZ3JvdXAsCiAgICAgZW51bSBuc3Nfc3RhdHVzIHJldCA9IE5TU19TVEFUVVNf U1VDQ0VTUzsKICAgICBwdGhyZWFkX211dGV4X2xvY2soJm11dGV4KTsKIAotICAgIHN0cnVjdCBs aWJyb2xlX2dyYXBoIEc7CisgICAgc3RydWN0IGxpYnJvbGVfZ3JhcGggRyA9IHt9OwogICAgIGlu dCBpLCByZXN1bHQ7Ci0gICAgbGlicm9sZV9ncm91cF9jb2xsZWN0b3IgY29sLCBhbnM7CisgICAg bGlicm9sZV9ncm91cF9jb2xsZWN0b3IgY29sID0ge30sIGFucyA9IHt9OwogCiAgICAgcmVzdWx0 ID0gbGlicm9sZV9ncmFwaF9pbml0KCZHKTsKICAgICBpZiAocmVzdWx0ICE9IExJQlJPTEVfT0sp IHsKZGlmZiAtLWdpdCBhL3BhcnNlci5jIGIvcGFyc2VyLmMKaW5kZXggZDU0M2Y1MS4uMjM0YmVh OCAxMDA2NDQKLS0tIGEvcGFyc2VyLmMKKysrIGIvcGFyc2VyLmMKQEAgLTIwNCw3ICsyMDQsNyBA QCBzdGF0aWMgaW50IHBhcnNlX2xpbmUoY2hhciAqbGluZSwgc3RydWN0IGxpYnJvbGVfZ3JhcGgg KkcpCiAgICAgY29tbWVudCA9IHNlbGVjdF9saW5lX3BhcnQobGluZSwgbGVuLCAmbGFzdCwgJmks ICc6Jyk7CiAKICAgICBpZiAoY29tbWVudCAmJiAqbGFzdCA9PSAnXDAnKQotICAgICAgICByZXR1 cm4gcmVzdWx0OworICAgICAgICBnb3RvIGxpYm5zc19yb2xlX3BhcnNlX2xpbmVfZXJyb3I7CiAK ICAgICBkcm9wX3F1b3RlcygmbGFzdCk7CiAgICAgcmVzdWx0ID0gbGlicm9sZV9nZXRfZ2lkKGxh c3QsICZyb2xlLmdpZCk7CkBAIC0yNTUsOCArMjU1LDEwIEBAIGludCBsaWJyb2xlX3JlYWRpbmco Y29uc3QgY2hhciAqcywgc3RydWN0IGxpYnJvbGVfZ3JhcGggKkcpCiAgICAgICAgIHJldHVybiBM SUJST0xFX09VVF9PRl9SQU5HRTsKIAogICAgIGYgPSBmb3BlbihzLCAiciIpOwotICAgIGlmICgh ZikKLSAgICAgICAgcmV0dXJuIExJQlJPTEVfSU9fRVJST1I7CisgICAgaWYgKCFmKSB7CisgICAg ICAgIHJlc3VsdCA9IExJQlJPTEVfSU9fRVJST1I7CisgICAgICAgIGdvdG8gbGlibnNzX3JvbGVf cmVhZGluZ19vdXRfZnJlZTsKKyAgICB9CiAgICAgCiAgICAgd2hpbGUoMSkgewogICAgICAgICBj ID0gZmdldGMoZik7CkBAIC0yODcsOCArMjg5LDkgQEAgaW50IGxpYnJvbGVfcmVhZGluZyhjb25z dCBjaGFyICpzLCBzdHJ1Y3QgbGlicm9sZV9ncmFwaCAqRykKICAgICB9CiAgICAgCiBsaWJuc3Nf cm9sZV9yZWFkaW5nX291dDoKLSAgICBmcmVlKHN0cik7CiAgICAgZmNsb3NlKGYpOworbGlibnNz X3JvbGVfcmVhZGluZ19vdXRfZnJlZToKKyAgICBmcmVlKHN0cik7CiAgICAgcmV0dXJuIHJlc3Vs dDsKIH0KIAo=