45927 2023-04-21 14:31:47 +0300 procps: ошибка сборки с GCC 13 2025-06-09 12:50:46 +0300 1 1 4 Development Sisyphus procps unstable all Linux CLOSED FIXED P5 normal --- 1 asheplyakov sem asheplyakov iv ldv nir sem sin qa-sisyphus oldest_to_newest 224798 0 asheplyakov 2023-04-21 14:31:47 +0300 make[2]: Entering directory '/home/asheplyakov/work/bootstrap/RPM/BUILD/procps-3.3.17-alt7.g37f1060' gcc -std=gnu99 -DHAVE_CONFIG_H -I. -include ./config.h -I. -I./include -Wno-unused-result -DLOCALEDIR=\"/usr/share/locale\" -Iproc -pipe -frecord-gcc-switches -Wall -g -O2 -Werror -c -o top/top.o top/top.c top/top.c: In function 'keys_window': top/top.c:4471:55: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size 4 [-Werror=format-truncation=] 4471 | snprintf(q->rc.winname, sizeof(q->rc.winname), "%s", name); | ^~ ...... 5631 | if (tmp[0] && tmp[0] != kbd_ESC) win_names(w, tmp); | ~~~ In function 'win_names', inlined from 'keys_window' at top/top.c:5631:46: top/top.c:4471:7: note: 'snprintf' output between 1 and 128 bytes into a destination of size 4 4471 | snprintf(q->rc.winname, sizeof(q->rc.winname), "%s", name); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ top/top.c: In function 'keys_window': top/top.c:4472:49: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size between 0 and 4 [-Werror=format-truncation=] 4472 | snprintf(q->grpname, sizeof(q->grpname), "%d:%s", q->winnum, name); | ^~ ...... 5631 | if (tmp[0] && tmp[0] != kbd_ESC) win_names(w, tmp); | ~~~ In function 'win_names', inlined from 'keys_window' at top/top.c:5631:46: top/top.c:4472:4: note: 'snprintf' output between 3 and 140 bytes into a destination of size 6 4472 | snprintf(q->grpname, sizeof(q->grpname), "%d:%s", q->winnum, name); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[2]: *** [Makefile:1572: top/top.o] Error 1 make[2]: Leaving directory '/home/asheplyakov/work/bootstrap/RPM/BUILD/procps-3.3.17-alt7.g37f1060' make[1]: *** [Makefile:1908: all-recursive] Error 1 make: *** [Makefile:1077: all] Error 2 error: Bad exit status from /home/asheplyakov/work/bootstrap/tmp/rpm-tmp.86525 (%build) 224799 1 asheplyakov 2023-04-21 14:32:59 +0300 Возможно связано с https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95755 (но это не точно) 224808 2 asheplyakov 2023-04-21 14:56:16 +0300 5628 if (ALTCHKw) { 5629 char tmp[SMLBUFSIZ]; 5630 STRLCPY(tmp, ioline(fmtmk(N_fmt(NAME_windows_fmt), w->rc.winname))); 5631 if (tmp[0] && tmp[0] != kbd_ESC) win_names(w, tmp); 5632 } 5633 break; $ grep -r -n -E 'define\s+SMLBUFSIZ\b' top/top.h:139:#define SMLBUFSIZ 128 4467 static void win_names (WIN_t *q, const char *name) { 4468 /* note: sprintf/snprintf results are "undefined" when src==dst, 4469 according to C99 & POSIX.1-2001 (thanks adc) */ 4470 if (q->rc.winname != name) 4471 snprintf(q->rc.winname, sizeof(q->rc.winname), "%s", name); 4472 snprintf(q->grpname, sizeof(q->grpname), "%d:%s", q->winnum, name); 4473 } // end: win_names $ grep -e 'winname' 'top/top.h' #define WINNAMSIZ 4 /* size of RCW_t winname buf (incl '\0') */ char winname [WINNAMSIZ], // name for the window, user changeable На первый взгляд это действительно попытка напечатать до 128 байт в буфер размером 4 байта 224815 3 12996 asheplyakov 2023-04-21 15:42:01 +0300 Created attachment 12996 патч 224917 4 13009 sem 2023-04-24 17:58:13 +0300 Created attachment 13009 disable_trunc_error.patch (In reply to Alexey Sheplyakov from comment #2) > На первый взгляд это действительно попытка напечатать до 128 байт в буфер > размером 4 байта Да, похоже апстрим считает, что truncation здесь - это нормально. Думаю, можно просто выключить -Werror в этом месте. Проверьте, пожалуйста, работает ди такой вариант. 234411 5 sem 2023-10-05 16:02:32 +0300 Я не вижу такой ошибки с gcc13. Может проблема возникает только на конкретной архитектуре? 266869 6 iv 2025-06-09 12:50:46 +0300 Для procps 4+ не актуально, он собирается на loongarch64 и с помощью gcc13, и с помощью gcc14. 12996 2023-04-21 15:42:01 +0300 2023-04-24 17:58:13 +0300 патч 0001-top-fixed-build-error-with-GCC-13.patch text/plain 5263 asheplyakov RnJvbSAyNGU2MzdiNWFkZjY0YzdjYWUyZGZlNGE3ZTM3OTcxMGNmZjU2MmYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4ZXkgU2hlcGx5YWtvdiA8YXNoZXBseWFrb3ZAYmFzZWFs dC5ydT4KRGF0ZTogRnJpLCAyMSBBcHIgMjAyMyAxNjozMzowNCArMDQwMApTdWJqZWN0OiBbUEFU Q0hdIHRvcDogZml4ZWQgYnVpbGQgZXJyb3Igd2l0aCBHQ0MgMTMKCnRvcC90b3AuYzogSW4gZnVu Y3Rpb24gJ2tleXNfd2luZG93JzoKdG9wL3RvcC5jOjQ0NzE6NTU6IGVycm9yOiAnJXMnIGRpcmVj dGl2ZSBvdXRwdXQgbWF5IGJlIHRydW5jYXRlZCB3cml0aW5nIHVwIHRvIDEyNyBieXRlcyBpbnRv IGEgcmVnaW9uIG9mIHNpemUgNCBbLVdlcnJvcj1mb3JtYXQtdHJ1bmNhdGlvbj1dCiA0NDcxIHwg ICAgICAgc25wcmludGYocS0+cmMud2lubmFtZSwgc2l6ZW9mKHEtPnJjLndpbm5hbWUpLCAiJXMi LCBuYW1lKTsKICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBefgouLi4uLi4KIDU2MzEgfCAgICAgICAgICAgICBpZiAodG1wWzBdICYm IHRtcFswXSAhPSBrYmRfRVNDKSB3aW5fbmFtZXModywgdG1wKTsKICAgICAgfCAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfn5+CkluIGZ1 bmN0aW9uICd3aW5fbmFtZXMnLAogICAgaW5saW5lZCBmcm9tICdrZXlzX3dpbmRvdycgYXQgdG9w L3RvcC5jOjU2MzE6NDY6CnRvcC90b3AuYzo0NDcxOjc6IG5vdGU6ICdzbnByaW50Zicgb3V0cHV0 IGJldHdlZW4gMSBhbmQgMTI4IGJ5dGVzIGludG8gYSBkZXN0aW5hdGlvbiBvZiBzaXplIDQKIDQ0 NzEgfCAgICAgICBzbnByaW50ZihxLT5yYy53aW5uYW1lLCBzaXplb2YocS0+cmMud2lubmFtZSks ICIlcyIsIG5hbWUpOwogICAgICB8ICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KdG9wL3RvcC5jOiBJbiBmdW5jdGlvbiAna2V5 c193aW5kb3cnOgp0b3AvdG9wLmM6NDQ3Mjo0OTogZXJyb3I6ICclcycgZGlyZWN0aXZlIG91dHB1 dCBtYXkgYmUgdHJ1bmNhdGVkIHdyaXRpbmcgdXAgdG8gMTI3IGJ5dGVzIGludG8gYSByZWdpb24g b2Ygc2l6ZSBiZXR3ZWVuIDAgYW5kIDQgWy1XZXJyb3I9Zm9ybWF0LXRydW5jYXRpb249XQogNDQ3 MiB8ICAgIHNucHJpbnRmKHEtPmdycG5hbWUsIHNpemVvZihxLT5ncnBuYW1lKSwgIiVkOiVzIiwg cS0+d2lubnVtLCBuYW1lKTsKICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBefgouLi4uLi4KIDU2MzEgfCAgICAgICAgICAgICBpZiAodG1wWzBd ICYmIHRtcFswXSAhPSBrYmRfRVNDKSB3aW5fbmFtZXModywgdG1wKTsKICAgICAgfCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfn5+Cklu IGZ1bmN0aW9uICd3aW5fbmFtZXMnLAogICAgaW5saW5lZCBmcm9tICdrZXlzX3dpbmRvdycgYXQg dG9wL3RvcC5jOjU2MzE6NDY6CnRvcC90b3AuYzo0NDcyOjQ6IG5vdGU6ICdzbnByaW50Zicgb3V0 cHV0IGJldHdlZW4gMyBhbmQgMTQwIGJ5dGVzIGludG8gYSBkZXN0aW5hdGlvbiBvZiBzaXplIDYK IDQ0NzIgfCAgICBzbnByaW50ZihxLT5ncnBuYW1lLCBzaXplb2YocS0+Z3JwbmFtZSksICIlZDol cyIsIHEtPndpbm51bSwgbmFtZSk7CiAgICAgIHwgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CmNjMTogYWxsIHdhcm5p bmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCgo1NjI4ICAgICAgICAgIGlmIChBTFRDSEt3KSB7 CjU2MjkgICAgICAgICAgICAgY2hhciB0bXBbU01MQlVGU0laXTsKNTYzMCAgICAgICAgICAgICBT VFJMQ1BZKHRtcCwgaW9saW5lKGZtdG1rKE5fZm10KE5BTUVfd2luZG93c19mbXQpLCB3LT5yYy53 aW5uYW1lKSkpOwo1NjMxICAgICAgICAgICAgIGlmICh0bXBbMF0gJiYgdG1wWzBdICE9IGtiZF9F U0MpIHdpbl9uYW1lcyh3LCB0bXApOwo1NjMyICAgICAgICAgIH0KNTYzMyAgICAgICAgICBicmVh azsKCiQgZ3JlcCAtciAtbiAtRSAnZGVmaW5lXHMrU01MQlVGU0laXGInCnRvcC90b3AuaDoxMzk6 I2RlZmluZSBTTUxCVUZTSVogICAxMjgKCjQ0Njcgc3RhdGljIHZvaWQgd2luX25hbWVzIChXSU5f dCAqcSwgY29uc3QgY2hhciAqbmFtZSkgewo0NDY4ICAgIC8qIG5vdGU6IHNwcmludGYvc25wcmlu dGYgcmVzdWx0cyBhcmUgInVuZGVmaW5lZCIgd2hlbiBzcmM9PWRzdCwKNDQ2OSAgICAgICAgICAg ICBhY2NvcmRpbmcgdG8gQzk5ICYgUE9TSVguMS0yMDAxICh0aGFua3MgYWRjKSAqLwo0NDcwICAg IGlmIChxLT5yYy53aW5uYW1lICE9IG5hbWUpCjQ0NzEgICAgICAgc25wcmludGYocS0+cmMud2lu bmFtZSwgc2l6ZW9mKHEtPnJjLndpbm5hbWUpLCAiJXMiLCBuYW1lKTsKNDQ3MiAgICBzbnByaW50 ZihxLT5ncnBuYW1lLCBzaXplb2YocS0+Z3JwbmFtZSksICIlZDolcyIsIHEtPndpbm51bSwgbmFt ZSk7CjQ0NzMgfSAvLyBlbmQ6IHdpbl9uYW1lcwoKJCBncmVwIC1lICd3aW5uYW1lJyAndG9wL3Rv cC5oJwoKICAgY2hhciAgIHdpbm5hbWUgW1dJTk5BTVNJWl0sICAgIC8vIG5hbWUgZm9yIHRoZSB3 aW5kb3csIHVzZXIgY2hhbmdlYWJsZQoKSXQgbG9va3MgbGlrZSB0aGUgYWJvdmUgY29kZSBpbmRl ZWQgd3JpdGVzIHVwIHRvIDEyOCBieXRlcyBpbnRvIGEgNC1ieXRlIGJ1ZmZlci4KVG8gYXZvaWQg dGhlIHdhcm5pbmcKMSkgU3BlY2lmeSB0aGUgbWF4aW1hbCBzdHJpbmcgbGVuZ3RoIGluIHRoZSBm b3JtYXQgc3RyaW5nLCBsaWtlICIlLjRzIi4KMikgQWRkIG9uZSBtb3JlIGJ5dGUgdG8gd2lubmFt ZSAoZm9yIGEgdGVybWluYXRpbmcgJ1wwJyBjaGFyYWN0ZXIpLgoKQUxUQlVHOiAjNDU5MjcKCmwK LS0tCiB0b3AvdG9wLmMgfCA5ICsrKysrKystLQogdG9wL3RvcC5oIHwgNCArKy0tCiAyIGZpbGVz IGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90 b3AvdG9wLmMgYi90b3AvdG9wLmMKaW5kZXggZTY0Yzg2NjAuLjg2MzZhYzIwIDEwMDY0NAotLS0g YS90b3AvdG9wLmMKKysrIGIvdG9wL3RvcC5jCkBAIC00NDYyLDE2ICs0NDYyLDIxIEBAIHN0YXRp YyB2b2lkIHdoYWNrX3Rlcm1pbmFsICh2b2lkKSB7CiAMCiAvKiMjIyMjIyAgV2luZG93cy9GaWVs ZCBHcm91cHMgc3VwcG9ydCAgIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjKi8KIAor I2RlZmluZSB4c3RyKHMpIHN0cihzKQorI2RlZmluZSBzdHIocykgI3MKKwogICAgICAgICAvKgog ICAgICAgICAgKiBWYWx1ZSBhIHdpbmRvdydzIG5hbWUgYW5kIG1ha2UgdGhlIGFzc29jaWF0ZWQg Z3JvdXAgbmFtZS4gKi8KIHN0YXRpYyB2b2lkIHdpbl9uYW1lcyAoV0lOX3QgKnEsIGNvbnN0IGNo YXIgKm5hbWUpIHsKICAgIC8qIG5vdGU6IHNwcmludGYvc25wcmludGYgcmVzdWx0cyBhcmUgInVu ZGVmaW5lZCIgd2hlbiBzcmM9PWRzdCwKICAgICAgICAgICAgIGFjY29yZGluZyB0byBDOTkgJiBQ T1NJWC4xLTIwMDEgKHRoYW5rcyBhZGMpICovCiAgICBpZiAocS0+cmMud2lubmFtZSAhPSBuYW1l KQotICAgICAgc25wcmludGYocS0+cmMud2lubmFtZSwgc2l6ZW9mKHEtPnJjLndpbm5hbWUpLCAi JXMiLCBuYW1lKTsKLSAgIHNucHJpbnRmKHEtPmdycG5hbWUsIHNpemVvZihxLT5ncnBuYW1lKSwg IiVkOiVzIiwgcS0+d2lubnVtLCBuYW1lKTsKKyAgICAgIHNucHJpbnRmKHEtPnJjLndpbm5hbWUs IHNpemVvZihxLT5yYy53aW5uYW1lKSwgIiUuIiB4c3RyKFdJTk5BTVNJWikgInMiLCBuYW1lKTsK KyAgIHNucHJpbnRmKHEtPmdycG5hbWUsIHNpemVvZihxLT5ncnBuYW1lKSwgIiVkOiUuIiB4c3Ry KFdJTk5BTVNJWikgInMiLCBxLT53aW5udW0sIG5hbWUpOwogfSAvLyBlbmQ6IHdpbl9uYW1lcwog CisjdW5kZWYgc3RyCisjdW5kZWYgeHN0cgogCiAgICAgICAgIC8qCiAgICAgICAgICAqIFRoaXMg Z3V5IGp1c3QgcmVzZXRzIChub3JtYWxpemVzKSBhIHNpbmdsZSB3aW5kb3cKZGlmZiAtLWdpdCBh L3RvcC90b3AuaCBiL3RvcC90b3AuaAppbmRleCA0OTlkOTk1Ny4uZGUxZTBiZjYgMTAwNjQ0Ci0t LSBhL3RvcC90b3AuaAorKysgYi90b3AvdG9wLmgKQEAgLTM3OCw3ICszNzgsNyBAQCB0eXBlZGVm IHN0cnVjdCBSQ1dfdCB7ICAvLyB0aGUgJ3dpbmRvdycgcG9ydGlvbiBvZiBhbiByY2ZpbGUKICAg ICAgICAgICBtc2dzY2xyLCAgICAgICAgICAgICAgICAvLyAgICAgICAgICAgICAiICAgICAgICAg ICBpbiBtc2dzL3BtdHMKICAgICAgICAgICBoZWFkY2xyLCAgICAgICAgICAgICAgICAvLyAgICAg ICAgICAgICAiICAgICAgICAgICBpbiBjb2xzIGhlYWQKICAgICAgICAgICB0YXNrY2xyOyAgICAg ICAgICAgICAgICAvLyAgICAgICAgICAgICAiICAgICAgICAgICBpbiB0YXNrIHJvd3MKLSAgIGNo YXIgICB3aW5uYW1lIFtXSU5OQU1TSVpdLCAgICAvLyBuYW1lIGZvciB0aGUgd2luZG93LCB1c2Vy IGNoYW5nZWFibGUKKyAgIGNoYXIgICB3aW5uYW1lIFtXSU5OQU1TSVorMV0sICAgIC8vIG5hbWUg Zm9yIHRoZSB3aW5kb3csIHVzZXIgY2hhbmdlYWJsZQogICAgICAgICAgIGZpZWxkc2N1ciBbUEZM QUdTU0laXTsgIC8vIHRoZSBmaWVsZHMgZm9yIGRpc3BsYXkgJiB0aGVpciBvcmRlcgogfSBSQ1df dDsKIApAQCAtNDI3LDcgKzQyNyw3IEBAIHR5cGVkZWYgc3RydWN0IFdJTl90IHsKICAgICAgICAg ICBjYXBjbHJfcm93aGlnaCBbQ0xSQlVGU0laXSwgIC8vICAgICAgICAgYXJlIG9ubHkgdXNlZCB3 aGVuIHRoaXMKICAgICAgICAgICBjYXBjbHJfcm93bm9ybSBbQ0xSQlVGU0laXSwgIC8vICAgICAg ICAgd2luZG93IGlzIHRoZSAnQ3Vyd2luJyEKICAgICAgICAgICBjYXBfYm9sZCBbQ0FQQlVGU0la XSwgICAgICAgIC8vIHN1cHBvcnQgZm9yIFZpZXdfTk9CT0xEIHRvZ2dsZQotICAgICAgICAgIGdy cG5hbWUgW0dSUE5BTVNJWl0sICAgICAgICAgLy8gd2luZG93IG51bWJlcjpuYW1lLCBwcmludGFi bGUKKyAgICAgICAgICBncnBuYW1lIFtHUlBOQU1TSVorMV0sICAgICAgICAgLy8gd2luZG93IG51 bWJlcjpuYW1lLCBwcmludGFibGUKICNpZmRlZiBVU0VfWF9DT0xIRFIKICAgICAgICAgICBjb2x1 bW5oZHIgW1JPV01JTlNJWl0sICAgICAgIC8vIGNvbHVtbiBoZWFkaW5ncyBmb3IgcHJvY2ZsZ3MK ICNlbHNlCi0tIAoyLjMzLjcKCg== 13009 2023-04-24 17:58:13 +0300 2023-04-24 17:58:13 +0300 disable_trunc_error.patch disable_trunc_error.patch text/plain 648 sem ZGlmZiAtLWdpdCBhL3RvcC90b3AuYyBiL3RvcC90b3AuYwppbmRleCBlNjRjODY2MC4uNTJiMGEw NTAgMTAwNjQ0Ci0tLSBhL3RvcC90b3AuYworKysgYi90b3AvdG9wLmMKQEAgLTQ0NjcsOSArNDQ2 NywxMiBAQCBzdGF0aWMgdm9pZCB3aGFja190ZXJtaW5hbCAodm9pZCkgewogc3RhdGljIHZvaWQg d2luX25hbWVzIChXSU5fdCAqcSwgY29uc3QgY2hhciAqbmFtZSkgewogICAgLyogbm90ZTogc3By aW50Zi9zbnByaW50ZiByZXN1bHRzIGFyZSAidW5kZWZpbmVkIiB3aGVuIHNyYz09ZHN0LAogICAg ICAgICAgICAgYWNjb3JkaW5nIHRvIEM5OSAmIFBPU0lYLjEtMjAwMSAodGhhbmtzIGFkYykgKi8K KyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyB3YXJu aW5nICItV2Zvcm1hdC10cnVuY2F0aW9uIgogICAgaWYgKHEtPnJjLndpbm5hbWUgIT0gbmFtZSkK ICAgICAgIHNucHJpbnRmKHEtPnJjLndpbm5hbWUsIHNpemVvZihxLT5yYy53aW5uYW1lKSwgIiVz IiwgbmFtZSk7CiAgICBzbnByaW50ZihxLT5ncnBuYW1lLCBzaXplb2YocS0+Z3JwbmFtZSksICIl ZDolcyIsIHEtPndpbm51bSwgbmFtZSk7CisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcAogfSAv LyBlbmQ6IHdpbl9uYW1lcwogCiAK