52372 2024-12-08 05:35:13 +0300 Заголовочный файл ссылается на неопределённые символы 2024-12-08 05:50:22 +0300 1 1 4 Development Sisyphus libreiserfsprogs unstable x86_64 Linux NEW P5 normal --- 1 klark led led mike qa-sisyphus oldest_to_newest 255640 0 17354 klark 2024-12-08 05:35:13 +0300 Created attachment 17354 remove inline declarations from common header Несколько символов в /usr/include/reiserfs/tools.h объявлены как extern inline, они определены в tools.c в самой библиотеке. Соответственно, при сборке ПО с данной библиотекой не определены. Там, где они используются, будет ошибка, а где не используются, такие предупреждения: In file included from /usr/include/reiserfs/object.h:25, from /usr/include/reiserfs/tree.h:27, from /usr/include/reiserfs/reiserfs.h:39, from reiserfsclone.c:26: /usr/include/reiserfs/tools.h:35:19: warning: inline function 'reiserfs_tools_find_next_zero_bit' declared but never defined 35 | extern inline int reiserfs_tools_find_next_zero_bit (const void *vaddr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/reiserfs/tools.h:32:19: warning: inline function 'reiserfs_tools_find_first_zero_bit' declared but never defined 32 | extern inline int reiserfs_tools_find_first_zero_bit (const void *vaddr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/reiserfs/tools.h:30:19: warning: inline function 'reiserfs_tools_test_bit' declared but never defined 30 | extern inline int reiserfs_tools_test_bit(int nr, const void *addr); | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/reiserfs/tools.h:29:19: warning: inline function 'reiserfs_tools_clear_bit' declared but never defined 29 | extern inline int reiserfs_tools_clear_bit (int nr, void *addr); | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/reiserfs/tools.h:28:19: warning: inline function 'reiserfs_tools_set_bit' declared but never defined 28 | extern inline int reiserfs_tools_set_bit (int nr, void *addr); | ^~~~~~~~~~~~~~~~~~~~~~ Предлагаю патч для исправления. Следом соберу тестовый таск. 255641 1 klark 2024-12-08 05:50:22 +0300 Собрал таск #364406. При сборке с ним partclone указанные предупреждения уходят. Если не будет возражений, могу закоммитить. 17354 2024-12-08 05:35:13 +0300 2024-12-08 05:35:13 +0300 remove inline declarations from common header libreiserfs-0.3.0.5-tools.patch text/plain 3060 klark ZGlmZiAtdXJOIHByb2dzcmVpc2VyZnMtMC4zLjAuNS9pbmNsdWRlL3JlaXNlcmZzL3Rvb2xzLmgu b3JpZyBwcm9nc3JlaXNlcmZzLTAuMy4wLjUvaW5jbHVkZS9yZWlzZXJmcy90b29scy5oCi0tLSBw cm9nc3JlaXNlcmZzLTAuMy4wLjUvaW5jbHVkZS9yZWlzZXJmcy90b29scy5oLm9yaWcJMjAyNC0x Mi0wOCAwNDoxNDo0Ni4zNjg0MDAwNDkgKzAzMDAKKysrIHByb2dzcmVpc2VyZnMtMC4zLjAuNS9p bmNsdWRlL3JlaXNlcmZzL3Rvb2xzLmgJMjAyNC0xMi0wOCAwNDoxNDo0Ni4zNjg0MDAwNDkgKzAz MDAKQEAgLTI1LDE0ICsyNSwxNCBAQAogCiB0eXBlZGVmIGludCAoKnJlaXNlcmZzX2NvbXBfZnVu Y190KSh2b2lkICppdGVtMSwgdm9pZCAqaXRlbTIpOwogCi1leHRlcm4gaW5saW5lIGludCByZWlz ZXJmc190b29sc19zZXRfYml0IChpbnQgbnIsIHZvaWQgKmFkZHIpOwotZXh0ZXJuIGlubGluZSBp bnQgcmVpc2VyZnNfdG9vbHNfY2xlYXJfYml0IChpbnQgbnIsIHZvaWQgKmFkZHIpOwotZXh0ZXJu IGlubGluZSBpbnQgcmVpc2VyZnNfdG9vbHNfdGVzdF9iaXQoaW50IG5yLCBjb25zdCB2b2lkICph ZGRyKTsKK2V4dGVybiBpbnQgcmVpc2VyZnNfdG9vbHNfc2V0X2JpdCAoaW50IG5yLCB2b2lkICph ZGRyKTsKK2V4dGVybiBpbnQgcmVpc2VyZnNfdG9vbHNfY2xlYXJfYml0IChpbnQgbnIsIHZvaWQg KmFkZHIpOworZXh0ZXJuIGludCByZWlzZXJmc190b29sc190ZXN0X2JpdChpbnQgbnIsIGNvbnN0 IHZvaWQgKmFkZHIpOwogCi1leHRlcm4gaW5saW5lIGludCByZWlzZXJmc190b29sc19maW5kX2Zp cnN0X3plcm9fYml0IChjb25zdCB2b2lkICp2YWRkciwKK2V4dGVybiBpbnQgcmVpc2VyZnNfdG9v bHNfZmluZF9maXJzdF96ZXJvX2JpdCAoY29uc3Qgdm9pZCAqdmFkZHIsCiAJCQkJCQkgICAgICB1 bnNpZ25lZCBzaXplKTsKIAotZXh0ZXJuIGlubGluZSBpbnQgcmVpc2VyZnNfdG9vbHNfZmluZF9u ZXh0X3plcm9fYml0IChjb25zdCB2b2lkICp2YWRkciwKK2V4dGVybiBpbnQgcmVpc2VyZnNfdG9v bHNfZmluZF9uZXh0X3plcm9fYml0IChjb25zdCB2b2lkICp2YWRkciwKIAkJCQkJCSAgICAgdW5z aWduZWQgc2l6ZSwKIAkJCQkJCSAgICAgdW5zaWduZWQgb2Zmc2V0KTsKIApkaWZmIC11ck4gcHJv Z3NyZWlzZXJmcy0wLjMuMC41L2xpYnJlaXNlcmZzL3Rvb2xzLmMub3JpZyBwcm9nc3JlaXNlcmZz L2xpYnJlaXNlcmZzL3Rvb2xzLmMKLS0tIHByb2dzcmVpc2VyZnMtMC4zLjAuNS9saWJyZWlzZXJm cy90b29scy5jLm9yaWcJMjAyNC0xMi0wOCAwNDoxNDo0Ni4zNjg0MDAwNDkgKzAzMDAKKysrIHBy b2dzcmVpc2VyZnMtMC4zLjAuNS9saWJyZWlzZXJmcy90b29scy5jCTIwMjQtMTItMDggMDQ6MTQ6 NDYuMzY4NDAwMDQ5ICswMzAwCkBAIC0xOTMsMzQgKzE5MywzMSBAQCBmb3VuZF9taWRkbGU6CiAJ cmV0dXJuIHJlc3VsdCArIHJlaXNlcmZzX3Rvb2xzX2ZmeihTV0FQMzIodG1wKSk7CiB9CiAKLWlu bGluZSBpbnQgcmVpc2VyZnNfdG9vbHNfc2V0X2JpdChpbnQgbnIsIHZvaWQgKmFkZHIpIHsKK2lu dCByZWlzZXJmc190b29sc19zZXRfYml0KGludCBuciwgdm9pZCAqYWRkcikgewogI2lmbmRlZiBX T1JEU19CSUdFTkRJQU4gICAgCiAJcmV0dXJuIHJlaXNlcmZzX3Rvb2xzX2xlX3NldF9iaXQobnIs IGFkZHIpOwogI2Vsc2UgCiAJcmV0dXJuIHJlaXNlcmZzX3Rvb2xzX2JlX3NldF9iaXQobnIsIGFk ZHIpOwogI2VuZGlmIAotCXJldHVybiAwOwogfQogCi1pbmxpbmUgaW50IHJlaXNlcmZzX3Rvb2xz X2NsZWFyX2JpdChpbnQgbnIsIHZvaWQgKmFkZHIpIHsKK2ludCByZWlzZXJmc190b29sc19jbGVh cl9iaXQoaW50IG5yLCB2b2lkICphZGRyKSB7CiAjaWZuZGVmIFdPUkRTX0JJR0VORElBTiAgICAK IAlyZXR1cm4gcmVpc2VyZnNfdG9vbHNfbGVfY2xlYXJfYml0KG5yLCBhZGRyKTsKICNlbHNlIAog CXJldHVybiByZWlzZXJmc190b29sc19iZV9jbGVhcl9iaXQobnIsIGFkZHIpOwogI2VuZGlmIAot CXJldHVybiAwOwogfQogCi1pbmxpbmUgaW50IHJlaXNlcmZzX3Rvb2xzX3Rlc3RfYml0KGludCBu ciwgY29uc3Qgdm9pZCAqYWRkcikgeworaW50IHJlaXNlcmZzX3Rvb2xzX3Rlc3RfYml0KGludCBu ciwgY29uc3Qgdm9pZCAqYWRkcikgewogI2lmbmRlZiBXT1JEU19CSUdFTkRJQU4gICAgCiAJcmV0 dXJuIHJlaXNlcmZzX3Rvb2xzX2xlX3Rlc3RfYml0KG5yLCBhZGRyKTsKICNlbHNlIAogCXJldHVy biByZWlzZXJmc190b29sc19iZV90ZXN0X2JpdChuciwgYWRkcik7CiAjZW5kaWYgCi0JcmV0dXJu IDA7CiB9CiAKLWlubGluZSBpbnQgcmVpc2VyZnNfdG9vbHNfZmluZF9maXJzdF96ZXJvX2JpdChj b25zdCB2b2lkICp2YWRkciwKK2ludCByZWlzZXJmc190b29sc19maW5kX2ZpcnN0X3plcm9fYml0 KGNvbnN0IHZvaWQgKnZhZGRyLAogCQkJCQkgICAgICB1bnNpZ25lZCBzaXplKQogewogI2lmbmRl ZiBXT1JEU19CSUdFTkRJQU4gICAgCkBAIC0yMjgsMTAgKzIyNSw5IEBAIGlubGluZSBpbnQgcmVp c2VyZnNfdG9vbHNfZmluZF9maXJzdF96ZXJvX2JpdChjb25zdCB2b2lkICp2YWRkciwKICNlbHNl IAogCXJldHVybiByZWlzZXJmc190b29sc19iZV9maW5kX2ZpcnN0X3plcm9fYml0KHZhZGRyLCBz aXplKTsKICNlbmRpZiAKLQlyZXR1cm4gMDsKIH0KIAotaW5saW5lIGludCByZWlzZXJmc190b29s c19maW5kX25leHRfemVyb19iaXQoY29uc3Qgdm9pZCAqdmFkZHIsCitpbnQgcmVpc2VyZnNfdG9v bHNfZmluZF9uZXh0X3plcm9fYml0KGNvbnN0IHZvaWQgKnZhZGRyLAogCQkJCQkgICAgIHVuc2ln bmVkIHNpemUsCiAJCQkJCSAgICAgdW5zaWduZWQgb2Zmc2V0KQogewpAQCAtMjQwLDcgKzIzNiw2 IEBAIGlubGluZSBpbnQgcmVpc2VyZnNfdG9vbHNfZmluZF9uZXh0X3plcm9fYml0KGNvbnN0IHZv aWQgKnZhZGRyLAogI2Vsc2UgCiAJcmV0dXJuIHJlaXNlcmZzX3Rvb2xzX2JlX2ZpbmRfbmV4dF96 ZXJvX2JpdCh2YWRkciwgc2l6ZSwgb2Zmc2V0KTsKICNlbmRpZiAKLQlyZXR1cm4gMDsKIH0KICAg ICAKIC8qIFNpZ25hdHVyZSBjaGVja2luZyBmdW5jdGlvbnMgKi8K