<?xml version="1.0" encoding="UTF-8" ?>

<bugzilla version="5.2"
          urlbase="https://bugzilla.altlinux.org/"
          
          maintainer="jenya@basealt.ru"
>

    <bug>
          <bug_id>58058</bug_id>
          
          <creation_ts>2026-02-27 16:55:18 +0300</creation_ts>
          <short_desc>Ошибка при добавлении/удалении сайта из существующего sitelink&apos;а</short_desc>
          <delta_ts>2026-03-11 19:08:46 +0300</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Development</classification>
          <product>Sisyphus</product>
          <component>samba</component>
          <version>unstable</version>
          <rep_platform>x86_64</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P5</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Vladislav Glinkin">glinkinvd</reporter>
          <assigned_to name="Evgeny Sinelnikov">sin</assigned_to>
          <cc>sin</cc>
          
          <qa_contact>qa-sisyphus</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>282879</commentid>
    <comment_count>0</comment_count>
    <who name="Vladislav Glinkin">glinkinvd</who>
    <bug_when>2026-02-27 16:55:18 +0300</bug_when>
    <thetext>Версии пакетов:
samba-dc-client-4.22.8-alt1
samba-dc-4.22.8-alt1

Шаги воспроизведения:
1) # samba-tool sites create TestSite1 &amp;&amp; samba-tool sites create TestSite2 &amp;&amp; samba-tool sites create TestSite3
2) # samba-tool sites sitelinks create TestSiteLink --site TestSite1,TestSite2
3) # samba-tool sites sitelinks add-site TestSiteLink TestSite3

Фактический результат:
ERROR: Error while adding site TestSite3 to site-link TestSiteLink: Expected string as element 0 in list
  File &quot;/usr/lib64/samba-dc/python3.13/samba/netcmd/sitelinks.py&quot;, line 328, in run
    m[&quot;siteList&quot;] = ldb.MessageElement(new_site_list, FLAG_MOD_REPLACE, &quot;siteList&quot;)
                    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Аналогичная проблема проявляется при попытке удаления сайта из существующего SiteLink&apos;а

Помогают изменения:
--- a/usr/lib64/samba-dc/python3.12/samba/netcmd/sitelinks.py  
+++ b/usr/lib64/samba-dc/python3.12/samba/netcmd/sitelinks.py  
@@ -325,7 +325,8 @@ class cmd_site_links_add_site(Command):  
            m = ldb.Message()  
            m.dn = sitelink.dn  

-            m[&quot;siteList&quot;] = ldb.MessageElement(new_site_list, FLAG_MOD_REPLACE, &quot;siteList&quot;)  
+            new_site_list_str = [str(dn) for dn in new_site_list]  
+            m[&quot;siteList&quot;] = ldb.MessageElement(new_site_list_str, FLAG_MOD_REPLACE, &quot;siteList&quot;)  

            samdb.modify(m)  

@@ -401,7 +402,8 @@ class cmd_site_links_delete_site(Command):  
            m = ldb.Message()  
            m.dn = sitelink.dn  

-            m[&quot;siteList&quot;] = ldb.MessageElement(new_site_list, FLAG_MOD_REPLACE, &quot;siteList&quot;)  
+            new_site_list_str = [str(dn) for dn in new_site_list]  
+            m[&quot;siteList&quot;] = ldb.MessageElement(new_site_list_str, FLAG_MOD_REPLACE, &quot;siteList&quot;)  

            samdb.modify(m)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>283651</commentid>
    <comment_count>1</comment_count>
    <who name="Vladislav Glinkin">glinkinvd</who>
    <bug_when>2026-03-11 19:08:46 +0300</bug_when>
    <thetext>Версия пакета: samba-dc-4.22.8-alt2

Ошибка не воспроизводится, проблема исправлена.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>