Bug 31473 - unneeded extra argument in gear-clone
Summary: unneeded extra argument in gear-clone
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: mithraen-build-utils (show other bugs)
Version: unstable
Hardware: all Linux
: P3 minor
Assignee: Nobody's working on this, feel free to take it
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 18:49 MSK by Ivan Zakharyaschev
Modified: 2015-11-12 16:49 MSK (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Zakharyaschev 2015-11-11 18:49:12 MSK
mithraen-build-utils-0.1.27-alt1

http://git.altlinux.org/people/imz/packages/?p=mithraen-build-utils.git;a=commitdiff;h=3d6f5cd38e2feb97babcb37c23c67b7c7d1c043b

--- a/mithraen-build-utils/bin/gear-clone
+++ b/mithraen-build-utils/bin/gear-clone
@@ -16,7 +16,7 @@ type=`girar-get-upload-method "$name" ||:`
 if [ "$type" = "srpm" ]; then
     git clone git://git.altlinux.org/srpms/${name:0:1}/${name}.git
 else
-    girar-clone-build-commit -o girar "$name" "$name" "$name"
+    girar-clone-build-commit -o girar "$name" "$name"
 fi
 
 pushd  "$name" &> /dev/null || exit -1
Comment 1 Ivan Zakharyaschev 2015-11-11 19:58:15 MSK
Explained why in the updated commit message in http://git.altlinux.org/people/imz/packages/?p=mithraen-build-utils.git;a=commitdiff;h=2e77cfd3d17f5808c1f0ac1bacf0f504dac5c514 :

Cf. -- no 3rd argument is used:

$ girar-clone-build-commit -h
Usage:
    girar-clone-build-commit [-h] [-f] [-b *repository*] [-d *local
    destination branch*] [-n *local repository name*] [-o *name*] *name*
    [*local repository name*]

Options:
    -b *repository branch*
        Name of the repository branch. Values: sisyphus|5.1|p5|.. Default is
        sisyphus.

    -d *local destination branch name*
        Name of the checked out branch. Default is master.

    -f  Forcefully remove previous <name>.git and clone over even if
        <name>.git already exists.

    -h  Display this help and exit.

    -n *local repository name*
        Name of the local repository. Default is *name.git*. Can also be
        specified as the second argument.

    -o *remote name*
        Option passed to git-clone. Instead of using the remote name origin
        to keep track of the upstream repository, use *remote name*.

$
Comment 2 Ivan Zakharyaschev 2015-11-11 21:14:47 MSK
Just in case, not to loose and forget this minor clean-up tweak in the code:

task #153043

Please approve if that's OK with you when it is ready.
Comment 3 Denis Smirnov 2015-11-12 12:21:47 MSK
Task #153043 approved
Comment 4 Repository Robot 2015-11-12 12:49:54 MSK
mithraen-build-utils-0.1.27-alt2 -> sisyphus:

* Wed Nov 11 2015 Ivan Zakharyaschev <imz@altlinux> 0.1.27-alt2
- gear-clone: minor tweak (unneeded extra argument in the code removed)
  (ALT#31473).