Bug 45582 - Ошибка поиска requires на aarch64
Summary: Ошибка поиска requires на aarch64
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: rpm-build-lua (show other bugs)
Version: unstable
Hardware: aarch64 Linux
: P5 normal
Assignee: Vladimir D. Seleznev
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-18 23:38 MSK by Alexandr Shashkin
Modified: 2023-03-23 05:54 MSK (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandr Shashkin 2023-03-18 23:38:05 MSK 
На сборочнице при сборке на архитектуре aarch64 возникает ошибка поиска requires следующего вида:

error: line 57: Dependency tokens must begin with alpha-numeric, '_' or '/': /usr/lib/luarocks/rocks-5.3
...
lua5.3(€R€ä£ÿ—á!À‘àª!`‘€Rîµÿ—ó@ù €Rý{¨À_Ö Õý{¾©ý‘óùóªtÀÿ—àªB€R€Rt©ÿ—àª)

Лог: https://git.altlinux.org/tasks/316597/build/1070/aarch64/log

Проводилась проверка на qemu-system-aarch64. Ошибка не воспроизвелась.
Comment 1 Alexandr Shashkin 2023-03-18 23:39:06 MSK 
Чтобы не висело на placeholder.
Comment 2 Dmitry V. Levin 2023-03-18 23:48:31 MSK 
Давайте перевесим куда-нибудь ещё.
Comment 3 Vladimir D. Seleznev 2023-03-19 19:13:01 MSK 
IDK how to fix aarch64, but I briefly took a look at build logs and found unrelated (I guess) bug in deps parsing logic that I fixed at recent release of rpm-build-lua. You can try it, but I'd be really surprised if it solves the problem. If it does not, I guess it is an issue on aarch64 buildnone, and we should contact to the responsible person to get access to the build env to analyse why this happens.
Comment 4 Alexandr Shashkin 2023-03-20 09:35:15 MSK 
Проблема не решена, ошибка воспроизвелась
Comment 5 Egor Ignatov 2023-03-20 20:26:27 MSK 
(In reply to Vladimir D. Seleznev from comment #3)
> IDK how to fix aarch64, but I briefly took a look at build logs and found
> unrelated (I guess) bug in deps parsing logic that I fixed at recent release
> of rpm-build-lua. You can try it, but I'd be really surprised if it solves
> the problem. If it does not, I guess it is an issue on aarch64 buildnone,
> and we should contact to the responsible person to get access to the build
> env to analyse why this happens.

Well, apparently this is not an aarch64 specific problem. It's just a coincidence that this time it happened on aarch64. The problem itself is that lua.req.files does not filter out binary files (in this case, a shared library) that are placed in RPM_LUAMODDIR. So lua.req gets garbage as it tries to parse a binary file. I'm not familiar with lua, so I'm not sure if it's correct to put such files there in the first place, but skipping ELF files [1] should solve the problem.

Also it looks like lua allows single quotes for strings, but lua.req looks for double quotes only.

[1] https://git.altlinux.org/people/egori/packages/?p=rpm-build-lua.git;a=blobdiff;f=lua.req.files;h=52965caacb25c5dd21450b26076c902979d8e0ee;hp=9eefac78d54042c1ec410463696e2e69f74e50ac;hb=ae862ecb4cfaa326d5ec253eba2ceb7b03060646;hpb=bb7101354c16c587ee8c00adda39d630afde7d4c
Comment 6 Alexandr Shashkin 2023-03-22 20:21:00 MSK 
Changes, which had offered by Egor Ignatov, work. See it in a task #317239: https://packages.altlinux.org/ru/tasks/317239/