Attachment 22355 Details for Bug 60849 – etesync-dav: fix get_meta() keys and empty last_modified for radicale 3.8

[patch] etesync-dav: fix get_meta() keys and empty last_modified for radicale 3.8

etesync-dav-radicale-3.8.patch (text/plain), 1.36 KB, created by Vitaly Lipatov on 2026-10-07 13:20:29 MSK

(hide)

Description:

Filename:

MIME Type:

Creator: Vitaly Lipatov

Created: 2026-10-07 13:20:29 MSK

Size: 1.36 KB

patch

obsolete

>--- a/etesync_dav/radicale/storage_etebase_collection.py
>+++ b/etesync_dav/radicale/storage_etebase_collection.py
>@@ -1,3 +1,4 @@
>+from email.utils import formatdate
> import re
> 
> import vobject
>@@ -274,7 +275,12 @@
>                     item.contents["version"][0].value = "3.0"
>         except Exception as e:
>             raise RuntimeError("Failed to parse item %r in %r" % (href, self.path)) from e
>-        last_modified = ""
>+        # radicale 3.8 asserts a non-empty Last-Modified in GET
>+        try:
>+            mtime = etesync_item.meta.get("mtime")
>+        except Exception:
>+            mtime = None
>+        last_modified = formatdate(mtime / 1000 if mtime else None, usegmt=True)
> 
>         return EteSyncItem(
>             collection=self, vobject_item=item, href=href, last_modified=last_modified, etesync_item=etesync_item
>@@ -334,7 +340,11 @@
>             ret = {}
>             meta = self.collection.meta
>             for key in meta.keys():
>-                ret[key] = self.meta_mappings.map_get(meta, key)[1]
>+                # radicale 3.8 expects "NS:tag" property names here
>+                dav_key = self.meta_mappings._mapping_get(key)[0]
>+                if ":" not in dav_key:
>+                    continue
>+                ret[dav_key] = self.meta_mappings.map_get(meta, dav_key)[1]
>             return ret
>         else:
>             meta = self.collection.meta

Actions: View | Diff

Attachments on bug 60849: 22355