Bug 10434
| Summary: | mount-2.12r-alt3 does not pass the "quiet" option to vfat properly | ||
|---|---|---|---|
| Product: | Sisyphus | Reporter: | Sergey Vlasov <vsu> |
| Component: | mount | Assignee: | Dmitry V. Levin <ldv> |
| Status: | CLOSED FIXED | QA Contact: | qa-sisyphus |
| Severity: | major | ||
| Priority: | P3 | CC: | boyarsh, evg, glebfm, lav, ldv, legion, mike, placeholder |
| Version: | unstable | ||
| Hardware: | all | ||
| OS: | Linux | ||
Between alt1 and alt2 (very likely) or between alt2 and alt3? Seems that the problem is caused by the addition of MS_SILENT to kernel headers: http://lkml.org/lkml/2006/3/14/112 Rebuilding mount-2.12r-alt1 package fails for me due to broken chstk on x86_64, but the mount binary which gets built is broken in the same way (eats the "quiet" option). Yes, regression is due to rebuild. Looks like MS_SILENT handling in mount is wrong:
#ifdef MS_SILENT
if (om->mask == MS_SILENT && om->inv) {
mount_quiet = 1;
verbose = 0;
}
i.e. MS_SILENT meaning is reverted.
Cited hunk (while buggy) is not relevant to the problem. I wonder how mount should work when "quiet" option is given. Should it set MS_SILENT (== MS_VERBOSE) flag in mount(2) call? Should it pass "quiet" option to mount(2) call? Возможно ли решить данную неприятную проблему в ближайшие сроки? +1 к предыдущему комментатору. Я бы хотел услышать предложения возможных решений. Disabled MS_SILENT support in 2.12r-alt5. |
Description
Sergey Vlasov 2006-12-15 21:35:30 MSKBetween mount-2.12r-alt1 and mount-2.12r-alt3 handling of the "quiet" mount option for vfat filesystem has been broken (/etc/mtab shows the "quiet" option, but actually it is not enabled). Steps to Reproduce: With mount-2.12r-alt1: # strace -q -e mount -s 1024 mount -t vfat -o quiet /dev/sdb1 /mnt/disk mount("/dev/sdb1", "/mnt/disk", "vfat", MS_MGC_VAL, "quiet") = 0 With mount-2.12r-alt3: # strace -q -e mount -s 1024 mount -t vfat -o quiet /dev/sdb1 /mnt/disk mount("/dev/sdb1", "/mnt/disk", "vfat", MS_MGC_VAL|MS_VERBOSE, "") = 0