Bug 16009

Summary:	/usr/bin/skipstone-bin shouldn't be in the PATH
Product:	Sisyphus	Reporter:	Ivan Zakharyaschev <imz>
Component:	skipstone	Assignee:	Michael Shigorin <mike>
Status:	CLOSED FIXED	QA Contact:	qa-sisyphus
Severity:	minor
Priority:	P2	CC:	mike
Version:	unstable
Hardware:	all
OS:	Linux

Description Ivan Zakharyaschev 2008-06-13 21:07:28 MSD

skipstone-1.0.0-alt2

There is no use in /usr/bin/skipstone-bin being in $PATH, since it mustn't be run directly:

$ skipstone-bin
skipstone-bin: error while loading shared libraries: libgtkembedmoz.so: cannot open shared object file: No such file or directory
$ 

I suggest to hide it somewhere under /usr/lib/.

Comment 1 Michael Shigorin 2008-06-14 12:19:09 MSD

> There is no use in /usr/bin/skipstone-bin being in $PATH
Well, upstream doesn't think so:

--- src/skipstone.in
if [ -f ./skipstone-bin ]; then
        exec ./skipstone-bin $@
else
        exec skipstone-bin $@
fi
---

but I'll do it for you :-)

Comment 2 Michael Shigorin 2008-06-14 23:25:48 MSD

Fixed in 1.0.0-alt3

Comment 3 Ivan Zakharyaschev 2008-06-19 03:11:35 MSD

(In reply to comment #2)
> Fixed in 1.0.0-alt3

Thanks!

Of course you could have decided that it's not a bug. If there are reasonable reasons...

Comment 4 Ivan Zakharyaschev 2008-06-19 03:35:25 MSD

(In reply to comment #1)
> > There is no use in /usr/bin/skipstone-bin being in $PATH
> Well, upstream doesn't think so:

BTW, the thing you quoted must be terrible! For the security. 

> --- src/skipstone.in
> if [ -f ./skipstone-bin ]; then
>         exec ./skipstone-bin $@
> else

Welcome, virus! (or just a thoughtless error)

$ cat > skipstone-bin
echo Hi i am a virus
$ chmod a+x skipstone-bin
$ skipstone 
Hi i am a virus
$ rpm -qf $(which skipstone)
skipstone-1.0.0-alt3
$