Bug 17153

emacs-git-1.5.6.5-alt2

If one creates a file, and uses C-x v v, the file is not committed (although it is added to the index). Another bad consequence of this is that the commit message is lost (and one might have been carefully typing it during C-x v v).

In the example session below, I first (1) just use git to commit a new file "a", and it works, then (2) I try to do the same for a new file "b" by means of Emacs, and it fails, then (3) I show that Emacs works for already registered files (I commit a change to "a" by means of Emacs).

[ivan@dell vc]$ mkdir test-emacs-git
[ivan@dell vc]$ cd test-emacs-git/
[ivan@dell test-emacs-git]$ git init
Initialized empty Git repository in /space/ivan/OUT/bugreports/ALT/vc/test-emacs-git/.git/
[ivan@dell test-emacs-git]$ git-show-branch 
No revs to be shown.
[ivan@dell test-emacs-git]$ echo a > a # (1): I create a new file and commit it.
[ivan@dell test-emacs-git]$ git add a
[ivan@dell test-emacs-git]$ git commit
Created initial commit 5d32cd8: Created a.
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 a
[ivan@dell test-emacs-git]$ git-show-branch 
[master] Created a.
[ivan@dell test-emacs-git]$ emacs b # (2): I create a new file and commit by pressing "C-x v v" in Emacs. No success:
[ivan@dell test-emacs-git]$ git-show-branch 
[master] Created a.
[ivan@dell test-emacs-git]$ git --no-pager status
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	new file:   b
#
[ivan@dell test-emacs-git]$ cat .git/COMMIT_EDITMSG # The new commit message is also lost.
Created a.
# Please enter the commit message for your changes.
# (Comment lines starting with '#' will not be included)
# On branch master
#
# Initial commit
#
# Changes to be committed:
#   (use "git rm --cached <file>..." to unstage)
#
#	new file: a
#
[ivan@dell test-emacs-git]$ cat .git/COMMIT_EDITMSG~

# Please enter the commit message for your changes.
# (Comment lines starting with '#' will not be included)
# On branch master
#
# Initial commit
#
# Changes to be committed:
#   (use "git rm --cached <file>..." to unstage)
#
#	new file: a
#
[ivan@dell test-emacs-git]$ emacs a # (3): I modify the file and commit it by pressing "C-x v v" in Emacs. Successfully:
[ivan@dell test-emacs-git]$ git-show-branch 
[master] Modified a.
[ivan@dell test-emacs-git]$ git --no-pager status # Emacs circumvents index, so "b" is still uncomitted and in the index.
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	new file:   b
#
[ivan@dell test-emacs-git]$ 

Expected behavior: 

Emacs should actually commit new files just like it does for modified files.

Another possibility could be to accept the convention that Emacs doesn't commit new files, but rather adds them to the index. But then the useless request for the commit message should be eliminated in Emacs (the commit message is lost in this case now).