Summary: | doesn't commit newly created files | ||||||
---|---|---|---|---|---|---|---|
Product: | Sisyphus | Reporter: | Ivan Zakharyaschev <imz> | ||||
Component: | emacs-git | Assignee: | Evgenii Terechkov <evg> | ||||
Status: | CLOSED WONTFIX | QA Contact: | qa-sisyphus | ||||
Severity: | enhancement | ||||||
Priority: | P2 | ||||||
Version: | unstable | ||||||
Hardware: | all | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Ivan Zakharyaschev
2008-09-17 00:11:09 MSD
I see. The reason for my problem (that Emacs asked the commit message, and I had the impression that it was going to commit the file because of this request) was that I changed the value of `vc-initial-comment' variable in Emacs: vc-initial-comment's value is t Documentation: *If non-nil, prompt for initial comment when a file is registered. This behavior made some sense for RCS; RCS accepted a comment upon registering a new file, which was interpreted as a "descriptive text" -- from "man ci": If the RCS file does not exist, ci creates it and deposits the contents of the working file as the initial revision (default num- ber: 1.1). The access list is initialized to empty. Instead of the log message, ci requests descriptive text (see -t below). but it turns out, it makes no sense for git. So, this is not a bug report, but a feature request: warn in this situation (when vc-initial-comment is on; or, equivalently, when a comment is passed to `vc-git-register') that the comment will be thrown away. In order to notify the developers actually interested in emacs-git, I'm reassigning the report. But I think the priority of this thing is very low, so just close it, if you are not interested. Created attachment 2919 [details]
vc-git.el warn patch
Простой патч. Делает то, что и требовалось - если при регистраций нам дают комментарий - пишет что коментарий потеряется, т.к. git не поддерживает.
Но вообще vc-git.el всё равно действует "внутри" обёртки vc.el. Вот и в данном случае - vc.el до и после действий vc-git.el пишет свой сообщения, что сводит пользу патча почти на нет - мало кто догадается по такому случаю заглянуть в "*Messages*".
Ещё уточним, что хотелось или хватит? Кстати заранее сообщаю, что общаться с апстримом vc-git.el мне здоровья не хватит.
Посмотрел ещё раз. В общем, там адъ и погибель, всё плохо и надеяться неначто (кроме самого себя) :-) |