Bug 31882

Summary:	empty/absent .gear/rules should be allowed perhaps?
Product:	Sisyphus	Reporter:	Ivan Zakharyaschev <imz>
Component:	perl-Gear-Rules	Assignee:	viy <viy>
Status:	CLOSED FIXED	QA Contact:	qa-sisyphus
Severity:	normal
Priority:	P3	CC:	viy
Version:	unstable
Hardware:	all
OS:	Linux

Description

Ivan Zakharyaschev 2016-03-13 22:05:08 MSK

perl-Gear-Rules-0.17-alt1

Some gear repos have no .gear/rules indeed. And girar-nmu-prepare fails in such cases like this:

Cloning into 'python-module-zc.git'...
remote: Counting objects: 39, done.
remote: Compressing objects: 100% (26/26), done.
remote: Total 39 (delta 8), reused 39 (delta 8)
Receiving objects: 100% (39/39), 6.09 KiB | 0 bytes/s, done.
Resolving deltas: 100% (8/8), done.
Checking connectivity... done.
/tmp/.private/imz/OUT.gits/python-module-zc.git /tmp/.private/imz/OUT.gits
Switched to a new branch 'nmu'
/tmp/.private/imz/OUT.gits
Not a gear repository: gear rules file not found.


But it's a valid gear repo:

python-module-zc.git $ find . ! -path '*/.git/*'
.
./.git
./.gear
./.gear/tags
./.gear/tags/list
./python-module-zc.spec

Comment 1

viy 2016-03-13 22:14:51 MSK

thanks for the report!
But not for tonight. I will look at the code tomorrow.

Comment 2

Ivan Zakharyaschev 2016-03-13 23:03:22 MSK

Thanks! That's not a big problem really, because one can easily perform manually the actions instead of girar-nmu-prepare for a single repo.

$ rpm -q perl-Gear-Rules -l | xargs fgrep -nH 'Not a gear' 2> /dev/null
/usr/share/perl5/Gear/Rules.pm:89:    die "Not a gear repository: gear rules file not found.\n" unless defined $gearrules;

Comment 3

Repository Robot 2016-03-15 01:24:13 MSK

perl-Gear-Rules-0.18-alt1 -> sisyphus:

* Mon Mar 14 2016 Igor Vlasenko <viy@altlinux> 0.18-alt1
- new version (closes: #31882)