Bug 34322
| Summary: | dhcp.c: Fix potentially destructive typo in perform_dhcp() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Sisyphus | Reporter: | Arseny Maslennikov <arseny> | ||||
| Component: | propagator | Assignee: | Anton Farygin <rider> | ||||
| Status: | CLOSED FIXED | QA Contact: | qa-sisyphus | ||||
| Severity: | minor | ||||||
| Priority: | P3 | CC: | klark, mike, rider, sem | ||||
| Version: | unstable | ||||||
| Hardware: | all | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
propagator-20180423-alt1 -> sisyphus: Mon Apr 23 2018 Leonid Krivoshein <klark@altlinux> 20180423-alt1 - New udev control logic imported from make-initrd scripts. - Udev-trigger replaced to udev-settle() in hardware wait loops. - All udev control code moved from init.c to new udev.c module. - Lazy initialization mode support added for work in cooperate with make-initrd: this is experimental future, turned off by default, and also required patched make-initrd-propagator. - disk.c, cdrom.c: 15 attempts with udev-settle() calls. - network.c: bridge up algorithm reviewed, fixed memory leaks. - network.c: 15 attempts to select and wait network interface; - probing.c, probing.h, dhcp.c: small fixes, now black list used. - modules_descr.h, stage1.c: deprecated header, unused code removed. - dhcp.c: fix potentially destructive typo (closes: #34322), thanks to Arseny Maslennikov <arseny@altlinux>. - Workaround race conditions during disks detection (closes: #30315). - Workaround race conditions during bridging up network interfaces, see: https://bugzilla.altlinux.org/show_bug.cgi?id=34347 and https://lists.altlinux.org/pipermail/sysadmins/2018-April/date.html (about "No network Devices found" error message). - Multiple small code improvements, fixes for avoid memory leaks and suppress compiler warnings. |
Description
Arseny Maslennikov 2017-12-12 01:20:38 MSKCreated attachment 7308 [details] патч При сборке пропагатора gcc говорит: dhcp.c: In function 'perform_dhcp': dhcp.c:588:41: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to remove the addressof? [-Wsizeof-pointer-memaccess] memset(&client_addr.sin_addr, 0, sizeof(&client_addr.sin_addr)); Вроде бы ничему оно там не мешает, но всё же.