Bug 34716

Summary:	git-core should depend on perl-Git
Product:	Sisyphus	Reporter:	Andrew Savchenko <bircoph>
Component:	git-core	Assignee:	placeholder <placeholder>
Status:	CLOSED FIXED	QA Contact:	qa-sisyphus
Severity:	normal
Priority:	P3	CC:	cas, glebfm, ldv, mike, placeholder
Version:	unstable
Hardware:	all
OS:	Linux

Description Andrew Savchenko 2018-03-26 19:54:22 MSK

Hi!

Without git-Perl installed git checkout can't function properly:

$ git checkout -p -- rpmrc.in
git: 'add--interactive' is not a git command. See 'git --help'.

With git-Perl installed git checkout -p works as expected.

Comment 1 Dmitry V. Levin 2018-03-26 20:14:44 MSK

Yes, but wouldn't perl-Git pull in a lot of otherwise unneeded perl packages?
Does git-add--interactive worth a mass?

Comment 2 Michael Shigorin 2018-03-28 20:37:24 MSK

(В ответ на комментарий №1)
> Does git-add--interactive worth a mass?
s/Does/Is/
(and the answer is big NO: those who do tricky things can afford to figure
out another package to install or just do "apt-get install git-full",
see also bug 34254 for that matter)

Comment 3 Andrew Savchenko 2018-03-29 00:44:31 MSK

(In reply to comment #2)
> (and the answer is big NO: those who do tricky things can afford to figure
> out another package to install or just do "apt-get install git-full",
> see also bug 34254 for that matter)

1. We don't have git-full, dude.

2. The answer is big YES: -p option of git commit is the standard functionality. When people install git they expect it to work, not to fail on random features.

Per IRL discussion with ldv@ glebfm@ sem@ we'll likely have a package with this stuff available: either in place of present git (and then we'll have git-full for present git), or as an additional meta package.

Comment 4 Michael Shigorin 2018-03-29 15:38:06 MSK

(В ответ на комментарий №3)
> 2. The answer is big YES: -p option of git commit is the standard
> functionality. When people install git they expect it to work,
> not to fail on random features.
You just either:
- spoke for me,
- ruled me out of "people", or
- have been very sloppy with "it".

For one, I don't expect git checkout -p to work with just git-core. :)

Comment 5 Repository Robot 2018-08-03 13:07:13 MSK

git-2.17.1-alt2 -> sisyphus:

Fri Aug 03 2018 Dmitry V. Levin <ldv@altlinux> 2.17.1-alt2
- Renamed git subpackage to git-full (closes: #34254).
- Created new git subpackage that pulls in git-core and perl-Git
  subpackages only (closes: #34716).

Tue May 22 2018 Dmitry V. Levin <ldv@altlinux> 2.17.1-alt1
- 2.16.4 -> 2.17.1.

Tue May 22 2018 Dmitry V. Levin <ldv@altlinux> 2.16.4-alt1
- 2.15.2 -> 2.16.4.

Tue May 22 2018 Dmitry V. Levin <ldv@altlinux> 2.15.2-alt1
- 2.14.4 -> 2.15.2.

Tue May 22 2018 Dmitry V. Levin <ldv@altlinux> 2.14.4-alt1
- 2.13.7 -> 2.14.4.

Tue May 22 2018 Dmitry V. Levin <ldv@altlinux> 2.13.7-alt1
- 2.12.5 -> 2.13.7.

Fri Sep 22 2017 Dmitry V. Levin <ldv@altlinux> 2.12.5-alt1
- 2.11.4 -> 2.12.5.

Fri Sep 22 2017 Dmitry V. Levin <ldv@altlinux> 2.11.4-alt1
- 2.10.5 -> 2.11.4.

Comment 6 Michael Shigorin 2018-08-03 14:37:33 MSK

Ура, спасибо!