| Summary: | girar-task-make-index-html: do not rely on yastatic.net, embed css instead | ||
|---|---|---|---|
| Product: | Infrastructure | Reporter: | Dmitry V. Levin <ldv> |
| Component: | girar | Assignee: | placeholder <placeholder> |
| Status: | NEW --- | QA Contact: | Andrey Cherepanov <cas> |
| Severity: | normal | ||
| Priority: | P5 | CC: | arseny, glebfm, ldv, rider |
| Version: | unspecified | ||
| Hardware: | all | ||
| OS: | Linux | ||
(In reply to Dmitry V. Levin from comment #0) > girar-task-make-index-html generates the following: > > <head> > <meta name="robots" content="index, nofollow"/> > <link href="https://yastatic.net/bootstrap/3.3.4/css/bootstrap.min.css" > rel="stylesheet" /> > <title>Task #$id for $repo by $owner</title> > > This is fragile, css should be local, there should be no reliance on > yastatic.net. Even more, the first sub-element of the document head is not "<meta charset="utf-8" />". |
girar-task-make-index-html generates the following: <head> <meta name="robots" content="index, nofollow"/> <link href="https://yastatic.net/bootstrap/3.3.4/css/bootstrap.min.css" rel="stylesheet" /> <title>Task #$id for $repo by $owner</title> This is fragile, css should be local, there should be no reliance on yastatic.net.