Bug 4570

Summary:

Render packaging of %_localstatedir/scrollkeeper/* as error

Product:

Sisyphus

Reporter:

Andrei Bulava <abulava>

Component:

sisyphus

Assignee:

Alexey Gladkov <legion>

Status:

CLOSED FIXED

QA Contact:

qa-sisyphus

Severity:

enhancement

Priority:

CC:

glebfm, inger, ktirf, ldv, mike, placeholder, viy

Version:

unstable

Hardware:

all

OS:

Linux

Attachments:

Description	Flags
iniital implementation	legion: review-
sisyphus_check-0.7.13-alt-check-locales.patch	none

Description

Andrei Bulava 2004-07-01 10:03:09 MSD

Recently I found that anjuta was packaged with files under
%_localstatedir/scrollkeeper/ (check
http://lists.altlinux.ru/pipermail/devel/2004-June/012095.html). As I understood
such files were maintained by scrollkeeper itself and wouldn't belong to any
package.

aris@ considered this packaging error was worth adding new check to
sisyphus_check detecting somebody's try to package
%_localstatedir/scrollkeeper/* files (check
http://lists.altlinux.ru/pipermail/devel/2004-June/012097.html).

Comment 1

Dmitry V. Levin 2004-07-01 19:03:19 MSD

I'd also add same checks for other locale directories.

Comment 2

Dmitry V. Levin 2004-08-31 21:22:33 MSD

Anybody volunteer to implement this?

Comment 3

Alexey Gladkov 2004-09-01 15:03:04 MSD

I can do this. But I must know what locale directories should be checked.

Comment 4

Alexey Gladkov 2005-09-06 19:10:52 MSD

I shall take care of it.

Comment 5

Alexey Gladkov 2005-09-06 20:36:18 MSD

Created attachment 1093 [details]
iniital implementation

Comment 6

Alexey Gladkov 2005-09-07 02:00:51 MSD

Created attachment 1095 [details]
sisyphus_check-0.7.13-alt-check-locales.patch

Comment 7

Michael Shigorin 2006-09-28 02:07:22 MSD

was it merged?

Comment 8

Alexey Rusakov 2007-07-24 13:35:30 MSD

The patch seems to be merged, but the matter of the bug is still there. We need
a patch for scrollkeeper files (maybe I will make it myself, if I have time).

Comment 9

Michael Shigorin 2007-11-10 20:30:49 MSK

Seems like scrollkeeper is drifting to being obsolete?

Comment 10

Alexey Rusakov 2007-11-10 20:44:33 MSK

Aha. But Scrollkeeper files will last longer than Scrollkeeper itself, since
Rarian supports Scollkeeper databases.

Comment 11

Alexey Rusakov 2009-03-20 05:10:37 MSK

Не знаю, что делать с этим багом. Может, репокопный тест сотворить на эту тему?

Comment 12

viy 2009-03-20 09:42:37 MSK

В сизифе нет пакетов where filename glob '/var/lib/scrollkeeper/*' ---
select pkgid, filename from rpm_files where filename glob '/var/lib/scrollkeeper/*';
<empty>
но похоже в sisyphus_check это тоже не проверяется -
grep -r scroll /etc/sisyphus_check/check.d/
<empty>
для гарантии можно написать тест repocop.
нужно только, чтобы кто-то компетентный написал 
фрагмент полиси на wiki, чтобы тест репокопа ссылался на нее
при ругани на провинившийся пакет.

Comment 13

Alexey Rusakov 2009-03-20 12:36:36 MSK

Я бы не заморачивался. Scrollkeeper отошёл в прошлое, генерация его временных файлов, соответственно, тоже. Сейчас эти файлы создавать, как я понимаю, просто нечем.