Summary: | soundwrapper misuse? | ||
---|---|---|---|
Product: | Sisyphus | Reporter: | Michael Shigorin <mike> |
Component: | psi | Assignee: | Anton Farygin <rider> |
Status: | CLOSED WONTFIX | QA Contact: | qa-sisyphus |
Severity: | minor | ||
Priority: | P2 | CC: | rider |
Version: | unstable | ||
Hardware: | all | ||
OS: | Linux |
$ rpm -ql sound_handler /usr/bin/play_wrapper.sh /usr/bin/sound_wrapper.sh sound_handler includes two various wrapper scripts. One for wrapping whole apps and one for wrapping "play" calls. Psi uses external "play" calls to play its sounds, so, I thought that it *is* common practice to wrap such call in play_wrapper.sh. After all, it exists for something %) closing closing |
> - fixed "play" calls to use sound_handler wrapper scripts Umm... common practice is wrapping the whole app (via menufile) :-) Although each approach does have its pros and cons *maybe* holding to the practice is worth it.