Bug 52429

Summary:	Аварийный останов при запуске без параметров
Product:	Sisyphus	Reporter:	ruslandh <ruslandh>
Component:	apa	Assignee:	qualimock <qualimock>
Status:	CLOSED FIXED	QA Contact:	qa-sisyphus
Severity:	normal
Priority:	P5	CC:	cas, oleg, qualimock, rirusha, ruslandh
Version:	unstable
Hardware:	all
OS:	Linux

Description ruslandh 2024-12-15 09:39:57 MSK

apa repo
A subcommand for working with repositories.

Available commands:
  list - Show enabled sources in system.
  add - Add source to sources list. Sources format described at apt-repo(8).
  add-aides - Add Aides Repo to sources list.
  remove - Remove source from sources list.
  remove-aides - Remove Aides Repo from sources list.

** (apa:64217): CRITICAL **: 09:38:05.956: gee_collection_to_array: assertion 'self != NULL' failed

** (apa:64217): CRITICAL **: 09:38:05.957: gee_collection_to_array: assertion 'self != NULL' failed
**
apa:ERROR:../src/apa.vala:163:apa_run_co: code should not be reached
Bail out! apa:ERROR:../src/apa.vala:163:apa_run_co: code should not be reached
Аварийный останов

Comment 1 ruslandh 2024-12-15 11:42:13 MSK

Посмотрел по другим функциям. Там аналогично:

# apa kernel
A subcommand for working with the kernel.

Available commands:
  upgrade - Upgrade kernel.
  list - Print list of available kernels.

** (apa:156275): CRITICAL **: 11:10:04.246: gee_collection_to_array: assertion 'self != NULL' failed

** (apa:156275): CRITICAL **: 11:10:04.246: gee_collection_to_array: assertion 'self != NULL' failed
**
apa:ERROR:../src/apa.vala:106:apa_run_co: code should not be reached
Bail out! apa:ERROR:../src/apa.vala:106:apa_run_co: code should not be reached


ИМХО - нет общей функции обработки ошибок

Консольное приложение не должно выдавать свои "кишки" без особого ключа, или выдавать их по минимуму - только самое необходимое.
При неправильном вводе команды пользователем должна идти  или справка, или какое-то стандартное сообщение, типа  
nrecognized command in fff arg(s)

Comment 2 ruslandh 2024-12-15 11:43:05 MSK

unrecognized command in fff arg(s)

Comment 3 Олег Щавелев 2024-12-15 15:43:07 MSK

Версия.

➜  ~ apa version  
apa 0.1.0

➜  ~ apa repo --help 
A subcommand for working with repositories.

Available commands:
  list - Show enabled sources in system.

Вводим:
➜  ~ apa repo list   
**
apa:ERROR:../src/command.vala:98:apa_command_fill_by_args_handler_with_args: assertion failed: (args_handler.args.size != 0)
Bail out! apa:ERROR:../src/command.vala:98:apa_command_fill_by_args_handler_with_args: assertion failed: (args_handler.args.size != 0)
[1]    12666 IOT instruction  apa repo list
➜  ~ apt-repo     
rpm [alt] http://ftp.altlinux.org/pub/distributions/ALTLinux Sisyphus/x86_64 classic
rpm [alt] http://ftp.altlinux.org/pub/distributions/ALTLinux Sisyphus/x86_64-i586 classic
rpm [alt] http://ftp.altlinux.org/pub/distributions/ALTLinux Sisyphus/noarch classic

Comment 4 Vladimir Romanov 2024-12-15 16:24:09 MSK

Исправлено на момент последнего коммита в репозитории.

Comment 5 ruslandh 2024-12-15 16:25:43 MSK

Возможно связано, что у меня:
$ apt-repo
rpm [alt] file:/mnt/Arhiv/Sisyphus/ x86_64 classic gostcrypto
rpm [alt] file:/mnt/Arhiv/Sisyphus/ x86_64-i586 classic
rpm [alt] file:/mnt/Arhiv/Sisyphus/ noarch classic
rpm file:/mnt/Arhiv/Ximper/Ximper_repo/ x86_64 addon
rpm file:/mnt/Arhiv/Ximper/Ximper_repo/ noarch addon

Comment 6 ruslandh 2024-12-15 16:26:52 MSK

apa version. Same as `apa --version'.
[writer@Newgrad ~]$ apa version
apa 0.1.0

Comment 7 ruslandh 2024-12-15 16:29:04 MSK

$ rpm -q apa
apa-0.1.0.alpha-alt1.x86_64

Comment 8 Олег Щавелев 2024-12-15 19:17:38 MSK

qualimock@altlinux.org, исправление в ветки upstream:
https://github.com/alt-gnome/apa/releases/tag/v0.1.1.alpha

Прошу собрать в Сизиф, версию 0.1.1.alpha