Bug 16723 - unsafe bash expression
Summary: unsafe bash expression
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: sound-scripts (show other bugs)
Version: unstable
Hardware: all Linux
: P2 normal
Assignee: Valery Inozemtsev
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 13:19 MSD by Ivan Zakharyaschev
Modified: 2008-09-29 17:07 MSD (History)
2 users (show)

See Also:

Attachments
sound-scripts-0.51-correct-bash.patch (737 bytes, patch)
2008-08-18 13:19 MSD, Ivan Zakharyaschev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Zakharyaschev 2008-08-18 13:19:09 MSD 
Created attachment 2790 [details]
sound-scripts-0.51-correct-bash.patch

sound-scripts 20070530:0.51-alt1

The attached patch makes the script better; this way it is more correct (e.g., in case of special chars in the pathname) and hence works more predictable in strange situations.

(I stumbled upon this problem when trying to "source" the script from another bash.)
Comment 1 Michael Shigorin 2008-08-18 14:14:11 MSD 
reassign
Comment 2 Michael Shigorin 2008-09-22 22:08:35 MSD 
applied to 0.52-alt1, thanks