Bug 33383 - [PATCH] task approve might result in non-zero exit code for no good reason
Summary: [PATCH] task approve might result in non-zero exit code for no good reason
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: git.altlinux.org (show other bugs)
Version: unspecified
Hardware: all Linux
: P3 normal
Assignee: Dmitry V. Levin
QA Contact: Andrey Cherepanov
URL: http://git.altlinux.org/people/mike/p...
Keywords: regression
Depends on:
Blocks:
 
Reported: 2017-04-17 15:50 MSK by Michael Shigorin
Modified: 2017-04-17 18:50 MSK (History)
1 user (show)

See Also:


Attachments
fix exit code semantics (927 bytes, patch)
2017-04-17 16:00 MSK, Michael Shigorin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Shigorin 2017-04-17 15:50:32 MSK
Looks like this commit involuntarily broke exit semantics by stuffing another command before the call: http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=74440ef665bf5f39c7cb69186d87f4c7ffc111f4

Hit that by attempting this:

  ssh git.alt task approve 181832 400 && ssh git.alt task approve 181832 500

The first command returned errorlevel 1 despite the {,sub}task existing with no other reasonable obstacles in sight.

The attached patch should fix that by restoring the previous semantics.
Comment 1 Michael Shigorin 2017-04-17 16:00:06 MSK
Created attachment 7060 [details]
fix exit code semantics

Duplicating patch reference from URL just in case:
http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=bc9730be5bd6d3e50d5c4d3102f388bf88b623d5
Comment 2 Dmitry V. Levin 2017-04-17 16:16:43 MSK
Applied a simplified edition of your patch, thanks!
Comment 3 Michael Shigorin 2017-04-17 18:50:14 MSK
VERIFIED THANKS
:)