Bug 33977 - missing Requires: python3-module-sip
Summary: missing Requires: python3-module-sip
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: python3-module-PyQt5 (show other bugs)
Version: unstable
Hardware: all Linux
: P3 normal
Assignee: Vitaly Lipatov
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-06 16:17 MSK by Ivan Zakharyaschev
Modified: 2017-10-06 23:56 MSK (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Zakharyaschev 2017-10-06 16:17:07 MSK
5.9-alt1

missing Requires: python3-module-sip:

-bash-4.3$ apt-repo --hsh-apt-config=/home/imz/.hasher/sisyphus/apt.conf test '' python3-module-PyQt5 && { hsh-run --mount=/proc,/dev/pts /usr/lib/rpm/check-python3-provs-importable.sh python3-module-PyQt5; echo $?; }
...
PyQt5.QtBluetooth
PyQt5.QtCore
PyQt5.QtDBus
PyQt5.QtDesigner
PyQt5.QtGui
PyQt5.QtHelp
PyQt5.QtLocation
PyQt5.QtMultimedia
PyQt5.QtMultimediaWidgets
PyQt5.QtNetwork
PyQt5.QtNfc
PyQt5.QtOpenGL
PyQt5.QtPositioning
PyQt5.QtPrintSupport
PyQt5.QtQml
PyQt5.QtQuick
PyQt5.QtQuickWidgets
PyQt5.QtSensors
PyQt5.QtSerialPort
PyQt5.QtSql
PyQt5.QtSvg
PyQt5.QtTest
PyQt5.QtWebKit
PyQt5.QtWebKitWidgets
PyQt5.QtWebSockets
PyQt5.QtWidgets
PyQt5.QtX11Extras
PyQt5.QtXml
PyQt5.QtXmlPatterns
PyQt5._QOpenGLFunctions_2_0
PyQt5._QOpenGLFunctions_2_1
PyQt5._QOpenGLFunctions_4_1_Core
PyQt5.pylupdate
PyQt5.pylupdate_main
PyQt5.pyrcc
PyQt5.pyrcc_main
PyQt5.uic.Loader.loader
PyQt5.uic.Loader.qobjectcreator
PyQt5.uic.pyuic
123
-bash-4.3$ hsh-shell --mount=/proc,/dev/pts
[builder@localhost .in]$ python3 -c 'import PyQt5.QtGui'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named 'sip'
[builder@localhost .in]$ rpm -q python3-module-PyQt5
python3-module-PyQt5-5.9-alt1.x86_64
[builder@localhost .in]$ 

Cf. the last improvement in PyQt4 -- http://git.altlinux.org/gears/p/python-module-PyQt4.git?p=python-module-PyQt4.git;a=commitdiff;h=d82f22143a2d35f400f64e58e25fcf4550124fff :

+%define sipver2 %(rpm -q --qf '%%{VERSION}' python-module-sip)
+Requires: python-module-sip = %sipver2
+
 %if_with python3
-BuildRequires(pre): rpm-build-python3
+BuildRequires(pre): rpm-build-python3 python3-module-sip-devel
 #BuildRequires: python3-devel python3-module-sip-devel
 #BuildPreReq: python3-module-dbus-devel
 #BuildPreReq: python3-module-qscintilla2-qt4-devel
 #BuildPreReq: python3-module-sip-devel
+%define sipver3 %(rpm -q --qf '%%{VERSION}' python3-module-sip)
 %endif
 
 %description
-Python bindings for the Qt C++ class library.  Also includes a PyQt4 backend
-code generator for Qt Designer.
+Python bindings for the Qt4 C++ class library.  Also includes a PyQt4 backend
+code generator for Qt4 Designer.
 
 %if_with python3
 %package -n python3-module-%oname
-Summary: Python 3 bindings for Qt
+Summary: Python 3 bindings for Qt4
 Group: Development/Python3
 %add_python3_req_skip Compiler
+Requires: python3-module-sip = %sipver3
Comment 1 Vitaly Lipatov 2017-10-06 17:11:41 MSK
Это, конечно, круто, прислать мне в качестве примера исправления из PyQt4, которые сделаны по образцу моих исправлений в PyQt5 :)
Comment 2 Vitaly Lipatov 2017-10-06 17:13:53 MSK
> 5.9-alt1
> missing Requires: python3-module-sip:
насколько я понимаю, я добавил эту зависимость в 5.9-alt2.
Comment 3 Vitaly Lipatov 2017-10-06 17:15:12 MSK
А, он ещё собирается :)
#190385 BUILDING #1.2 [locked] sisyphus python-module-PyQt5.git=5.9-alt2
Comment 4 Ivan Zakharyaschev 2017-10-06 23:44:25 MSK
(In reply to comment #1)
> Это, конечно, круто, прислать мне в качестве примера исправления из PyQt4,
> которые сделаны по образцу моих исправлений в PyQt5 :)

:)))

Когда переситал все комментарии, понял, кто на самом деле что предложил. Спасибо за исправление!