Bug 36747 - alsa.pc: empty Cflags
Summary: alsa.pc: empty Cflags
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: libalsa-devel (show other bugs)
Version: unstable
Hardware: all Linux
: P3 normal
Assignee: Michael Shigorin
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-14 12:56 MSK by Yuri N. Sedunov
Modified: 2019-05-14 14:05 MSK (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri N. Sedunov 2019-05-14 12:56:45 MSK 
Надо решить откатывать ли этот коммит, или чинить сломавшиеся пакеты.

author	Takashi Iwai <tiwai@suse.de>	
Tue, 26 Mar 2019 13:48:23 +0000 (14:48 +0100)
committer	Takashi Iwai <tiwai@suse.de>	
Thu, 28 Mar 2019 07:01:34 +0000 (08:01 +0100)
commit	fc0e54c3cc6ad48d12d2cdad18df4473c559a448
tree	86195a1c36b7ae63995edfcb084e54e3f607024e	tree | snapshot
parent	f9056d013cf1cea70f6819cc7e2e7b689dbb3fb7	commit | diff
Drop  -I$includedir/alsa  from  alsa.pc

We  used  to  put  the  additional  include  path  $includedir/alsa  in
pkgconfig  just  because  some  applications  have  included  asoundlib.h
like
    #include  <asoundlib.h>
although  the  canonical  form  should  be
    #include  <alsa/asoundlib.h>

However,  adding  this  include  path  is  significantly  dangerous  due  to
possible  conflicts  of  file  names  like  version.h.    It's  already  the
reason  to  discourage  people  using  alsa.pc  for  the  packages.

In  this  patch,  the  additional  include  path  from  alsa.pc  is  dropped
finally.    At  the  same  time,  as  a  rescue  plan  for  the  programs
including  via  <asoundlib.h>,  a  stub  header  file  is  provided  in
include/sound/asoundlib.h.    It  just  includes  alsa/asoundlib.h  with  a
warning  to  suggest  for  replacing  with  alsa/asoundlib.h.
Actually  this  is  the  same  file  as  we  install  into  sys/asoundlib.h,  so
the  whole  changes  are  very  minimal  here.
Comment 1 Michael Shigorin 2019-05-14 14:03:53 MSK 
Всего по этой причине сломалось десять пакетов:

---
$ grep -A1 unpackaged /beehive/logs/Sisyphus-x86_64/latest/success/libalsa-1:1.1.9-alt1
warning: Installed (but unpackaged) file(s) found:
    /usr/include/asoundlib.h
--- ldv@

Должно быть исправлено в 1.1.9-alt2:

* Tue May 14 2019 Dmitry V. Levin <ldv@altlinux> 1:1.1.9-alt2
- NMU.
- Packaged /usr/include/asoundlib.h introduced in 1.1.9 to fix builds
  of packages that use asoundlib.h header file.
Comment 2 Dmitry V. Levin 2019-05-14 14:05:16 MSK 
Исправлено в 1.1.9-alt2.