This patch allows checking of separate RPM's, and should be useful for ordinal mantainers who sends single package at once. =================================================== --- /usr/bin/sisyphus_check.orig 2004-07-15 23:45:35 +0400 +++ /usr/bin/sisyphus_check 2004-12-09 01:40:20 +0300 @@ -424,16 +424,22 @@ # quick arg check. local d for d in "$@"; do - [ -d "$d" ] || { FileError "$d: not a directory"; rc=1; continue; } + [ -d "$d" ] && continue + [ -f "$d" ] || { FileError "$d: not a directory nor regular file"; rc= 1; continue; } + case "$d" in + *.src.rpm ) continue ;; + esac + FileError "$d: regular file but not source RPM"; rc=1; continue done [ $rc = 0 ] || return $rc init_check || Fatal "init_check failed." for d in "$@"; do - [ -d "$d" ] || { FileError "$d: not a directory"; rc=1; continue; } + [ -d "$d" -o -f "$d" ] || { FileError "$d: not a directory nor regular file"; rc=1; continue; } local f for f in "$d"/*.rpm; do + [ -f "$d" ] && f="$d" if [ ! -f "$f" ]; then [ "$f" != "$d/*.rpm" ] || continue FileError "not a regular file" "$f" @@ -601,6 +607,8 @@ rc=1 [ -z "$fast_check" ] || continue fi + + [ "$f" = "$d" ] && break done done Steps to Reproduce: 1. sisyphus_check my.src.rpm && echo Ok || echo Bad Actual Results: ERROR: my.src.rpm: not a directory Bad Expected Results: Ok
Please, create new attachment for your patch.
Created attachment 668 [details] This patch allows processing of separate packages as well as entire directories
Created attachment 803 [details] The same idea in new implementation ;-) Теперь в командной строке можно указывать как каталоги, так и отдельные RPM-файлы. Удобно для тех, кто собирает и проверяет пакеты поштучно. Предыдущий патч разрешал указывать только src.rpm, но ругался на бинарные. Теперь допустимы и те, и те :-)))
Created attachment 807 [details] bugfix'd version of previous patch Предыдущая версия патча содержала крошечную ошибку - полностью игнорировала RPM-файлы ;-((( Исправлено.
I'll implement it but in different way.
"I did it myyyyyy waaaaaay" (c) Frank Sinatra ииии? :)
Implemented in sisyphus_check-0.7.12-alt1