Bug 8313 - danger or forgotten function
Summary: danger or forgotten function
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: guile16 (show other bugs)
Version: unstable
Hardware: all Linux
: P2 normal
Assignee: Nobody's working on this, feel free to take it
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-21 16:28 MSD by inger@altlinux.org
Modified: 2008-04-25 16:53 MSD (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description inger@altlinux.org 2005-10-21 16:28:35 MSD 
There are danger or forgotten function in script.c with potential buffer overflow.
You should remove or rewrite it:
--
char *
scm_find_executable (const char *name)
{
  char tbuf[MAXPATHLEN];
....
 if ((fgetc (f) == '#') && (fgetc (f) == '!'))
    {
      while (1)
        switch (tbuf[i++] = fgetc (f))
          {
....

--