ALT Linux Bugzilla
– Attachment 7060 Details for
Bug 33383
[PATCH] task approve might result in non-zero exit code for no good reason
New bug
|
Search
|
[?]
|
Help
Register
|
Log In
[x]
|
Forgot Password
Login:
[x]
|
EN
|
RU
[patch]
fix exit code semantics
0001-girar-task-approve-fixed-errorlevel-returned.patch (text/plain), 927 bytes, created by
Michael Shigorin
on 2017-04-17 16:00:06 MSK
(
hide
)
Description:
fix exit code semantics
Filename:
MIME Type:
Creator:
Michael Shigorin
Created:
2017-04-17 16:00:06 MSK
Size:
927 bytes
patch
obsolete
>From bc9730be5bd6d3e50d5c4d3102f388bf88b623d5 Mon Sep 17 00:00:00 2001 >From: Michael Shigorin <mike@altlinux.org> >Date: Mon, 17 Apr 2017 15:35:20 +0300 >Subject: [PATCH] girar-task-approve: fixed errorlevel returned > >A 'task approve' command would return non-zero errorlevel, >surprisingly, due to changed exit semantics; restore those >broken by commit g74440ef. > >Fixes: 74440ef665bf5f39c7cb69186d87f4c7ffc111f4 >--- > bin/girar-task-approve | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/bin/girar-task-approve b/bin/girar-task-approve >index 75cd47c..0924222 100755 >--- a/bin/girar-task-approve >+++ b/bin/girar-task-approve >@@ -31,8 +31,9 @@ for i in $(gear_nums); do > [ -d "acl/$i" ] && [ 'all' = "$num" -o "$i" = "$num" ] || > continue > touch "acl/$i/$GIRAR_USER" >+ rc=$? > [ 'all' = "$num" ] || >- exit >+ exit $rc > done > [ 'all' = "$num" ] || > fatal "task #$id: subtask #$num not found" >-- >2.10.2 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=7060">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 33383
: 7060
