Bug 16723

Summary:

unsafe bash expression

Product:

Sisyphus

Reporter:

Ivan Zakharyaschev <imz>

Component:

sound-scripts

Assignee:

Valery Inozemtsev <shrek>

Status:

CLOSED FIXED

QA Contact:

qa-sisyphus

Severity:

normal

Priority:

CC:

mike, shrek

Version:

unstable

Hardware:

all

OS:

Linux

Attachments:

Description	Flags
sound-scripts-0.51-correct-bash.patch	none

Description Ivan Zakharyaschev 2008-08-18 13:19:09 MSD

Created attachment 2790 [details]
sound-scripts-0.51-correct-bash.patch

sound-scripts 20070530:0.51-alt1

The attached patch makes the script better; this way it is more correct (e.g., in case of special chars in the pathname) and hence works more predictable in strange situations.

(I stumbled upon this problem when trying to "source" the script from another bash.)

Comment 1 Michael Shigorin 2008-08-18 14:14:11 MSD

reassign

Comment 2 Michael Shigorin 2008-09-22 22:08:35 MSD

applied to 0.52-alt1, thanks