Bug 24985

Summary:	FR: Remove assertion from gtkrecentmanager.c
Product:	Sisyphus	Reporter:	Ivan A. Melnikov <iv>
Component:	libgtk+2	Assignee:	Yuri N. Sedunov <aris>
Status:	CLOSED NOTABUG	QA Contact:	qa-sisyphus
Severity:	normal
Priority:	P3	CC:	aris, lav, mike
Version:	unstable
Hardware:	all
OS:	Linux
Bug Depends on:
Bug Blocks:	24586

Description

Ivan A. Melnikov 2011-01-28 16:08:48 MSK

In absence of gnome-icon-theme several GTK application abort with the following diagnostics:

** Gtk:ERROR:gtkrecentmanager.c:1942:get_icon_fallback: assertion failed: (retval != NULL)

(see #24972, #24586 to name a few).

I looked at libgtk+2 sources and it seems to me that this assertion is completely useless and can be safely deleted.

The only effect of this deletion is that get_icon_fallback will be able NULL, which leads to returning NULL from gtk_recent_info_get_icon. But it is documented that NULL might be returned from gtk_recent_info_get_icon, and this case is handled gracefully in other parts of libgtk+2.

So I propose deleting assertion from gtkrecentmanager.c, line 1942.

Comment 1

Yuri N. Sedunov 2011-01-28 18:26:47 MSK

Видать, старый evince и inkscape пытаются использовать значки, не входящие в стандартный набор GTK. Если хотите обойтись без gnome-icon-theme, надо исправить эти приложения.

Comment 2

Michael Shigorin 2011-03-15 19:17:20 MSK

Так это было FIXED или NOTABUG?