Bug 24985 - FR: Remove assertion from gtkrecentmanager.c
Summary: FR: Remove assertion from gtkrecentmanager.c
Status: CLOSED NOTABUG
Alias: None
Product: Sisyphus
Classification: Development
Component: libgtk+2 (show other bugs)
Version: unstable
Hardware: all Linux
: P3 normal
Assignee: Yuri N. Sedunov
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks: 24586
  Show dependency tree
 
Reported: 2011-01-28 16:08 MSK by Ivan A. Melnikov
Modified: 2021-08-20 12:02 MSK (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan A. Melnikov 2011-01-28 16:08:48 MSK 
In absence of gnome-icon-theme several GTK application abort with the following diagnostics:

** Gtk:ERROR:gtkrecentmanager.c:1942:get_icon_fallback: assertion failed: (retval != NULL)

(see #24972, #24586 to name a few).

I looked at libgtk+2 sources and it seems to me that this assertion is completely useless and can be safely deleted.

The only effect of this deletion is that get_icon_fallback will be able NULL, which leads to returning NULL from gtk_recent_info_get_icon. But it is documented that NULL might be returned from gtk_recent_info_get_icon, and this case is handled gracefully in other parts of libgtk+2.

So I propose deleting assertion from gtkrecentmanager.c, line 1942.
Comment 1 Yuri N. Sedunov 2011-01-28 18:26:47 MSK 
Видать, старый evince и inkscape пытаются использовать значки, не входящие в стандартный набор GTK. Если хотите обойтись без gnome-icon-theme, надо исправить эти приложения.
Comment 2 Michael Shigorin 2011-03-15 19:17:20 MSK 
Так это было FIXED или NOTABUG?