Bug 33383

Summary:

[PATCH] task approve might result in non-zero exit code for no good reason

Product:

Infrastructure

Reporter:

Michael Shigorin <mike>

Component:

git.altlinux.org

Assignee:

Dmitry V. Levin <ldv>

Status:

CLOSED FIXED

QA Contact:

Andrey Cherepanov <cas>

Severity:

normal

Priority:

CC:

glebfm

Version:

unspecified

Keywords:

regression

Hardware:

all

OS:

Linux

URL:

http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=bc9730be5bd6d3e50d5c4d3102f388bf88b623d5

Attachments:

Description	Flags
fix exit code semantics	none

Description

Michael Shigorin 2017-04-17 15:50:32 MSK

Looks like this commit involuntarily broke exit semantics by stuffing another command before the call: http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=74440ef665bf5f39c7cb69186d87f4c7ffc111f4

Hit that by attempting this:

  ssh git.alt task approve 181832 400 && ssh git.alt task approve 181832 500

The first command returned errorlevel 1 despite the {,sub}task existing with no other reasonable obstacles in sight.

The attached patch should fix that by restoring the previous semantics.

Comment 1

Michael Shigorin 2017-04-17 16:00:06 MSK

Created attachment 7060 [details]
fix exit code semantics

Duplicating patch reference from URL just in case:
http://git.altlinux.org/people/mike/packages/?p=girar.git;a=commitdiff;h=bc9730be5bd6d3e50d5c4d3102f388bf88b623d5

Comment 2

Dmitry V. Levin 2017-04-17 16:16:43 MSK

Applied a simplified edition of your patch, thanks!

Comment 3

Michael Shigorin 2017-04-17 18:50:14 MSK

VERIFIED THANKS
:)