Bug 18785 - breaks on nil body
Summary: breaks on nil body
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: yabeda (show other bugs)
Version: unstable
Hardware: all Linux
: P2 normal
Assignee: Michael Shigorin
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-09 17:07 MSK by Michael Shigorin
Modified: 2011-01-09 16:25 MSK (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Shigorin 2009-02-09 17:07:44 MSK 
# yabeda
["VPS 1106: PRIVVMPAGES failcnt -> 2!",
 "16:00:21 09-02-2009: CT 1106 on ***: PRIVVMPAGES failcnt changed from 0 to 2."]
/usr/share/ruby/vendor_ruby/1.8/tmail/mail.rb:563:in `quote': can't convert nil into String (TypeError)
        from /usr/share/ruby/vendor_ruby/1.8/tmail/mail.rb:563:in `read_multipart'
        from /usr/share/ruby/vendor_ruby/1.8/tmail/mail.rb:552:in `parse_body_0'
        from /usr/share/ruby/vendor_ruby/1.8/tmail/mail.rb:534:in `parse_body'
        from /usr/share/ruby/vendor_ruby/1.8/tmail/mail.rb:488:in `body='
        from /usr/sbin/yabeda:361:in `vsePloho'
        from /usr/sbin/yabeda:403:in `main'
        from /usr/sbin/yabeda:420

Fixing vsePloho on line 361 (s/nil/""/) doesn't actually fix (or change) anything.

It's ruby-tmail-1.2.3.1-alt1 (currently in Sisyphus).
Comment 1 Sir Raorn 2009-02-09 18:27:43 MSK 
Строку 361 надо убитьнах и никогда-никогда так больше не делать.
Comment 2 Michael Shigorin 2009-05-26 17:15:08 MSD 
Дядьки, сделайте или хоть скажите, как надо делать ;-)
Comment 3 Konstantin Pavlov 2009-07-31 13:18:17 MSD 
Fixed in upstream, will be available shortly in Sisyphus.
Comment 4 Michael Shigorin 2009-07-31 15:41:44 MSD 
Ур-ра!  Дорогой апстрим, а пушни-ка в апстримный гит :)
Comment 5 Michael Shigorin 2011-01-09 16:25:06 MSK 
...дело рук утопающих.