Bug 20941 - uuid_functions.c: always overflow destination buffer
Summary: uuid_functions.c: always overflow destination buffer
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: FreeAdhocUDF (show other bugs)
Version: unstable
Hardware: all Linux
: P3 normal
Assignee: Nobody's working on this, feel free to take it
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 19:16 MSD by solo
Modified: 2009-08-03 20:14 MSD (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description solo 2009-08-03 19:16:55 MSD 
gcc conv_functions.c -Wall -fpic -O -c  -I/usr/include -o conv_functions.o
In file included from /usr/include/string.h:658,
                 from uuid_functions.c:26:
In function 'memset',
    inlined from 'guid_to__uuid' at uuid_functions.c:135:
/usr/include/bits/string3.h:85: error: call to __builtin___memset_chk will always overflow destination buffer
make: *** [uuid_functions.o] Error 1
Comment 1 solo 2009-08-03 19:22:03 MSD 
$ rpm -qa|fgrep FreeAdhocUDF
FreeAdhocUDF-0.0.0.20090128a-alt0.1

$ rpm -qa|fgrep firebird
firebird-utils-superserver-2.1.1.17910.0-alt4
firebird-server-superserver-2.1.1.17910.0-alt4
firebird-superserver-2.1.1.17910.0-alt4
...

$ fbsql.superserver -u SYSDBA -p masterkey localhost:/var/lib/firebird/test.fdb
Database:  localhost:/var/lib/firebird/test.fdb, User: SYSDBA
...
SQL> SELECT F_UUID1RAND() FROM RDB$DATABASE;

F_UUID1RAND                          
==================================== 
f9b124c6-8040-11de-a3fb-8bd803f66b4c 

SQL> SELECT F_UUID2UUIDCOMPR('f9b124c6-8040-11de-a3fb-8bd803f66b4c') FROM RDB$DATABASE;

F_UUID2UUIDCOMPR       
====================== 
Statement failed, SQLCODE = -902
Unable to complete network request to host "localhost".
-Error reading data from the connection.
SQL>
Comment 2 solo 2009-08-03 20:14:44 MSD 
Patch: http://git.altlinux.org/people/solo/packages/?p=FreeAdhocUDF.git;a=commitdiff;h=f692c90fe3a301997ae2c1f1fb17b3c81b632ed8

$ rpm -qa|fgrep FreeAdhocUDF
FreeAdhocUDF-0.0.0.20090128a-alt2

$ rpm -qa|fgrep firebird
firebird-utils-superserver-2.1.1.17910.0-alt4
firebird-server-superserver-2.1.1.17910.0-alt4
firebird-superserver-2.1.1.17910.0-alt4
...

$ fbsql.superserver -u SYSDBA -p masterkey localhost:/var/lib/firebird/test.fdb
Database:  localhost:/var/lib/firebird/test.fdb, User: SYSDBA
...
SQL> SELECT F_UUID1RAND() FROM RDB$DATABASE;

F_UUID1RAND                          
==================================== 
9a35adf4-8046-11de-9da5-9e6bfab97493 

SQL> SELECT F_UUID2UUIDCOMPR('9a35adf4-8046-11de-9da5-9e6bfab97493') FROM RDB$DATABASE;

F_UUID2UUIDCOMPR       
====================== 
0SOzetR7CZbF5SU2OOBOro 

SQL> SELECT F_UUIDCOMPR2UUID('0SOzetR7CZbF5SU2OOBOro') FROM RDB$DATABASE;

F_UUIDCOMPR2UUID                     
==================================== 
69a35adf4-8046-11de-9da59e6bfab97493 

SQL>