Bug 25417 - [FR] some feedback on no-ops
Summary: [FR] some feedback on no-ops
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: apt-repo (show other bugs)
Version: unstable
Hardware: all Linux
: P3 enhancement
Assignee: Andrey Cherepanov
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 17:37 MSK by Michael Shigorin
Modified: 2011-05-09 09:48 MSK (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Shigorin 2011-04-11 17:37:14 MSK 
Хорошо бы или делать молча, или с данными аргументами делать ничего не пришлось -- то как-то об этом сообщить.  Запись пробной сессии as is:

root@pad ~ # apt-repo 
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus i586 classic
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
root@pad ~ # apt-repo --help
Usage:
     apt-repo> [list] [-a]
     apt-repo> add [APT|URL|branch|task] [name or component]
     apt-repo> rm [APT|URL|branch|task] [name or component]
     apt-repo> update

root@pad ~ # apt-repo rm rpm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
Nothing to remove: bad repository format. See -h for details.
root@pad ~ # apt-repo rm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic    
root@pad ~ # apt-repo 
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus i586 classic
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
root@pad ~ # apt-repo rm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
root@pad ~ # apt-repo                                                       
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus i586 classic
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
root@pad ~ # apt-repo rm file:/var/ftp/pub/Linux/ALT/Sisyphus               
root@pad ~ # apt-repo                                        
root@pad ~ # apt-repo add file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic
root@pad ~ # apt-repo                                                        
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus i586 noarch
rpm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch noarch
root@pad ~ # 

Команда apt-repo rm file:/var/ftp/pub/Linux/ALT/Sisyphus noarch classic никаких изменений не внесла (что само по себе не баг), предупреждений не вынесла (а вот тут бы поправить).  Также и apt-repo rm branch Sisyphus лучше бы предупредило -- "nothing to do" или что-нить вроде того.

Про "noarch noarch" сейчас отдельно повешу.
Comment 1 Andrey Cherepanov 2011-04-11 18:46:11 MSK 
Взял на вооружение.
Comment 2 Repository Robot 2011-05-09 09:48:23 MSK 
apt-repo-1.0.2-alt1 -> sisyphus:

* Mon May 09 2011 Andrey Cherepanov <cas@altlinux> 1.0.2-alt1
- Make error messages more informational (closes: #25417)
- Inform about missed task number
- Show all available branch names
- Complete documentation
- Support sources.list(5) tokens in command line
- Pass all arguments as parts of source line (closes: #25418)
- Support quick forms of source: known branch name or number for task
- Fix URL for Sisyphus. Support absolute pathname for hasher repo.